Sign in to follow this  
Pateman

OpenGL GLSL Skinning problem

Recommended Posts

Pateman    184

Hello community,

 
Ok, first of all, I'm using OpenGL 3, 3ds max, and Delphi to create a skeletal animation demo. I'm using the IGame interface to export meshes from 3ds max to XML - I use the sample included in the SDK.
 
Now, I'm going to describe as precisely as I can what I do.
 
Passing bone weights to the shader
I'll skip parsing geometry, because it works okay. Now, if a mesh is skinned (using the Physique modifier), the resulting XML contains information about bone influences for each vertex, like so:
    <Skin VertexID="2" Type="Rigid">
       <Bone BoneID="22" Weight="1,000000"></Bone>
    </Skin>
    ...
    <Skin VertexID="14" Type="Blended">
       <Bone BoneID="22" Weight="0,986472"></Bone>
       <Bone BoneID="14" Weight="0,013015"></Bone>
       <Bone BoneID="23" Weight="0,000513"></Bone>
    </Skin>
    ...
    <Skin VertexID="31" Type="Blended">
       <Bone BoneID="22" Weight="0,948354"></Bone>
       <Bone BoneID="23" Weight="0,030462"></Bone>
       <Bone BoneID="23" Weight="0,011265"></Bone>
       <Bone BoneID="14" Weight="0,009909"></Bone>
       <Bone BoneID="23" Weight="0,000011"></Bone>
    </Skin>

My shader assumes that there should be always 4 bones, which influence a single vertex, and as you can see, sometimes there is sulprus/insufficient number of them, so I decided to:

  1. Sum up weights of the same bone - take a look at vertex 31 - there are five entries, but after summing them up, we're left with three.
  2. Pad the remaining number of weights with zero.
Right now, I have a list of bone IDs/vertex weight pairs, which I pass to the shader like so:
    const
       MAX_BONES_PER_VERTEX = 4;
    
    type
       TVertexWeight = record
          BoneID: Integer;
          Weight: Single; // standard float
       end;
    ...
    var
      L: TList<TVertexWeight>;
    ...
    glGenBuffers(1, @FBonesVBO);
    glBindBuffer(GL_ARRAY_BUFFER, FBonesVBO);
    glBufferData(GL_ARRAY_BUFFER, L.ListSize, L.ListPointer, GL_STATIC_DRAW);
    
    glEnableVertexAttribArray(FBoneIDsAttr);
    glVertexAttribIPointer(FBoneIDsAttr, MAX_BONES_PER_VERTEX, GL_INT,
       SizeOf(TVertexWeight), PInteger(0));
    
    glEnableVertexAttribArray(FWeightsAttr);
    glVertexAttribPointer(FWeightsAttr, MAX_BONES_PER_VERTEX, GL_FLOAT,
       False, SizeOf(TVertexWeight), PInteger(4));

I think this part is working fine, because when I hardcode an identity matrix in the shader, the model is rendered in its bind pose.

 
Computing bone matrices
For now, I just want to display the model in a pose which it would be in, let's say, frame 49:
3oZhZ.png
 
Here's the code I use:
procedure CalculateBones(const SequenceName: String; const FrameID: Integer;
const ABone: TAnimatedMeshBone; const ParentTransform: TBrainMatrix);
var
   Samples: TBrainList<TAnimatedMeshAnimationSample>;
   BoneSample: TAnimatedMeshAnimationSample;
   I: Integer;
   BoneTransform, GlobalTransform: TBrainMatrix;
   Children: TBonesList;
begin
   Samples := TBrainList<TAnimatedMeshAnimationSample>.Create();
   Children := TBonesList.Create();
   try
      FAnims[SequenceName].SamplesByFrame(FrameID, Samples);
      BoneSample := nil;
      for I := 0 to Samples.Count -1 do
         if (Samples[I].Bone.ID = ABone.ID) then
         begin
            BoneSample := Samples[I];
            break;
         end;


      BoneTransform := ABone.OffsetMatrix;
      if (BoneSample <> nil) then
         BoneTransform := BoneSample.Matrix;
      
      GlobalTransform := Mat4Multiply(ParentTransform, BoneTransform);


      BoneMatrices.Add(GlobalTransform);


      FBones.BonesByParentID(ABone.ID, Children);
      for I := 0 to Children.Count -1 do
         CalculateBones(SequenceName, FrameID, Children[I], GlobalTransform);
   finally
      Samples.Free();
      Children.Free();
   end;
end;
...
BoneMatrices := TBrainList<TBrainMatrix>.Create();
try
   // A bone's offset matrix is the bind pose.
   CalculateBones('zhuxian2', 49, FBones.RootBone, FBones.RootBone.OffsetMatrix);
   glUniformMatrix4fv(FShader.GetUniformLocation('boneMatrices'),
      BoneMatrices.Count, False, BoneMatrices.ListPointer);
finally
   BoneMatrices.Free();
end;
A bone's OffsetMatrix is basically the bind pose (regarding to what the exporter says, it's in object space) of the bone. Now, a TAnimatedMeshAnimationSample contains position and rotation (in quaternion) of a bone in the given frame. The loop at the top of CalculateBones() basically checks if in the given frame (in this case, 49th) there's transformation data for the given bone.
 
After launching the code above, all I get is this: (please ignore the lack of textures for now)
HBJjC.png
 
But when I change the initial parent transform from FBones.RootBone.OffsetMatrix to Mat4Identity() (basically use an identity matrix), the model is displayed in its bind pose:
5hcab.png
 
Vertex shader code

 

#version 150


#define MAX_BONES_PER_VERTEX 4
#define MAX_BONES 32


uniform mat4 proj;
uniform mat4 modelview;
uniform mat4 boneMatrices[MAX_BONES];


in vec3 vertex;
in vec3 normal;
in vec2 texCoord;
in ivec4 boneIDs;
in vec4 boneWeights;


out vec4 fragmentColor;


float phong_weightCalc(in vec3 light_pos, in vec3 frag_normal) {
   return max(0.0, dot(frag_normal, light_pos));
}


mat4 getBoneMatrix(int boneIndex) {
   mat4 retMat = mat4(1.0);
   if (boneIDs[boneIndex] != 0) {
      retMat = boneMatrices[boneIDs[boneIndex]];
   }
   return retMat;   
}


float getWeight(int boneIndex) {
   float res = 1.0;
   if (boneIDs[boneIndex] != 0) {
      res = boneWeights[boneIndex];
   }
   return res;
}


void main() {
   vec3 EC_Light_location = vec3(0.0, 1.0, 1.0);
   
   float diffuse_weight = phong_weightCalc(
      normalize(EC_Light_location),
      normalize(normal)
   );
   
   fragmentColor = clamp(
      (
         (vec4(0.2, 0.2, 0.2, 1.0))
         + (vec4(0.8, 0.8, 0.8, 1.0) * diffuse_weight)
      ), 
      0.0, 1.0);
         
   float totalWeight = 0.0;
   vec4 PosL = vec4(0.0, 0.0, 0.0, 1.0);
   for (int i = 0; i < MAX_BONES_PER_VERTEX; i++) {
      float w = getWeight(i);
      PosL += w * (vec4(vertex, 1.0) * getBoneMatrix(i));
      totalWeight += w;
   }
   PosL /= totalWeight;
   PosL.w = 1.0;


   gl_Position = proj * modelview * PosL;
}

 

The question is, can someone point out what is wrong with the code?

 
Thank you very much.
 
PS. If you need any more information, please let me know.

 

Share this post


Link to post
Share on other sites
C0lumbo    4411

I'm afraid I haven't read through all the code, but one quick idea; when you create a 'Pad the remaining number of weights with zero' are you also setting the bone ID to something valid? I once had an issue on a console where a weight of zero combined with an invalid bone matrix to produce a non-zero garbage value on the GPU.

Share this post


Link to post
Share on other sites
Pateman    184

[quote name='C0lumbo' timestamp='1358784975' post='5023946']
when you create a 'Pad the remaining number of weights with zero' are you also setting the bone ID to something valid?
[/quote]

Yes, I set it to zero, then in the shader I verify whether the bone ID is set to 0, like so:

 

 

mat4 getBoneMatrix(int boneIndex) {
   mat4 retMat = mat4(1.0);
   if (boneIDs[boneIndex] != 0) {
      retMat = boneMatrices[boneIDs[boneIndex]];
   }
   return retMat;   
}

float getWeight(int boneIndex) {
   float res = 1.0;
   if (boneIDs[boneIndex] != 0) {
      res = boneWeights[boneIndex];
   }
   return res;
}

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By povilaslt2
      Hello. I'm Programmer who is in search of 2D game project who preferably uses OpenGL and C++. You can see my projects in GitHub. Project genre doesn't matter (except MMO's :D).
    • By ZeldaFan555
      Hello, My name is Matt. I am a programmer. I mostly use Java, but can use C++ and various other languages. I'm looking for someone to partner up with for random projects, preferably using OpenGL, though I'd be open to just about anything. If you're interested you can contact me on Skype or on here, thank you!
      Skype: Mangodoor408
    • By tyhender
      Hello, my name is Mark. I'm hobby programmer. 
      So recently,I thought that it's good idea to find people to create a full 3D engine. I'm looking for people experienced in scripting 3D shaders and implementing physics into engine(game)(we are going to use the React physics engine). 
      And,ye,no money =D I'm just looking for hobbyists that will be proud of their work. If engine(or game) will have financial succes,well,then maybe =D
      Sorry for late replies.
      I mostly give more information when people PM me,but this post is REALLY short,even for me =D
      So here's few more points:
      Engine will use openGL and SDL for graphics. It will use React3D physics library for physics simulation. Engine(most probably,atleast for the first part) won't have graphical fron-end,it will be a framework . I think final engine should be enough to set up an FPS in a couple of minutes. A bit about my self:
      I've been programming for 7 years total. I learned very slowly it as "secondary interesting thing" for like 3 years, but then began to script more seriously.  My primary language is C++,which we are going to use for the engine. Yes,I did 3D graphics with physics simulation before. No, my portfolio isn't very impressive. I'm working on that No,I wasn't employed officially. If anybody need to know more PM me. 
       
    • By Zaphyk
      I am developing my engine using the OpenGL 3.3 compatibility profile. It runs as expected on my NVIDIA card and on my Intel Card however when I tried it on an AMD setup it ran 3 times worse than on the other setups. Could this be a AMD driver thing or is this probably a problem with my OGL code? Could a different code standard create such bad performance?
    • By Kjell Andersson
      I'm trying to get some legacy OpenGL code to run with a shader pipeline,
      The legacy code uses glVertexPointer(), glColorPointer(), glNormalPointer() and glTexCoordPointer() to supply the vertex information.
      I know that it should be using setVertexAttribPointer() etc to clearly define the layout but that is not an option right now since the legacy code can't be modified to that extent.
      I've got a version 330 vertex shader to somewhat work:
      #version 330 uniform mat4 osg_ModelViewProjectionMatrix; uniform mat4 osg_ModelViewMatrix; layout(location = 0) in vec4 Vertex; layout(location = 2) in vec4 Normal; // Velocity layout(location = 3) in vec3 TexCoord; // TODO: is this the right layout location? out VertexData { vec4 color; vec3 velocity; float size; } VertexOut; void main(void) { vec4 p0 = Vertex; vec4 p1 = Vertex + vec4(Normal.x, Normal.y, Normal.z, 0.0f); vec3 velocity = (osg_ModelViewProjectionMatrix * p1 - osg_ModelViewProjectionMatrix * p0).xyz; VertexOut.velocity = velocity; VertexOut.size = TexCoord.y; gl_Position = osg_ModelViewMatrix * Vertex; } What works is the Vertex and Normal information that the legacy C++ OpenGL code seem to provide in layout location 0 and 2. This is fine.
      What I'm not getting to work is the TexCoord information that is supplied by a glTexCoordPointer() call in C++.
      Question:
      What layout location is the old standard pipeline using for glTexCoordPointer()? Or is this undefined?
       
      Side note: I'm trying to get an OpenSceneGraph 3.4.0 particle system to use custom vertex, geometry and fragment shaders for rendering the particles.
  • Popular Now