• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
sarim

Unhandled Exception When Using a List

7 posts in this topic

I started work on a pong game just to get back into game programming since it's been a while for me. Everything was working fine until I came about my current problem. I have an Entity Manager class that handles iterating through a list of entities within the game (paddles and ball) and rendering them. The program runs fine, however when I end it an Unhandled Exception pops up concerning the Release() of the texture the paddle has. The interesting thing is that if I run the program without the list and render the paddle manually, it works fine without the error. Hopefully someone knows what I'm doing wrong? Also after seeing the code if you have any suggestions on how I can make something cleaner or more efficient I would love to hear it smile.png

 

EntityManager.h

 

#ifndef ENTITYMANAGER
#define ENTITYMANAGER

#include "Globals.h"
#include "Entity.h"
#include <list>

class EntityManager
{

public:

	void Add( Entity &entity );

	void Update( LPD3DXSPRITE sprite );

private:

	std::list<Entity>           entities;
	std::list<Entity>::iterator iter;
};

#endif  ENTITYMANAGER

 

 

EntityManager.cpp

 

#include "EntityManager.h"

void EntityManager::Add( Entity &entity )
{
	entities.push_back( entity );
}

void EntityManager::Update( LPD3DXSPRITE sprite )
{
	iter = entities.begin();

	while ( iter != entities.end() )
	{
		sprite -> Draw( iter -> GetTexture(), NULL, NULL, iter -> GetPosition(), White );

		iter++;
	}
}

 

 

 

Game.h

 

#ifndef GAME_H
#define GAME_H

#include "Globals.h"
#include "DxManager.h"
#include "Entity.h"
#include "EntityManager.h"

class Game
{

public:

	bool Init( HWND &window );
	void Run();

private:

	HWND window;

	DxManager GManager;
	Entity    LeftPaddle;
	//Entity    RightPaddle;
	//Entity    Ball;

	EntityManager EManager;
};

#endif  GAME_H

 

 

Game.cpp

 

#include "Game.h"

bool Game::Init( HWND &window )
{
	this -> window = window;

	if ( !GManager.InitD3D( this -> window ) )
	{
		GameOver = true;
		return false;
	}

	LeftPaddle.LoadTexture( GManager.GetDevice(), "Resources/LeftPaddle.png" );

	EManager.Add( LeftPaddle );

	return true;
}

void Game::Run()
{
	GManager.Begin();
	
	EManager.Update( GManager.GetSprite() );

	//GManager.GetSprite() -> Draw( LeftPaddle.GetTexture(), NULL, NULL, LeftPaddle.GetPosition(), White ); * program runs fine if i use this line instead of EManager.Update( GManager.GetSprite() ); *

	GManager.End();
}

 

 

Error

 

First-chance exception at 0x000F14AA in Pong.exe: 0xC0000005: Access violation reading location 0xFEEEFEF6.
Unhandled exception at 0x000F14AA in Pong.exe: 0xC0000005: Access violation reading location 0xFEEEFEF6.

 

 

0

Share this post


Link to post
Share on other sites

The reason for the exception looks quite straightforward.

The destructor for EntityManager class is getting invoked while your update is still in process.

So you need to release the resources before your destructor gets invoked.

Common practice is to actually release the resources within the destructor.

Another practice, which is good to follow, is to have a start and stop thread mechanism, bonded with your renderer's constructor and destructor, respectively.

This way, you can ensure that the update run is not occurring while destruction of resources is in progress.

0

Share this post


Link to post
Share on other sites
Are you talking about releasing the resources with the destructor of the actual entity object? If so then you should know that it's what I'm already doing. However the program stops at the beginning of the entities destructor and throws the unhandled exception, so I'm not sure if its the destructor of the entity manager causing the problem?
0

Share this post


Link to post
Share on other sites

We don't have all of your code, and I suspect the cause for your problem exists in the code we can't see.

 

However, I have run into similar situations as this.  Your Entity is loading a resource (texture) that is provided by the GManager that manages DX resources. Both GManager and EntityManager are part of Game. It is likely that when an Entity is destroyed, it has to release whatever texture it has, and that GManager needs to be in a valid state in order to handle this resource release. But what happens if, when the Game object is destroyed, GManager is destroyed before EManager is? In this case, when EntityManager is destroyed (along with whatever Entity objects are contained in its list) then those Entity objects will be trying to release resources through GManager, but GManager has been destroyed already, so any internal state and methods called to release the resource will raise an exception.

0

Share this post


Link to post
Share on other sites
That sounds like it may actually be the problem. How do you think I should structure the code to eliminate this problem?
0

Share this post


Link to post
Share on other sites

Clear your entity list before Game destructor is called. Any assets that rely on GManager to be released should already be destroyed by the time Game, and thus GManager, are destroyed.

 

Alternatively, you could restructure your objects to guarantee an explicit order of destruction. If GManager and EManager are explicitly new-ed in your Game constructor, they can be explicitly deleted (either through delete, or through calling reset() if they are stored in a unique or shared ptr). This way, you can guarantee that EManager is deleted first.

Edited by FLeBlanc
0

Share this post


Link to post
Share on other sites
Thanks I'll try your advice when I get on and work on it... I'll let you know what happens
0

Share this post


Link to post
Share on other sites
So I tried doing what you said and created 'new' pointer objects in the constructor of Game and delete them in the destructor, however the result is the same. When the program ends the exception still occurs
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0