Sign in to follow this  
Followers 0
Helixirr

OpenGL
Wavefront OBJ file reading - Polygons connect incorrectly

5 posts in this topic

Hi, folks!

I have tried to create a 3D model class called Model3, which will inherit from my base class Model. This Model3-class supports only Wavefront OBJ files at the moment and I'm having trouble setting up correct data for OpenGL to process. I try to get rid of the deprecated OpenGL functions and use vertex array objects and vertex buffers objects instead to accomplish my goal to display a 3D model on screen.

The problem is rather simple to describe: polygons are formed incorrectly.

This is how I see the model in Blender (in which I also did the model):
[url="http://imageshack.us/photo/my-images/838/timg.png/"][url="http://imageshack.us/photo/my-images/838/timg.png/"][url="http://imageshack.us/photo/my-images/838/timg.png/"][url="http://imageshack.us/photo/my-images/838/timg.png/"]http://imageshack.us/photo/my-images/838/timg.png/[/url][/url][/url][/url]

And this is what ends up looking in my program:
[url="http://imageshack.us/photo/my-images/546/tim2i.png/"][url="http://imageshack.us/photo/my-images/546/tim2i.png/"][url="http://imageshack.us/photo/my-images/546/tim2i.png/"][url="http://imageshack.us/photo/my-images/546/tim2i.png/"]http://imageshack.us/photo/my-images/546/tim2i.png/[/url][/url][/url][/url]

 

Here's Model3 class definition:

/// ----------------------------------
    /// @class  	Model3
    /// @brief  	Represents a 3D model.
	/// @typedef	Model3D
    /// ----------------------------------
    typedef class Model3 : public Model{
    public:

		/// Enumerations:
		enum class FormatFile : unsigned int{
			FORMATFILE_3DS,
			FORMATFILE_OBJ
		};

        /// Constructors & destructors:
        Model3(void);
        Model3(Model3 const& model) = default;
        Model3(Model3&& model) = default;
		~Model3(void);

		/// Member functions:
		Model3& set_data(Model3::FormatFile const& format_file, std::string const& name_file);
		Model3& set_data(Model3::FormatFile const& format_file, std::string const&& name_file);
		Model3& set_data(Model3::FormatFile&& format_file, std::string const& name_file);
		Model3& set_data(Model3::FormatFile&& format_file, std::string const&& name_file);
		void show(void) const;

		/// Member functions (overloaded operators):
		Model3& operator=(Model3 const& model);
		Model3& operator=(Model3&& model);

    private:
        /// Member data:
		std::vector<Helixirr::Vector3<float>> _m_voDataFace[3]; // Element 0 contains vertex coordinates, element 1 contains texture coordinates, element 2 contains vertex normals.
		std::vector<Helixirr::Vector3<float>> _m_voDataVertex[3]; // Element 0 contains vertex coordinates, element 1 contains texture coordinates, element 2 contains vertex normals.
		unsigned int _m_uiIdArrayVertex, _m_uiBufferVertex;
	}Model3D;

 

Here are implementations of functions set_data and show:

/// Member functions:
Model3& Model3::set_data(Model3::FormatFile const& format_file, std::string const& name_file){ /* UNFINISHED! */
	std::ifstream __file(name_file);

	// 3D model loading lambdas:
	auto const __load_3ds = [&](void){
		/* UNFINISHED! */
	};
	auto const __load_obj = [&](void){ /* WORKS HALF RIGHT AND MORE FUNCTIONALITY IS REQUIRED! */
		auto const __read_data_vertices = [](std::string const& string, float coordinates[], unsigned int const&& amount_elements, unsigned int&& index_begin){
			// Variables used in the following for loop:
			// index_begin = end index for string substraction operation
			// __i = index of the temporary float array
			// __j = start index for string substraction operation
			for(unsigned int __i = 0, __j = index_begin; __i != amount_elements; ++__j){
				if(string[__j] == ' '){ // If the "end character" for floating number is detected:
					coordinates[__i++] = atof(string.substr(index_begin, ++__j).c_str());
					index_begin = __j;
				}
			}
		};

		std::string __line;
		clock_t init = clock();
		while(std::getline(__file, __line)){ // For each line in the requested file:
			switch(__line[0]){ // Check out the first letter of a line:
				case 'f':{
					// Read through the whole line ignoring all the insignificant characters (like '\n'):
					for(unsigned int __i = 2, __j = 2, __k = 0; __j != __line.size() - 1; ++__j){
						if(__line[__j] == '/'){
							_m_voDataFace[__k].push_back(_m_voDataVertex[__k][atoi(__line.substr(__i, ++__j).c_str())]);
							__i = __j;
							++__k;
						}
						else if(__line[__j] == ' '){
							++__j;
							__i = __j;
							__k = 0;
						}
					}
					continue;
				}
				case 'v': // If a requested line contains some sort of vertex data:
					if(__line[1] == ' '){ // If the requested line contains vertex coordinates:
						float __coordinates[3] = {0.0f}; // A temporary float array to store vertex coordinates.
						__read_data_vertices(__line, __coordinates, 3, 2);
						_m_voDataVertex[0].push_back(Helixirr::Vector3<float>(std::move(__coordinates[0]), std::move(__coordinates[1]), std::move(__coordinates[2])));
					}
					else if(__line[1] == 'n'){ // If the requested line contains vertex normals:
						float __coordinates[3] = {0.0f}; // A temporary float array to store vertex normals.
						__read_data_vertices(__line, __coordinates, 3, 3);
						_m_voDataVertex[2].push_back(Helixirr::Vector3<float>(std::move(__coordinates[0]), std::move(__coordinates[1]), std::move(__coordinates[2])));
					}
					else if(__line[1] == 't'){ // If the requested line contains UV coordinates:
						float __coordinates[2] = {0.0f}; // A temporary float array to store UV coordinates.
						__read_data_vertices(__line, __coordinates, 2, 3);
						_m_voDataVertex[1].push_back(Helixirr::Vector3<float>(std::move(__coordinates[0]), std::move(__coordinates[1]), 0.0f));
					}
					continue;
				default:
					continue;
			}
		}
		printf("OBJ file loading - elapsed time: %f\n", static_cast<double>(clock() - init) / static_cast<double>(CLOCKS_PER_SEC));
	};

	// Detect requested file format:
	switch(format_file){
		case Model3::FormatFile::FORMATFILE_3DS:
			__load_3ds();
			break;
		case Model3::FormatFile::FORMATFILE_OBJ:
			__load_obj();
			break;
		default:
			break;
	}

	// Create and bind a vertex array:
	if(_m_uiIdArrayVertex == 0)
		glGenVertexArrays(1, &_m_uiIdArrayVertex);
	glBindVertexArray(_m_uiIdArrayVertex);

	// Create and bind a vertex buffer object:
	if(_m_uiBufferVertex == 0)
		glGenBuffers(1, &_m_uiBufferVertex);
	glBindBuffer(GL_ARRAY_BUFFER, _m_uiBufferVertex);

	// Insert vertex data:
	glBufferData(GL_ARRAY_BUFFER, sizeof(_m_voDataFace[0][0]) * _m_voDataFace[0].size(), &_m_voDataFace[0][0], GL_STATIC_DRAW);

	return *this;
}
Model3& Model3::set_data(Model3::FormatFile const& format_file, std::string const&& name_file){
	return this->set_data(format_file, name_file);
}
Model3& Model3::set_data(Model3::FormatFile&& format_file, std::string const& name_file){
	return this->set_data(format_file, name_file);
}
Model3& Model3::set_data(Model3::FormatFile&& format_file, std::string const&& name_file){
	return this->set_data(format_file, name_file);
}
void Model3::show(void) const{
	glEnableVertexAttribArray(0);
	glBindBuffer(GL_ARRAY_BUFFER, _m_uiBufferVertex);
	glVertexAttribPointer(0, 3, GL_FLOAT, GL_FALSE, 0, 0);

	glEnable(GL_POINT_SMOOTH);
	glPointSize(2.0f);

	glDrawArrays(GL_TRIANGLES, 0, _m_voDataFace[0].size() + 1);
	glDisableVertexAttribArray(0);
}


I don't understand what have I done wrong. Can anybody help me?

Edited by Helixirr
0

Share this post


Link to post
Share on other sites

Looks like you're not converting the vertex indices. The obj-file has 1-based indices but std::vector has 0-based indices.

2

Share this post


Link to post
Share on other sites

Looks like you're not converting the vertex indices. The obj-file has 1-based indices but std::vector has 0-based indices.

 

Thanks for the reply. Now, what does this mean? What are these vertex indices anyway? Am I reading OBJ file incorrectly? How do I practically do this conversion?

0

Share this post


Link to post
Share on other sites

In C++, an index is 0-based which means that the first element of an array has index 0, the second element has index 1, the third element has index 2, and so on. The OBJ file is 1-based, which means that the first vertex has index 1, the second vertex has index 2, the third vertex has index 3, and so on. Therefore, you cannot read an index from the OBJ file and use it directly to reference a C++ array.

 

The indices are what you read from the f-lines. For example, "f 1 2 3" means: the face is made up of three vertices (because there are three values), and the vertices are the vertex with index 1, the vertex with index 2, and the vertex with index 3.

2

Share this post


Link to post
Share on other sites

It means read the index from the .OBJ file, subtract one, and use that value in your std::vector.

 

 

L. Spiro

 

 

PS: Heh, and here I am always being so vocal against spoon-feeding. tongue.png

Edited by L. Spiro
1

Share this post


Link to post
Share on other sites

In C++, an index is 0-based which means that the first element of an array has index 0, the second element has index 1, the third element has index 2, and so on. The OBJ file is 1-based, which means that the first vertex has index 1, the second vertex has index 2, the third vertex has index 3, and so on. Therefore, you cannot read an index from the OBJ file and use it directly to reference a C++ array.

 

The indices are what you read from the f-lines. For example, "f 1 2 3" means: the face is made up of three vertices (because there are three values), and the vertices are the vertex with index 1, the vertex with index 2, and the vertex with index 3.

 

It means read the index from the .OBJ file, subtract one, and use that value in your std::vector.

 

 

L. Spiro

 

 

PS: Heh, and here I am always being so vocal against spoon-feeding. tongue.png

 

Now, after reading all this, I feel so stupid not to have realized, what I did wrong. Oh boy... rolleyes.gif

 

Fortunately, it works now. Thank you, God and thank you all. smile.png

 

Here is the working piece of code with a slight modification dedicated for those who are also interested in reading an OBJ file and putting OBJ file data into OpenGL. Please, have a look:

 

/// ----------------------------------
    /// @class  	Model3
    /// @brief  	Represents a 3D model.
	/// @typedef	Model3D
    /// ----------------------------------
    typedef class Model3 : public Model{
    public:

		/// Enumerations:
		enum class FormatFile : unsigned int{
			FORMATFILE_3DS,
			FORMATFILE_OBJ
		};

        /// Constructors & destructors:
        Model3(void);
        Model3(Model3 const& model) = default;
        Model3(Model3&& model) = default;
		~Model3(void);

		/// Member functions:
		Model3& set_data(Model3::FormatFile const& format_file, std::string const& name_file);
		Model3& set_data(Model3::FormatFile const& format_file, std::string const&& name_file);
		Model3& set_data(Model3::FormatFile&& format_file, std::string const& name_file);
		Model3& set_data(Model3::FormatFile&& format_file, std::string const&& name_file);
		void show(void) const;

		/// Member functions (overloaded operators):
		Model3& operator=(Model3 const& model);
		Model3& operator=(Model3&& model);

    private:
        /// Member data:
		std::vector<Helixirr::Vector3<float>> _m_voDataFace[3]; // Element 0 contains vertex coordinates, element 1 contains texture coordinates, element 2 contains vertex normals.
		std::vector<Helixirr::Vector3<float>> _m_voDataVertex[3]; // Element 0 contains vertex coordinates, element 1 contains texture coordinates, element 2 contains vertex normals.
		unsigned int _m_uiIdArrayVertex, _m_uiBufferVertex;
	}Model3D;
/// Member functions:
Model3& Model3::set_data(Model3::FormatFile const& format_file, std::string const& name_file){ /* UNFINISHED! */
	std::ifstream __file(name_file);

	// 3D model loading lambdas:
	auto const __load_3ds = [&](void){
		/* UNFINISHED! */
	};
	auto const __load_obj = [&](void){ /* WORKS HALF RIGHT AND MORE FUNCTIONALITY IS REQUIRED! */
		auto const __read_data_vertices = [](std::string const& string, float coordinates[], unsigned int const&& amount_elements, unsigned int&& index_begin){
			// Variables used in the following for loop:
			// index_begin = end index for string substraction operation
			// __i = index of the temporary float array
			// __j = start index for string substraction operation
			for(unsigned int __i = 0, __j = index_begin; __i != amount_elements; ++__j){
				if(string[__j] == ' '){ // If the "end character" for floating number is detected:
					coordinates[__i++] = atof(string.substr(index_begin, ++__j).c_str());
					index_begin = __j;
				}
			}
		};

		std::string __line;
		clock_t init = clock();
		while(std::getline(__file, __line)){ // For each line in the requested file:
			switch(__line[0]){ // Check out the first letter of a line:
				case 'f':{
					// Read through the whole line ignoring all the insignificant characters (like '\n'):
					for(unsigned int __i = 2, __j = 2, __k = 0; __j != __line.size() - 1; ++__j){
						if(__line[__j] == '/'){
							_m_voDataFace[__k].push_back(_m_voDataVertex[__k][atoi(__line.substr(__i, ++__j).c_str()) - 1]);
							__i = __j;
							++__k;
						}
						else if(__line[__j] == ' '){
							++__j;
							__i = __j;
							__k = 0;
						}
					}
					continue;
				}
				case 'v': // If a requested line contains some sort of vertex data:
					if(__line[1] == ' '){ // If the requested line contains vertex coordinates:
						float __coordinates[3] = {0.0f}; // A temporary float array to store vertex coordinates.
						__read_data_vertices(__line, __coordinates, 3, 2);
						_m_voDataVertex[0].push_back(Helixirr::Vector3<float>(std::move(__coordinates[0]), std::move(__coordinates[1]), std::move(__coordinates[2])));
					}
					else if(__line[1] == 'n'){ // If the requested line contains vertex normals:
						float __coordinates[3] = {0.0f}; // A temporary float array to store vertex normals.
						__read_data_vertices(__line, __coordinates, 3, 3);
						_m_voDataVertex[2].push_back(Helixirr::Vector3<float>(std::move(__coordinates[0]), std::move(__coordinates[1]), std::move(__coordinates[2])));
					}
					else if(__line[1] == 't'){ // If the requested line contains UV coordinates:
						float __coordinates[2] = {0.0f}; // A temporary float array to store UV coordinates.
						__read_data_vertices(__line, __coordinates, 2, 3);
						_m_voDataVertex[1].push_back(Helixirr::Vector3<float>(std::move(__coordinates[0]), std::move(__coordinates[1]), 0.0f));
					}
					continue;
				default:
					continue;
			}
		}
		printf("OBJ file loading - elapsed time: %f\n", static_cast<double>(clock() - init) / static_cast<double>(CLOCKS_PER_SEC));
	};

	// Detect requested file format:
	switch(format_file){
		case Model3::FormatFile::FORMATFILE_3DS:
			__load_3ds();
			break;
		case Model3::FormatFile::FORMATFILE_OBJ:
			__load_obj();
			break;
		default:
			break;
	}

	// Create and bind a vertex array:
	if(_m_uiIdArrayVertex == 0)
		glGenVertexArrays(1, &_m_uiIdArrayVertex);
	glBindVertexArray(_m_uiIdArrayVertex);

	// Create and bind a vertex buffer object:
	if(_m_uiBufferVertex == 0)
		glGenBuffers(1, &_m_uiBufferVertex);
	glBindBuffer(GL_ARRAY_BUFFER, _m_uiBufferVertex);

	// Insert vertex data:
	glBufferData(GL_ARRAY_BUFFER, sizeof(_m_voDataFace[0][0]) * _m_voDataFace[0].size(), &_m_voDataFace[0][0], GL_STATIC_DRAW);

	return *this;
}
Model3& Model3::set_data(Model3::FormatFile const& format_file, std::string const&& name_file){
	return this->set_data(format_file, name_file);
}
Model3& Model3::set_data(Model3::FormatFile&& format_file, std::string const& name_file){
	return this->set_data(format_file, name_file);
}
Model3& Model3::set_data(Model3::FormatFile&& format_file, std::string const&& name_file){
	return this->set_data(format_file, name_file);
}
void Model3::show(void) const{
	glEnableVertexAttribArray(0);
	glBindBuffer(GL_ARRAY_BUFFER, _m_uiBufferVertex);
	glVertexAttribPointer(0, 3, GL_FLOAT, GL_FALSE, 0, 0);

	glEnable(GL_POINT_SMOOTH);
	glPointSize(2.0f);

	glDrawArrays(GL_TRIANGLES, 0, _m_voDataFace[0].size() + 1);
	glDisableVertexAttribArray(0);
}

 


 

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • By Jon Alma
      Some time ago I implemented a particle system using billboarding techniques to ensure that the particles are always facing the viewer.  These billboards are always centered on one 3d coordinate.
      I would like to build on this and use billboarding as the basis for things like laser bolts and gunshots.  Here the difference is that instead of a single point particle I now have to draw a billboard between two points - the start and end of the laser bolt for example.  I appreciate that having two end points places limits on how much the billboard can be rotated to face the viewer, but I'm looking to code a best effort solution.  For the moment I am struggling to work out how to do this or find any tutorials / code examples that explain how to draw a billboard between two points ... can anyone help?
      Thanks.
    • By Sagaceil
      It's always better to fight with a bro.
    • By recp
      Hi,
      I'm working on new asset importer (https://github.com/recp/assetkit) based on COLLADA specs, the question is not about COLLADA directly
      also I'm working on a new renderer to render (https://github.com/recp/libgk) imported document.
      In the future I'll spend more time on this renderer of course, currently rendering imported (implemented parts) is enough for me
      assetkit imports COLLADA document (it will support glTF too),
      importing scene, geometries, effects/materials, 2d textures and rendering them seems working
      My actual confusion is about shaders. COLLADA has COMMON profile and GLSL... profiles,
      GLSL profile provides shaders for effects so I don't need to wory about them just compile, link, group them before render

      The problem occours in COMMON profile because I need to write shaders,
      Actually I wrote them for basic matrials and another version for 2d texture
      I would like to create multiple program but I am not sure how to split this this shader into smaller ones,

      Basic material version (only colors):
      https://github.com/recp/libgk/blob/master/src/default/shader/gk_default.frag
      Texture version:
      https://gist.github.com/recp/b0368c74c35d9d6912f524624bfbf5a3
      I used subroutines to bind materials, actually I liked it,
      In scene graph every node can have different program, and it switches between them if parentNode->program != node->program
      (I'll do scene graph optimizations e.g.  view frustum culling, grouping shaders... later)

      I'm going to implement transparency but I'm considering to create separate shaders,
      because default shader is going to be branching hell
      I can't generate shader for every node because I don't know how many node can be exist, there is no limit.
      I don't know how to write a good uber-shader for different cases:

      Here material struct:
      struct Material { ColorOrTexture emission; ColorOrTexture ambient; ColorOrTexture specular; ColorOrTexture reflective; ColorOrTexture transparent; ColorOrTexture diffuse; float shininess; float reflectivEyety; float transparency; float indexOfRefraction; }; ColorOrTexture could be color or 2d texture, if there would be single colorOrTex then I could split into two programs,
      Also I'm going to implement transparency, I am not sure how many program that I needed

      I'm considering to maintain a few default shaders for COMMON profile,
      1-no-texture, 2-one of colorOrTexture contains texture, 3-........

      Any advices in general or about how to optimize/split (if I need) these shaders which I provied as link?
      What do you think the shaders I wrote, I would like to write them without branching if posible,
      I hope I don't need to write 50+ or 100+ shaders, and 100+ default programs

      PS: These default shaders should render any document, they are not specific, they are general purpose...
             I'm compiling and linking default shaders when app launched

      Thanks
    • By CircleOfLight97
      Hi guys,
      I would like to contribute to a game project as a developer (open source possibly). I have some experiences in C/C++ in game development (perso projects). I don't know either unreal or unity but I have some knowledges in opengl, glsl and shading theory as I had some courses at university regarding to that. I have some knowledges in maths and basic in physics. I know a little how to use blender to do modelling, texturing and simple game assets (no characters, no animation no skinning/rigging). I have no game preferences but I like aventure game, dungeon crawler, platformers, randomly generated things. I know these kind of projects involve a lot of time and I'd be really to work on it but if there are no cleary defined specific design goals/stories/gameplay mechanics I would like to not be part of it x) and I would rather prefer a smaller but well defined project to work on that a huge and not 'finishable' one.
      CircleOfLight97
    • By gamesthatcouldbeworse
      Hi, I finally released KILL COMMANDO on gamejolt for free. It is a retro-funsplatter-shooter with C64 style. Give it a try.
  • Popular Now