• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
johnmarinelli

Some confusion about the Singleton pattern

2 posts in this topic

Hi guys,

 

I'm programming a game with various game states.  I've created an Entity Manager class, and in that class I add all my objects.  However, I also create a special, static pointer to my Player.  This is for transferring the Player data between game states.  

/*pseudocode*/

c_Entity_manager{
private:
    static c_Player *player;

public:
    static void addPlayer( c_Player *p ){ player = p; };
    static c_Player* getPlayer(){return player;};
}; 

c_State1{
private:
    c_Player*  state1_player;

public:
    state1_player = c_Entity_manager::getPlayer();
};

c_State2{
private:
    c_Player*  state2_player;

public:
    state2_player = c_Entity_manager::getPlayer();
};

/*etc...*/

 

 

I'm almost certain this is considered a "singleton" pattern, and although I know that some argue that I should focus on whatever solves my problem and not worry too much about design, I know this is a common problem and I would like to break what could be a bad habit.

 

So, my questions are:
Is this considered a singleton pattern?  If not, is it an effective way of passing data between states?

If it is, what is an alternative way to transfer a persistent objects' (for example, a player) data  between states?

Edited by johnmarinelli
0

Share this post


Link to post
Share on other sites
This isn't a singleton pattern.
A singleton is a class of which one and only one instance is allowed to exist. This is normally achieved by making the constructor, and the copy constructor private, and having a static function (usually named Instance() ) that returns the instance of that class (creating it if it doesn't exist), one version of which looks like this:
SomeClass* SomeClass::Instance(){  static SomeClass instance;  return &instance;}
You can just have the requirement that each of your states is initialized with a pointer to the player, which is what I do. Just create the player in whatever class owns/creates/manages each state, since it looks like you want the player to be persistent outside those states anyway. You don't even have to dynamically allocate the player, just make it a non-pointer class member of the class that manages your states. Edited by Milcho
0

Share this post


Link to post
Share on other sites

If your game states inherit from a common base class, Player can belong to the base class as a static pointer.

 

Mine does that - the base class has a static pointer to GameStructure which is only pre-declared and not used in the base class at all.

The actual GameStructure is declared separately and has no internal knowledge of game states, only having a pointer to the root namestate.

 

Derived GameStates are defined elsewhere, and #include the GameStructure in their .cpp file, so they can actually use GameStructure.

GameStructure contains the Area, Player, Camera, the root GameState, and receives and forwards the player input and messages. It used to include the Window as well, but for ease-of-porting I preemptively separated the windowing system from GameStructure.

 

This seemed the most straightforward and easiest route for my code, while maintaining clear divisions between classes.

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0