• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
cozzie

Unity
if statement in for loop, brackets needed?

32 posts in this topic

Hi,

 

Just a simple question, with a nice opportunity to clean my code :)

I'm not sure when I need to use brackets in a for loop, depending on the code that needs to be executed for each iteration.

 

Example, I have:

 

for(mat=0;mat<mNrMaterials;++mat) 
{	
	if(materials[mat]) ++mEffect[fx].nrMaterials; 
}

Would the result be the same if I use:

 

for(mat=0;mat<mNrMaterials;++mat) 
	if(materials[mat]) ++mEffect[fx].nrMaterials; 

I know that I can leave the brackets out if I just have one line of code for each iteration, like:

 

for(int i=0;i<5;++i)
  something[i] = i*2;

Anyone?

0

Share this post


Link to post
Share on other sites

I use unbraced forks only for if-wrapped return, continue, break, and throw statements, because those don't have "else" forks; any subsequent code is an "else" after that.

 

But, I also tend to write very dense loops, frequently without an actual body, so sometimes the body of my loops ends up being a single semicolon, ie

for(int i=0, j=arraylength-1; i<j; array[j--]=array[i++]) ;

 

And that just becomes more unreadable when I waste essentially blank lines putting empty braces on the following couple lines.

0

Share this post


Link to post
Share on other sites

I have settled on using curly braces when there is more than one line in the body


I'll throw another vote in this pile. I use no curly braces when the statement does not have its own block scope, and when it can fit cleanly on one line. If it requires two, I put braces on it. Since I put if statements on a separate line from what is executed conditionally, then that means that that is enclosed in braces, too. I do agree that extra braces reduces the possibility of human error; I may consider doing it all the time at a later point. In effect, I use no braces when the block looks concise enough that it can be readily understood as being the sole statement of the block, and that no more statements would be added. If I have to debug, I add braces, output the values, then remove braces when I remove the output code.

In my mind, where I parse the source linearly, a no-brace if statement gives me an explicit measure of what the conditional encompasses, and it looks aesthetically pleasing to my eye at how the simple things appear very obviously simple.

However, once I must team up with someone that is prone to human error in these kinds of places, I'd probably opt to ensure that we aren't each other's downfall.
1

Share this post


Link to post
Share on other sites
My rule for [tt]if[/tt] and brackets is if there is an [tt]else[/tt] then brackets need to go on both halves and an [tt]if[/tt] containing an [tt]if[/tt] or a loop statement requires brackets on the outermost [tt]if[/tt]. So
// fine
if (a) foo;

if (a) if (b) foo; // no good instead do:
if (a) {
  if (b) foo;
}

if (a) for (;;); // also bad, instead:
if (a) {
  for (;;);
}

// fine
if (a) {
  foo;
} else {
  bar;
}
Similarly, for loop statements a loop containing a loop or an if requires brackets.
0

Share this post


Link to post
Share on other sites

My rule is to ALWAYS use braces no matter how little code is inside them.  It is just a more secure way of coding.  There are already resons mentioned above.  But my personal favorite was a senior coder (who was also a complete fuckwit) I worked with a couple of years ago made it a rule that single lines should not have brackets. He also had a list of debug macros that he used.

Instead of disableing the macros when he did a release he just did a grep and replace to comment out all the macros. 

 

So we ended up with:

<get some data>

if(<a problem with data>)  //<commented out macro here>

 

<do processing on the data>
 

 

This pattern by the way he had used in several hundred places throughout the project.  Then he blamed the rest of us for it not working even though we had told him his code was shocking during every single code review.

1

Share this post


Link to post
Share on other sites

For me brackets or not seems just like a matter of style. If there are none and you add a second line, surely you should know you also need to add brackets.

But putting the body on the same line as the if is annoying if you happen to want to put a breakpoint there or single step the if, as you cant easily see then if the body was actually run.

Edited by wintertime
0

Share this post


Link to post
Share on other sites

There is only one case where I feel its acceptable to omit braces.

It's for one line tests with simple expressions like this:

 

if(!some_object) some_object = new SomeClass();

 

If you want to add a second line, you have to start with adding a line break, and at that point, it's very obvious that you need to add brackets too. 

Even with stress levels high.

 

 

For me brackets or not seems just like a matter of style. If there are none and you add a second line, surely you should know you also need to add brackets.

Well, the only protection against idiotic programmers is better hiring and firing decisions. Bracketing conventions won't do.

 

Easy to say until that day you sit there with the deadline looming over your head, with stress levels at max, trying to fix that last show stopper bug.

The "just going to add some print out" happens very easily... And you really dont want to spend even 5 minutes with something like that, totally breaks your flow.

 

Clean and consistent code = less bugs and frustration

always.

Edited by Olof Hedman
1

Share this post


Link to post
Share on other sites

I have spent decades coding in C-like languages.  I have seen a significantly disproportionate number of software error arising from not using braces in control statements than from (almost) any other construct.  The 'other construct' is mistaking '=' for '==' in comparisons, but that's less easily avoided.

 

The problem doesn't come from writing new code.  The problem comes from maintaining existing code.  Remember that all code is existing code the moment you're finished typing it.

 

I have worked on projects in which the formalized and enforced coding style dictates that a single line in a control construct should never use braces, likely in an attempt to save on electrons.  With one significant exception, every such project has had a higher bug rate and higher maintenance cost.  The one exception has a very large automated test suite (which takes hours to run) but is under very restricted maintenance, since it's a standard library with strongly defined functionality and wide distribution.

 

There are, of course, strong opinions on the aesthetic of brace usage in coding style.  Such opinions are significantly more important than practical issues such as minimizing maintenance costs or maximizing software reliability.

2

Share this post


Link to post
Share on other sites

Ho boy, a bracketing convention debate.

 

My advice is to always use braces.

 

In practice, I add braces only when I need them, but don't remove them when the need disappears, such as if debug code is removed or the code is reformatted.

 

Also, I always use a newline after all if statements and non-empty loops. Empty loops get a pair of braces on the same line. 

0

Share this post


Link to post
Share on other sites

Empty loops get a pair of braces on the same line.


That's an interesting idea. I use empty braces on the same line for an empty function or class definition. My empty loops look like this:
while(*(src++) = *(dst++))

        ;

 

I guess I just feel like loop bodies should start on the next line, no matter what. I'm also strongly against semi-colon on the same line to prevent things like this:
for(;;);
{
//Why am I not executed as expected?
}

Edited by Ectara
0

Share this post


Link to post
Share on other sites

I have programmed in C-like languages for aboud 20 years now, 13 of them professionally. I have never ever seen a problem with the use of braces.

 

I find that hard to belive that in 13 years of proffesional coding you have never once found a bug written by either you or by someone else that involved incorrect use of braces.

 

1

Share this post


Link to post
Share on other sites


I have programmed in C-like languages for aboud 20 years now, 13 of them professionally. I have never ever seen a problem with the use of braces.

 
I find that hard to belive that in 13 years of proffesional coding you have never once found a bug written by either you or by someone else that involved incorrect use of braces.


I'm telling you, I can't remember one. As I said, emacs makes it very obvious if you are writing at the wrong level of indentation. Also, perhaps our testing procedures are good at catching that type of mistake.
0

Share this post


Link to post
Share on other sites

I have programmed in C-like languages for aboud 20 years now, 13 of them professionally. I have never ever seen a problem with the use of braces. So I don't think it's that important.

I have. Once. (though I've got much less experience than you). It was in the FFmpeg source code. Indentation levels indicated the else statement was part of a different if block, but actual control flow was otherwise. The actual logic ended up being correct, but anyone reading the code was likely to misread the code (like I did initially) because of incorrect indentation levels and a complete lack of braces. That was a fun day.

0

Share this post


Link to post
Share on other sites

I have programmed in C-like languages for aboud 20 years now, 13 of them professionally. I have never ever seen a problem with the use of braces. So I don't think it's that important.It could also depend on what editor you use. Emacs understands the level of indentation you are at, so when you go to add a second line to the `then' clause, the cursor will go to a place where it's obvious that you need braces.I agree with everyone that the most clear style should be used. So use whatever you think is more clear.


I agree with this, after (is it 15 now?) years of coding i have never seen anyone accidentally add code to a statement without braces and failing to add them. Part of it might be because I have mostly worked with coding styles that dictate braces on new lines, and ide/editor support, as you say.
0

Share this post


Link to post
Share on other sites

Empty loops get a pair of braces on the same line.


That's an interesting idea. I use empty braces on the same line for an empty function or class definition. My empty loops look like this:
while(*(src++) = *(dst++))

        ;

 

I guess I just feel like loop bodies should start on the next line, no matter what. I'm also strongly against semi-colon on the same line to prevent things like this:
for(;;);
{
//Why am I not executed as expected?
}

It's nice to have the same convention for all blocks, including both functions and loops. And {} is much more noticeable than ;, in part because one doens't normally put {} after a statement otherwise, and in part because it actually means something different for functions, so we're trained to notice it.

1

Share this post


Link to post
Share on other sites

As I said, emacs makes it very obvious if you are writing at the wrong level of indentation.

To my mind this is 90% of it. If you aren't using an editor that is highly aware of syntax (vim, emacs, sublime, etc), then informal code conventions are going to trip you up.

I really don't know why so many programmers adamantly continue to use inferior tools. For example:
[source]$ g++ -Wall test.cpp[/source]
versus:
[source]$ clang++ test.cpp
test.cpp:5:12: warning: if statement has empty body [-Wempty-body]
if (1 < 2);
          ^
test.cpp:5:12: note: put the semicolon on a separate line to silence this warning[/source]

0

Share this post


Link to post
Share on other sites

But a syntax-aware editor is not going to catch the valid use of valid syntax.

All of my primary editors fix the incorrect indentation there - it doesn't make the bug go away, but it makes it damn easy to spot during code reviews.
 

Code is meant to be read, after all, not written, and that includes when looking at diffs during code reviews and online in VCS webviews, where building in a context-sensitive C++ front-end is just not going to cut it.

Then auto-format all your code using a pre-checkin hook on your version control.

 

You should probably be doing this anyway, to deal with funky whitespace issues.
 

Oh, and condemning tools as inferior because you do not know how to use them says less about the tools.

The point isn't that I don't know how to use gcc (I do), the problem is that it's off by default, and many users don't know how to turn it on. The whole idea that -Wall does not, in fact, turn on *all* warnings, is a bit of a non sequitur.

1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • By NA-45
      EDIT: We've found a designer/composer and an artist.  I'm looking for one more artist!
       
      I'm currently working on Metroidvania style game that I was inspired to start by Hollow Knight and Beksiński's art.

       It's built in Unity using C# and has quite a bit done already.  I'm handling the programming myself and have a working model (besides combat which is a WIP) that can be expanded greatly depending on where we decide to take the project.  You can see the current test area here: https://streamable.com/mp5o8  Since I'm not artistically gifted, its all rectangles but can easily be skinned once we've desired on designs.
      I have professional experience using Unity and C# working on both a released game and a prototype as well as having extensive Java knowledge.  I also dabble in Python with a little bit of C++.
      I have worked on and completed many projects before, the most recent being a 2D stick fighting game written ground up in Java Swing (don't ask why): https://www.youtube.com/watch?v=V4Bkoyp_f0o
      I'm looking for a 2D artist (potentially more than one) to create concept and game art and a designer/writer who can help flesh out the story as well as map out and create challenging and eye catching areas.  I can handle most if not all of the programming side of things though if there is anyone who is extremely passionate about this sort of thing, I'd consider splitting the load.
      The end goal is a completed game that can be sold however profit isn't really a concern to me as it's mostly a labor of love from my part.  Any profits would be split between team members however that's pretty far off so don't make that a reason to join.
      ______________________________
      The story I have in mind is something like this:
      A man wakes up in a chasm that stretches seemingly endlessly in both directions lined with enormous statues.

       He discovers a temple with text above a closed gate that tells of the failed kingdom that lies below.  After finding a way around this, he drops down into the subterranean kingdom.  Adventuring through the labrynth below, he comes across different cities in which the residents succumbed to different sins such as Greed, Wrath, etc.  Each city tells a story of how its fixation on something lead to their demise leading up to a fight with the personification of their mistake.
      ______________________________
      An very rough idea for Waterways, a potential area:
       - To enter you must be wearing a pair of glasses that you find somewhere earlier in the ruins.  There are similar glasses found in every home.  Everything appears incredibly beautiful however something seems wrong.  After triggering some event, the glasses break and it's revealed that the glasses are made of some sort of stone that makes everything appear differently.  The city is in ruins and absolutely disgusting as everything was neglected.  
       - The only thing that remains intact is in the center of the city, an incredible statue of a goddess holding up a large sphere of the same material that was used for the glass.  You slowly learn the story behind the statue: the goddess came from the sea that the city lies on and brought prosperity to them.  
       - After opening up the the temple of the goddess that lies right on the edge of the waters, a giant sheet of the glass covers an opening in the back of the temple that reveals the goddess behind it.  You shatter the glass and it becomes apparent that the goddess is actually a disgusting creature half beached and mostly immobile that appears to secrete the material that makes up the glass. Fight ensues.
      ______________________________
      The combat is pretty up in the air and part of the reason I need a designer to bounce ideas off of but I think it will be something like this:
       - 4 orbs equipped at a time
       - 2 orbs selected at a time
       - Pressing the cast button will cast a spell determined by the 2 orbs that are selected
       - Spells cost mana however you can use spells with 0 mana and it will cost health instead
       - These spells in addition to being useful for combat, are the Metroidvania "gating" metchanic.  For instance, one of the conceptualized spells is a water orb + water orb to create a ice pillar that can be either used to block projectiles/enemy paths or to jump on to reach high areas
      ______________________________
      If you're interested or have any questions, contact me through discord.  My id is NA-45#3692. 
    • By sZokka
      Radio Rabbit
      DOWNLOAD:
      https://gamejolt.com/games/RadioRabbit/269209

      About The game
      Radio Rabbit is a local coop shoot ‘em up where two players control one more or less combined character. The character exists out of a rabbit’s body and a floating, still to the body connected, giant eye.
      Each player controls one of them.

      The rabbit’s goal is to fly safely through the level and to avoid enemies to reach the goal.  The Eye on the other hand can shoot. He is the one who clears the way. One character can move the other can shoot. So both player need to work together to fight of evil creatures and to complete the level.

      •    explore the level to find the key which activates the portal gate
      •    escape through the portal before the timer runs out
      •    if you are to slow, the nuke will explode
      •    use your character abilities, the rabbit can boost while the eye got the vision
      •    you’ll get more powerful abilities from items such as a supershot
      •    shoot as many enemies as possible to gain score
      •    remaining time at the end of each level gets added to the score
       

      Features
      •    2 Player couch coop
      •    4 level + tutorial
      •    an epic boss fight
      •    fully gamepad supported (XBox or equivalent)
      •    local high score
       
      Grab a friend and check it out!
      Please feel free to leave comments and feedback!
      DOWNLOAD:
      https://gamejolt.com/games/RadioRabbit/269209
      and ENJOY!
    • By qvertyVR
      Hello everyone! We are a small VR studio and we want to get some opinions about our new game which name is Gravity Tunnel VR. If you are interested please please visit our webside 👉 https://qverty.com/gravity-tunnel and let us know: -What do you think about it ? What we should to change? and Do you want to play this game? All opinions well see. -Second question is where we can find some small influencers who can play our game and say something about it? Do you know some people or places where we can find them and how contact them ? Do you have any experience about it? Thanks for all reply!
      Screens from our game :
       


    • By HolyByteGames
      Hey guys! Let me introduce to you a new mobile game Lumber Well. We was starting open beta. We need your feedback that helps make game better than it is.
      Sincerely, HolyByteGames Team.

      Contacts:
      holybytegames@gmail.com
      https://twitter.com/holybytegames
      https://www.instagram.com/holybytegames
    • By ilovegames
      The boy and the Golem were friends for a long time, and have traveled together.
      In search of the boy's father, they go to where he grew up, places now devastated by war.

      The player can at any time switch the characters and manage to solve a specific task.
      The boy is small and weak but is clever and an archer.
      Golem is big and strong, but slow, and prefers melees.

      The game includes the boom (required for archery) and apples (to restore his health). Golem Health is restored automatically. On the way our characters will encounter enemies and locked doors, and to open the door you must activate rock platforms nearby (decorated with blue stones that are activated by Golem from on the ground, and green that are activated from an arrow launched by the boy). Some doors will open only with simultaneous activation of a few (two or three) different types of stone platforms.

      Controls:

      Movement - W, A, S, D
      Switch character - Tab
      Direction of impact \ shot - mouse (cursor position)
      Attack:
      Golem - LMB
      Boy - When sandwiched RMB (Aim), press the LMB, for a shot
      Jump - Space



      TheBoyAndTheGolemSetup.exe
  • Popular Now