For some reason this won't compile. This isn't the first time that something hasn't worked from this book so I suspect it's a tiny typo that is messing up the whole thing. Can someone explain to me why this doesn't compile? I'm just starting to deal with strings so I don't know how to call a function from within a string.

#include <stdio.h>

main ()

{ int str_number;

for (str_number = 0; str_number < 13; str_number++)
   {
   printf ("%s", menutext(str_number));
   }
}

/*********************************************************/

char *menutext(n)
int n;

{
  static char *t[] =
   {
   "  -------------------------------------- \n",
   " |            ++ MENU ++                |\n",
   " |           ~~~~~~~~~~~~               |\n",
   " |     (1) Edit Defaults                |\n",
   " |     (2) Print Charge Sheet           |\n",
   " |     (3) Print Log Sheet              |\n",
   " |     (4) Bill Calculator              |\n",
   " |     (q) Quit                         |\n",
   " |                                      |\n",
   " |                                      |\n",
   " |     Please Enter Choice              |\n",
   " |                                      |\n",
   "  -------------------------------------- \n"
   };
return (t[n]);
}

I get an error on line 15: char *menutext(n)

C:\Documents and Settings\Gary II\Desktop\cprog.c|15|error: conflicting types for 'menutext'|

Well crap, could someone recommend a website with a c reference that is up to date? I have been using K & R (lol). What is a good website to be learning from? Also, could anyone recommend some up-to-date books on c that are really good?

Ahh ok thank you very much :D

The problem, by the way, is that menutext needs to be declared before it is used. This can be done by copying the first line of the function (up to the ;), above main, or by moving the whole function. Otherwise the default return type is int, which does not match the definition.

The K&R style parameter definition on menutext is valid C90 code, but I'm not sure if they removed it in later standards. It's not modern practice regardless. Similarly, it's good practice to write "int main()", even though int is assumed.

Thanks I plan on learning from a more modern book/ online reference from now on. I'll use "int main()" now also.

The K&R style parameter definition on menutext is valid C90 code, but I'm not sure if they removed it in later standards. It's not modern practice regardless. Similarly, it's good practice to write "int main()", even though int is assumed.

Both were removed in the C99 standard.