• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
krrice

Error when destroying bitmap images

7 posts in this topic

hey everyone, I am getting arror that I can't figure out. I am making a breakout clone and my error is when i exit the game. The error is

 

Unhandled exception at 0x56c807e5,Access violation reading location 0xfeef001a

 

  /*
         * The /GS security cookie must be initialized before any exception
         * handling targetting the current image is registered.  No function
         * using exception handling can be called in the current image until
         * after __security_init_cookie has been called.
         */
        __security_init_cookie();

        return __tmainCRTStartup();
}

 

I know it has something to do with destroying the bitmap images for my bricks because I can comment out the destroy bitmap code and no errors .

 

in main this is the code for generating the bricks:

 

for(int x = 0; x < bricksWide; x++)
        {
            Brick *brick = new Brick(brickImage, x * al_get_bitmap_width(brickImage), y * al_get_bitmap_height(brickImage), tint);
            brickObj.push_back(brick);
        }

 

and at the end of main this is the code for destroying the bitmaps:

 

for(iter = brickObj.begin(); iter != brickObj.end(); )
    {
        (*iter)->Destroy();
        delete (*iter);
        iter = brickObj.erase(iter);
    }

 

and my Destroy() function in my Brick class is:

 

void Brick::Destroy()
{
    if(image != NULL)
        al_destroy_bitmap(image);
}

 

 

0

Share this post


Link to post
Share on other sites
0xFEEEFEEE is the memory fill pattern that MSVC uses for freed memory with the debug heap. If you see an access violation in that area it generally means you've messed with memory that you've already deallocated. The first thing I'd look at is your Brick destructor.
1

Share this post


Link to post
Share on other sites

0xFEEEFEEE is the memory fill pattern that MSVC uses for freed memory with the debug heap. If you see an access violation in that area it generally means you've messed with memory that you've already deallocated. The first thing I'd look at is your Brick destructor.

 

My Brick Destructor is empty.

0

Share this post


Link to post
Share on other sites
It looks like the bricks share an image but you are destroying it for every brick. You should only destroy the brick image once.
0

Share this post


Link to post
Share on other sites

You create the pointer / dynamic memory within the first for loop and your trying to delete it outside of the scope.  Your deleting a pointer to a pointer to a dynamic memory address.  This can not be done in C++ to call delete on the original pointer that references the dynamic memory.  In other words, stop using pointers, what you are doing right now is leaking bad.

 

 

for(int x = 0; x < bricksWide; x++)
        {
            Brick *brick = new Brick(brickImage, x * al_get_bitmap_width(brickImage), y * al_get_bitmap_height(brickImage), tint);
            brickObj.push_back(brick);

            // This is the last chance you have to delete brick.
        }

 

// Brick itself is now out of scope and unreachable by code (eg access violation)

and at the end of main this is the code for destroying the bitmaps:

 

for(iter = brickObj.begin(); iter != brickObj.end(); )
    {
        (*iter)->Destroy();

        // delete iter is trying to release the dynamic memory referenced by (*iter) but (*iter) is a pointer to "brick" (which in turn points to the memory)

        // so in other words, "brick" is now in use and you can't do anything about it and "iter" effectively gets you the brick data but can not be deleted.
        delete (*iter);
        iter = brickObj.erase(iter);
    }

 

and my Destroy() function in my Brick class is:

 

void Brick::Destroy()
{
    if(image != NULL)
        al_destroy_bitmap(image);
}

0

Share this post


Link to post
Share on other sites

You create the pointer / dynamic memory within the first for loop and your trying to delete it outside of the scope. Your deleting a pointer to a pointer to a dynamic memory address. This can not be done in C++ to call delete on the original pointer that references the dynamic memory. In other words, stop using pointers, what you are doing right now is leaking bad.


for(int x = 0; x < bricksWide; x++)
{
Brick *brick = new Brick(brickImage, x * al_get_bitmap_width(brickImage), y * al_get_bitmap_height(brickImage), tint);
brickObj.push_back(brick);

// This is the last chance you have to delete brick.
}


// Brick itself is now out of scope and unreachable by code (eg access violation)

and at the end of main this is the code for destroying the bitmaps:


for(iter = brickObj.begin(); iter != brickObj.end(); )
{
(*iter)->Destroy();

// delete iter is trying to release the dynamic memory referenced by (*iter) but (*iter) is a pointer to "brick" (which in turn points to the memory)

// so in other words, "brick" is now in use and you can't do anything about it and "iter" effectively gets you the brick data but can not be deleted.
delete (*iter);
iter = brickObj.erase(iter);
}


and my Destroy() function in my Brick class is:


void Brick::Destroy()
{
if(image != NULL)
al_destroy_bitmap(image);
}


That entire post makes no sense. But to the OP, consider using smart pointers in the container, it's safer.
0

Share this post


Link to post
Share on other sites

It looks like the bricks share an image but you are destroying it for every brick. You should only destroy the brick image once.

 

Thanks , it makes sense now. So at the end of main I need to delete the image like:

 

    delete paddle;
    delete ball;
    al_destroy_bitmap(brickImage);
    //SHELL OBJECTS=================================
    al_destroy_font(font18);
    al_destroy_timer(timer);
    al_destroy_event_queue(event_queue);
    al_destroy_display(display);

    return 0;
}

 

But don' I need to do something in the class for the bitmap pointers I create for each brick;

 

Brick::Brick(ALLEGRO_BITMAP *image,int x,int y, ALLEGRO_COLOR tint)
{
    width = al_get_bitmap_width(image);
    height = al_get_bitmap_height(image);
    this->image = image;
    this->x = x;
    this->y = y;
    this->tint = tint;
    alive = true;
}

0

Share this post


Link to post
Share on other sites
No, they are just pointers to the image; they don't own it and don't need to be freed.

The only thing you have to be sure to do is not use them again after the image has been freed.
1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0