• Advertisement
Sign in to follow this  

Unity How To Copy Array of Derived Classes Without Pointers

This topic is 1793 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hello Everyone,

 

I have a problem I am currently facing and I'm wondering if the community could help me out.  I find it's probably easier to explain with an example.

struct Base
{
};

struct Derived : public Base
{
    Derived(float newX) : x(newX)
    {
    }
    
    float x;
};

struct Unrelated : public Base
{
    Unrelated(char val) : v(val)
    {
    }
    
    char v;
}
...
 
// How to copy the data that's in mBaseArray into another struct?
// Don't want pointer copy as it's not thread safe.
 
// Below is a very simple example.
 
Module1
-----------
class Module1
{
...
    Array<Base*> mBaseArray;
}; 

 

- mBaseArray is populate in some fashion.  Notice the use of polymorphism here.
 
mBaseArray.push_back(new Derived(10));
mBaseArray.push_back(new Unrelated('c'));  
 
... Some sync point here
... After this point, I want to copy the information that is in mBaseArray into Module2's mWorkingArray.
 
Module2
-----------
class Module2
{
...
    Array<Base*> mWorkingArray;
};

 

- Want to copy the data from mBaseArray into Module2's own array.
- Copied data from mBaseArray without the use of pointers.  Want only data.
- Module2 contains a similar declaration to mBaseArray.
 
Is there a way to accomplish this?  Or is there some other method that will solve this problem?
 
If there are better ways of doing what I'm trying to accomplish, I am more than welcome to suggestions.
 
Thanks.

Share this post


Link to post
Share on other sites
Advertisement

If you really need to keep the polymorphism, one option is to add a virtual Clone method to the Base class. Then it will be the responsibility of each subclass to implement this Clone method by creating a new instance of its type and initializing it accordingly. You can then Clone the objects into the new array.

 

Otherwise, revisit whether you actually need polymorphism.

Share this post


Link to post
Share on other sites

Thanks for the suggestion.  I think you were right and I was thinking about stuff in all the wrong way.  I have since moved away from polymorphism in favour of a better approach.  I think I can achieve what I want through proper message passing instead of the convoluted way I was previously using.

Share this post


Link to post
Share on other sites
class Module1
{
...
    Array<Derived> mDerivedArray;
    Array<Unrelated> mUnrelatedArray;
};
mDerivedArray.push_back(Derived(10));
mUnrelatedArray.push_back(Unrelated('c'));
class Module2
{
    Module2(Array<Derived>& d,Array<Unrelated>& u) :
        mDerivedArray(d),
        mUnrelatedArray(u) {}
    Array<Derived>& mDerivedArray;
    Array<Unrelated>& mUnrelatedArray;
};

How about doing it this way? Would be much more efficient and if you dont add a huge class hierarchy it wouldnt hurt.

You can just treat both arrays the same for some types of work if you like. It may be even easier to process the data if you dont throw away the knowledge of the exact type without being forced to and have similar things sorted together for some other types of work.

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By 3dmodelerguy
      So I am building a turn based rogue-like (think CDDA). The game is going to have a very large map (up to 1000's x 1000's) however to alleviate most of that I obviously can't render everything so there will just be render a certain radius around the player and just load in and out data as the player moves.
      The next major system I am prototyping is making interactive tiles destructible and pretty much everything will be destructible besides basic landscape (cars, doors, windows, structures, etc. will be destructible)
      While I am only rendering a certain amount of tiles around the player, I want to keep the amount of colliders active at one time to be as small as possible for performance and currently the tilemap tool I use automatically merges colliders together.
      So instead of creating a separate colliders for each of these tiles and having the destructible behavior tied to that object (which my tilemap tool would allow me to do) I was thinking that I would store an array of all the X and Y locations for the interactive tilemap layer and let the tilemap manage the colliders. 
      Then when I hit a collider on the interactive tilemap layer, instead of of getting the behavior for how to deal with the destruction for that tile from that game object, I would pull it from the array I mentioned earlier based on the tile I attempt to interact with which I already have.
      Does this sound like a good approach? Any other recommendations would be welcomed.
    • By NDraskovic
      Hey guys,
      I have a really weird problem. I'm trying to get some data from a REST service. I'm using the following code:
       
      private void GetTheScores() { UnityWebRequest GetCommand = UnityWebRequest.Get(url); UnityWebRequestAsyncOperation operation = GetCommand.SendWebRequest(); if (!operation.webRequest.isNetworkError) { ResultsContainer rez = JsonUtility.FromJson<ResultsContainer>(operation.webRequest.downloadHandler.text); Debug.Log("Text: " + operation.webRequest.downloadHandler.text); } } The problem is that when I'm in Unity's editor, the request doesn't return anything (operation.webRequest.downloadHandler.text is empty, the Debug.Log command just prints "Text: "), but when I enter the debug mode and insert a breakpoint on that line, then it returns the text properly. Does anyone have an idea why is this happening?
      The real problem I'm trying to solve is that when I receive the text, I can't get the data from the JSON. The markup is really simple:
      [{"id":1,"name":"Player1"},{"id":2,"name":"Player2"}] and I have an object that should accept that data:
      [System.Serializable] public class ResultScript { public int id; public string name; } There is also a class that should accept the array of these objects (which the JSON is returning):
      [System.Serializable] public class ResultsContainer { public ResultScript[] results; } But when I run the code (in the debug mode, to get any result) I get an error: ArgumentException: JSON must represent an object type. I've googled it but none of the proposed solutions work for me.
      Also (regardless if I'm in the debug mode or not) when I try to do some string operations like removing or adding characters to the GET result, the functions return an empty string as a result
      Can you help me with any of these problems?
      Thank you
    • By nihitori
      The Emotional Music Vol. I pack focuses on beautiful and esoteric orchestral music, capable of creating truly emotive and intimate moods. It features detailed chamber strings, cello and piano as the main instruments, resulting in a subtle and elegant sound never before heard in video game royalty-free music assets.

      The pack includes 5 original tracks, as well as a total of 47 loops based on these tracks (long loops for simple use and short loops for custom / complex music layering).

      Unity Asset Store link: https://www.assetstore.unity3d.com/en/#!/content/107032
      Unreal Engine Marketplace link: https://www.unrealengine.com/marketplace/emotional-music-vol-i

      A 15 seconds preview of each main track is available on Soundcloud:
       
    • By RoKabium Games
      Another one of our new UI for #screenshotsaturday. This is the inventory screen for showing what animal fossils you have collected so far. #gamedev #indiedev #sama
    • By eldwin11929
      We're looking for programmers for our project.
      Our project is being made in Unity
      Requirements:
      -Skills in Unity
      -C#
      -Javascript
      -Node.js
      We're looking for programmers who can perform a variety of functions on our project.
      Project is a top-down hack-and-slash pvp dungeon-crawler like game. Game is entirely multiplayer based, using randomized dungeons, and a unique combat system with emphasis on gameplay.
      We have a GDD to work off of, and a Lead Programmer you would work under.
      Assignments may include:
      -Creating new scripts of varying degrees specific to the project (mostly server-side, but sometimes client-side)
      -Assembling already created monsters/characters with existing or non-existing code.
      -Creating VFX
      -Assembling already created environment models
      If interested, please contact: eldwin11929@yahoo.com
      This project is unpaid, but with royalties.
       
      ---
      Additional Project Info:
      Summary:
      Bassetune Reapers is a Player-verus-Player, competitive dungeon crawler. This basically takes on aspects of dungeon crawling, but with a more aggressive setting. Players will have the option to play as the "dungeon-crawlers" (called the 'Knights', or "Knight Class", in-game) or as the "dungeon" itself (literally called the 'Bosses', or "Boss Class", in-game). What this means is that players can choose to play as the people invading the dungeon, or as the dungeon-holders themselves.
      Key Features:
      -Intense, fast-paced combat
      -Multiple skills, weapons, and ways to play the game
      -Tons of different Bosses, Minibosses, creatures and traps to utilize throughout the dungeon
      -Multiple unique environments
      -Interesting, detailed lore behind both the game and world
      -Intricate RPG system
      -Ladder and ranking system
      -Lots of customization for both classes s of customization for both classes
  • Advertisement