Sign in to follow this  
SiddharthBhat

CScriptAny leaking?

Recommended Posts

I've been writing a generalized voidPtr class for angelScript, because in many cases,I won't know the type of the object I'm sending, hence I'll have to cast the object based on what the other person decides to retrieve. So, I've been looking though cScriptAny.

 

 cScriptAny's Store() function does this:

 

 

 

else if( value.typeId & asTYPEID_MASK_OBJECT )
    {
        // Create a copy of the object
        value.valueObj = engine->CreateScriptObjectCopy(ref, value.typeId);
    }
 

 

Now, in retrieve, it does this:

 

 

 

else if( refTypeId & asTYPEID_MASK_OBJECT )
    {
        // Is the object type compatible with the stored value?


        // Copy the object into the given reference
        if( value.typeId == refTypeId )
        {
            engine->AssignScriptObject(ref, value.valueObj, value.typeId);


            return true;
        }
    }
 

 

 

So, isn't cScriptAny leaking the middleman object that was created within the cScriptAny class by calling CreateScriptObjectCopy?

Why is the class not freeing that copy? shouldn't there be a call to ReleaseScriptObject after calling AssignScriptObject?

 

I'm quite sure I'm missing something, but I'm not sure what :D

 

Thanks!

~Bollu

Share this post


Link to post
Share on other sites

On storing of an object, CScriptAny will hold the copy of that object. On retrieval, the copy is assigned to the argument passed by reference (which involves making another copy), and CScriptAny still holds the first copy. No freeing should happen at that point.

 

The copy of the object held by CScriptAny is freed when either another object is stored in it, or when CScriptAny is destroyed.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this