Sign in to follow this  

Monday morning code...

This topic is 1682 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Monday morning code is this kind of code, where you write some seemingly easy code in hour just before first coffee and your co-workers need at least the rest of the week to figure out what went wrong. You would deny this code until you see the blame in svn, after that you start to believe in global conspirators.

 

Here's some java code I tracked down which caused some ugly bug ph34r.png

 

// determine objects to copy
MyClass sourceObj = getSourceObject();
MyClass destObj = getDestinationObject();

// copy now
destObj = sourceObj;

 

Share this post


Link to post
Share on other sites

Pass pointers by value for the win......?

 

Monday mornings should be referred to as the "Hours of the n00bpocalypse"

Edited by Alpha_ProgDes

Share this post


Link to post
Share on other sites

it's saturday morning, this code doesn't cause a crash, but is just an stupid oversight i caught myself doing:

 

 

Tile *World::GetTile(unsigned int x, unsigned int y){ //Same as above, but we can specify x/y coordinates instead of index positions.
    if(x<0 || x>=m_Width ) return nullptr;  //We check that the x-axis is inside the world.
    if(x<0 || y>=m_Height) return nullptr; //We check that the y-axis is inside the world.
    return m_Tiles+(x+y*m_Width);
}

 

completly idiotic on my part, unsigned numbers are never less than zero;-)

Edited by slicer4ever

Share this post


Link to post
Share on other sites

If this was C++ there would be some chance of success due to operator overload, but... tongue.png

Share this post


Link to post
Share on other sites

I usually avoid writing any code monday morning, think about stuff, do some testing, identify issues and think of solutions... only start coding after lunch

Share this post


Link to post
Share on other sites

I once made this "beauty" at work...

 

// Write
bool result = insert(results, data);

if ( m_CurrentSet )
{
       result = result || insert(*m_CurrentSet, data);
}
 

The idea was to store the latest of anything that has been written to file in memory, to make sure the latest set of data was in memory. However, this being a real time application, which in theory should run forever (and generates data for a multi-million dollar service), the results were pretty poor.

 

No harm done, since this was in a test and not production.

Share this post


Link to post
Share on other sites

I ALWAYS end up making two comparisons on X or using X value for both X and Y on something, hahahaha, eventually have some reeeeallly weird behavior and track it to that, lmao

Share this post


Link to post
Share on other sites

One can never be sure enough! tongue.png

 

Also check if nullptr is actually null.

nullptr is a C++11 keyword that is guaranteed to be null.

Share this post


Link to post
Share on other sites

Here's some recent Monday-morning like code

 

 

if (ddl.SelectedValue == "Ticket")
   LoadPassengerList(currentTrainNumber.Text);
   PassengerPanel.Visible = false;
 

 

 

 

See what I did there......?

Share this post


Link to post
Share on other sites

See what I did there......?

 

Judging from your formatting, I'd say you forgot to put parenthesis after the if, so that the third line was executed regardless of the selected value? If so, it would be interesting what the results of this was biggrin.png

Edited by Juliean

Share this post


Link to post
Share on other sites

One can never be sure enough! tongue.png

 

Also check if nullptr is actually null.

nullptr is a C++11 keyword that is guaranteed to be null.

That was the point of my comment mellow.png Comparing if unsigned values are negative... checking if nullptr is null... rings a bell?

Share this post


Link to post
Share on other sites

Here's some recent Monday-morning like code

 

 

if (ddl.SelectedValue == "Ticket")
   LoadPassengerList(currentTrainNumber.Text);
   PassengerPanel.Visible = false;
 

 

 

 

See what I did there......?

laugh.png Classic. "Hey, I just need to add one more thing in this if case... *copy, paste, compile*, no error, I'm such a good programmer! *moves on*"

 

2 weeks later, someone else: "Why is this stupid thing vanishing all the time? angry.png "

Share this post


Link to post
Share on other sites
Sign in to follow this