Sign in to follow this  
jelani435

C++ help

Recommended Posts

jelani435    102

Hey guys i'm 14 and i'm just starting to learn c++. I have an rpg intro i'm working on but it wont compile or run. would any of you be able to point out any issues?:

________________________________________________________________________________________________________________

 

#include <iostream>
#include <cstring>
 
using namespace std;
 
int main()
{
char name[50];
char weapon[100];
char weapon_name[100];
cout<<"What do you want your hero's name to be?";
cin.getline (name, 50);
cout<<"I like that name!";
cout<<"What would you like your weapon to be?";
cin.getline (weapon, 100);
cout<<"That's my favourite weapon!";
cout<<"What would you like to name your weapon?";
cin.getline (weapon_name, 100);
cout<<"cool!";
cout<<"You shall be crowned: "<<name<<"the wielder of the"<<weapon<<"named"<<weapon_name";
cout<<"You may begin your adventure!\n";
cin.get();
}
 
 
 
Thanks for your help!

Share this post


Link to post
Share on other sites

Compile/link errors, we need them? Also what compiler you are using might be handy ;)

 

Just a guess... you aren't building a console application or you have a unicode console build (replace main with wmain then).

Share this post


Link to post
Share on other sites
jelani435    102

I am using code::blocks compiler.

 

The error is:

Checking for existence: C:\Users\user\Desktop\Rpg intro.exe

Executing: C:\Program Files (x86)\CodeBlocks/cb_console_runner.exe "C:\Users\user\Desktop\Rpg intro.exe" (in C:\Users\user\Desktop)
Process terminated with status 1972040841 (0 minutes, 33 seconds)
 
And im still doing tutorials and all that so i decided to try my hand at my own sample program. I really have no idea what these errors mean lol!

Share this post


Link to post
Share on other sites

Looks like it built, since it ran.

 

33 seconds execution time... did you wait 33 seconds before pressing enter several times? None of the text will probably be printed to the console since you don't flush the output (using cout << endl) perhaps? Put that after you write each line to cout, see if that works.

 

Looks like you are returning from main with a non-zero value... which sounds like a bug in code::blocks since if you don't return a value from main it should implicitly return 0.

Share this post


Link to post
Share on other sites

Just try 

 

cout<<"What do you want your hero's name to be?" << endl;

 

etc.

 

I think using "\n" doesn't flush the output stream. Using endl definitely does. You don't need std:: before endl since you already had

 

using namespace std;

Edited by Paradigm Shifter

Share this post


Link to post
Share on other sites
Cornstalks    7030

Also for the last two couts should i use \n on that or samething?

Meh, it's up to you. Whether you use \n or std::endl, both will print out a new line. The only difference between \n and std::endl is that \n will not flush the buffer, but std::endl will flush the buffer. For little programs like these, it make almost zero difference what you choose. For large scale applications that print out a lot of information, they may prefer using \n because constantly flushing the buffer can slow things down a good amount.

 

I'm going to guess you aren't quite sure what "flushing the buffer" means, though. When you perform input/output operations, like you're doing here, things are commonly buffered. That is, there's some memory that let's things "build up" before finally dumping them out, kind of like a temporary damn. Let me walk you through it:

 

std::cout << "Hello world!\n";

"Hello world!\n" is only a few characters (13 to be exact). It can be more efficient if, instead of instantly dumping those 13 characters out to the console, you put those 13 characters in a memory buffer, temporarily storing them until you get more data. Once this memory buffer is full (i.e. you try printing out more data and eventually the memory buffer is full), it dumps all of the stored characters out to the console in one go. If you use std::endl instead of \n, it will force the buffer to dump out its data, meaning it won't wait until it's full.

 

Like I said, for small applications, this isn't something you should really worry about. But if you've got a large application that outputs a lot of data, you might want to not use std::endl so you can let things build up in the buffer (dumping 1000 characters to the console in one go is more efficient than dumping 10 characters to the console 100 times).

 

 

 

Also, I know you're learning, but I hope you're learning that you should pretty much never be getting input into raw char arrays like that. It's okay for a learning exercise, but don't let it become something that you think is the "right way." There are things like std::string and std::getline, which should be your best friends (someday).

 

Oh yeah. This site has [ code ][ /code ] (use them without spaces) tags that you can put your code in to get nice, pretty formatting :)

Edited by Cornstalks

Share this post


Link to post
Share on other sites
jellyfishchris    300

This line...

 

 

cout<<"You shall be crowned: "<<name<<"the wielder of 
the"<<weapon<<"named"<<weapon_name";
 

Lets zoom in to the problem

 

 

weapon_name";
 

You have an additional "

 

Your complier seems to not be working I used the following:

http://ideone.com/L2j2hL

And it showed me straight away.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this