• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Conoktra

Template specialization and class references

9 posts in this topic

Consider the following:

 

class Vector3 {
public:
	f64 x, y, z;
};

// pass an unkown userdata type to lua
template<typename T> inline void luaPushArg(lua_State * const LuaState, T arg) {
	tolua_pushusertype(LuaState, (void*)&arg, typeid(T).name() + 6);
}

void testFunction(const Vector3 &v) {
	luaPushArg(LuaState, v);
	luaCallFunction("TestFunction"); // CRASH (only sometimes though!)
	luaPop();
}

 

 

What went wrong here?  Can you spot the bug?  This one was a real pain in the tush.  luaPushArg() would work with all my specialized types (int, float, etc) that I was passing to Lua, but when I passed classes it would sometimes crash.  Turns out that luaPushArg() is taking a T arg instead of a T &arg.  This means that a new copy of 'v' is created inside testFunction() when it calls luaPushArg().  luaPushArg() then pushes the newly created object onto the Lua stack.  Upon luaPushArg()'s return, the pointer too the class object that was just pushed onto the lua stack is now invalidated.  Sometimes it would crash, sometimes it wouldn't.  This one was a real nightmare.

 

 

Hehehe biggrin.png.  I can't wait for C11 support in GCC, that way bugs like this can be avoided using type-generic expression macros.

Edited by Conoktra
0

Share this post


Link to post
Share on other sites

typeid(T).name() + 6
W.


T.


F.

I was assuming that it was to skip past name mangling output, but holy crap is that non-portable, and would cause serious problems if you have two classes with the same name.

0

Share this post


Link to post
Share on other sites

typeid(T).name() + 6
W.


T.


F.

 

tolua++ needs to know the class's typename or else its treated as a void* inside lua.  The "typeid(T).name + 6" skips the "class " prefix and only passes the classes unique type name ("class MyClass" -> "MyClass") which is what tolua++ expects.  luaPushArg() has specialized template instances for all non-class types (thus avoiding the issue of instantiating the template with, say, an int).  That way I can pass any class to lua without having to define a specialized instance of luaPushArg() for each class type.  With hundreds of classes exported to lua, this saves a lot of time and code.

 

 

holy crap is that non-portable

Portability isn't an issue.  If it was fixing it would be a matter of a couple of #ifdefs.  Whoopdeedoo.

 

 

would cause serious problems if you have two classes with the same name.

Its not possible to have two classes with the same typename.  Period. Try to compile this:

 

class A { };
class A { }; // error C2011: 'A' : 'class' type redefinition
Edited by Conoktra
0

Share this post


Link to post
Share on other sites


would cause serious problems if you have two classes with the same name.

Its not possible to have two classes with the same typename.  Period. Try to compile this:
class A { };
class A { }; // error C2011: 'A' : 'class' type redefinition


That assumes that you are actively preventing/renaming nested classes?
#include <iostream>

struct Foo {
	class A {};
};

struct Bar {
	class A {};
};

int main()
{
    std::cout << typeid(Foo::A).name() << std::endl;
    std::cout << typeid(Bar::A).name() << std::endl;
}
Although my platform (clang on Mac) seems to provide fully mangled names:
tristam$ ./a.out 
N3Foo1AE
N3Bar1AE
0

Share this post


Link to post
Share on other sites

not sure about the typeid resulting from that, but:

namespace {
class A {};
}
class A {};


Just because it is anonymous, doesn't mean it isn't named under the hood (and, in fact, it pretty much has to be for name resolution):
tristamm$ ./a.out 
N12_GLOBAL__N_11AE
1A
0

Share this post


Link to post
Share on other sites

The point was more that its not impossible to compile classes with same name.smile.png

Sure, but he specified "same typename", which is a different story.
0

Share this post


Link to post
Share on other sites

The point was more that its not impossible to compile classes with same name.smile.png

Even the most sound code can be broken when you throw scenarios at it that are specifically designed to break it.  My compiler doesn't mangle the class names nor do I use namespaces, hence neither is an issue.

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0