• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
polyfrag

Android native libpng problems

10 posts in this topic

I load a png okay, then it complains on this line:

 

 

  int is_png = !png_sig_cmp(header, 0, 8);
  if (!is_png) 
  {
    LOGE("Not a png file : %s", strFileName);
    return NULL;
  }

 

And the next one causes a crash.

 

03-27 17:34:01.060: A/libc(21835): @@@ ABORTING: LIBC: ARGUMENT IS INVALID HEAP ADDRESS IN dlfree addr=0x5b050000

03-27 17:34:01.060: A/libc(21835): Fatal signal 11 (SIGSEGV) at 0xdeadbaad (code=1), thread 21849 (engame.pathogen)

 

Any ideas why?

0

Share this post


Link to post
Share on other sites

Which of all those lines? If it's the first, check that header points to valid memory. If it's the fourth, check strFileName instead. Also in the case of header make sure it's long enough (should be 8 bytes).

 

Sounds dumb but you may have overlooked something.

Edited by Sik_the_hedgehog
0

Share this post


Link to post
Share on other sites
I mean I load one png file okay (it seems, I haven't tried viewing it) but then for the second one png_sig_cmp returns non-zero. And yeah it is 8 png_byte's.
0

Share this post


Link to post
Share on other sites

The second one is now complaining about setjmp:

 

03-27 22:01:01.320: E/NDK_MainActivity(23871): Error during setjmp : fonts/msgothic16b.png

 

  if (setjmp(png_jmpbuf(png_ptr))) 
  {
    LOGE("Error during setjmp : %s", strFileName);
    png_destroy_read_struct(&png_ptr, &info_ptr, &end_info);
    return NULL;
  }
Edited by polyfrag
0

Share this post


Link to post
Share on other sites

I changed the order of the first two files and still got the same result. I savemsgothic16b.png in MS Paint, which got rid of the transparency. It was the first one loading and it loaded fine, but now it was complaining about the header in what was the first file. So changing the data of one file somehow messed up the data of the second. It's either the way I'm reading the file into memory, how it's stored in the APK, or something wrong with the asset manager. 

 

I now switched the first and second one to their original order and it still has an invalid header but it changed. And it's crashing on the second one instead of loading it.

Edited by polyfrag
0

Share this post


Link to post
Share on other sites

If I got the asset manager this way

	g_amgr = state->activity->assetManager;

 

then it shouldn't change during the course of the program?

0

Share this post


Link to post
Share on other sites

Here's how I load files into memory from the APK:

CFile::CFile(const char* filepath)
{
	data = NULL;
	fsize = 0;
	position = 0;

	//zip_file* file = zip_fopen(APKArchive, filepath, 0);
	AAsset* asset_file = AAssetManager_open(g_amgr, filepath, AASSET_MODE_UNKNOWN); 

	//if(!file)
	if(!asset_file)
		return;

	unsigned char buff[256];
	unsigned char* oldbuf = NULL;
	unsigned char* newbuf = NULL;

	int r=0;
	//while((r=zip_fread(file, buff, 256)) > 0)
	while((r = AAsset_read(asset_file, buff, 256)) > 0)
	{
		newbuf = new unsigned char[fsize+r];

		if(oldbuf)
		{
			memcpy(newbuf, oldbuf, fsize);
		}

		memcpy(&newbuf[fsize], buff, r);

		delete [] oldbuf;
		oldbuf = newbuf;

		fsize += r;
	}

	data = newbuf;

	//zip_fclose(file);
	AAsset_close(asset_file);
}

void CFile::seek(int off)
{
	position = off;
}

int CFile::read(void* to, int amt)
{
	int read = amt;

	if(read > fsize-position)
		read = fsize-position;

	memcpy(to, &data[position], read);
	position += read;

	return read;
}
class CFile
{
public:
	unsigned char* data;
	int fsize;
	int position;

	CFile();
	CFile(const char* filepath);
	~CFile();
	void seek(int off);
	void seekend();
	int read(void* to, int amt);
	int tell();
	void close();
};

 

 

Is there anything wrong with this?

Edited by polyfrag
0

Share this post


Link to post
Share on other sites

There's a problem in here somewhere because it does show all chunks (I checked) of the file but at the end it shows only part of it.

 

Somewhere in the data copying... file size is alright.

	data = NULL;
	fsize = 0;
	position = 0;

	//zip_file* file = zip_fopen(APKArchive, filepath, 0);
	AAsset* asset_file = AAssetManager_open(g_amgr, filepath, AASSET_MODE_UNKNOWN); 

	//if(!file)
	if(!asset_file)
		return;

	unsigned char buff[257];
	unsigned char* oldbuf = NULL;
	unsigned char* newbuf = NULL;

	int r=0;
	//while((r=zip_fread(file, buff, 256)) > 0)
	while((r = AAsset_read(asset_file, buff, 256)) > 0)
	{
		newbuf = new unsigned char[fsize+r];

		//buff[r] = '\0';
		//LOGI("%s", buff);

		LOG("read %d", r);

		//if(oldbuf)
		if(fsize > 0)
		{
			memcpy(newbuf, oldbuf, fsize);
		}

		memcpy(&newbuf[fsize], buff, r);

		//if(oldbuf)
		if(fsize > 0)
		{
			delete [] oldbuf;
		}
		oldbuf = newbuf;

		fsize += r;
	}

	//LOGI("%s size=%d", filepath, fsize);
	data = newbuf;

	//char show[fsize];
	//memcpy(show, data, fsize);
	//LOGI("%s", show);
Edited by polyfrag
0

Share this post


Link to post
Share on other sites

I'm using AAsset_getLength, AAsset_seek and AAsset_getRemainingLength to read the whole file directly.

 

http://minigamestudio.googlecode.com/svn-history/r407/trunk/source/render/android/ola_afile.cpp

 

It was only showing ~1000 characters because that was the logcat limit.

 

PNG now says:

 

03-28 00:53:21.293: A/libc(26952): Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1), thread 26967 (engame.pathogen)

Edited by polyfrag
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0