I'm calling

IDXGIOutput* output;
adapter->EnumOutputs(0, &output);
DXGIOutput outputInterface = DXGIOutput(output);
 

adapter is a DXGIAdapter* that I create with EnumAdapters1 from the factory object, it gives me no problems, I get the description and it properly gives me the GPU name when I take its DXGI_ADAPTER_DESC1.
DXGIOutput is just a thin wrapper that contains an IDXGIOutput* and has a SafeRelease(obj) macro used in it's destructor to release the contained IDXGIOutput*.This is the macro:
#define SafeRelease(obj) {if(obj){(obj)->Release();(obj)=nullptr;}}It's just the standart SafeRelease used across most tutorials, but It kept telling me this when SafeRelease was called:

Unhandled exception at 0x00150138 in Rendering.exe: 0xC0000005: Access violation executing location 0x00150138.

since I was only using DXGIOutput outputInterface temporarily, once it got killed at the end of the function and it's destructor got called.

So I change it to:
#define SafeRelease(obj) {if(obj){(obj)->Release();}}
And now it stopped giving me the error.However, on the call stack it says:

<Unknown function> Unknown

[Frames below may be incorrect and/or missing]

Yes, I use the updated ones everywhere, however I don't understand this:

/ Create a factory to enumerate all of the hardware in the system.

IDXGIFactory1* pFactory = 0;
hr = CreateDXGIFactory1( __uuidof(IDXGIFactory), (void**)(&pFactory) );

Shouldn't it be IDXGIFactory1? I'm using IDXGIFactory1, maybe that's the issue?
It also worries me that the SafeRelease macro causes a crash, even if I use 0 instead of nullptr, could be a hint at the problem.

on a side note - I just now notice GameDev has colors for DirectX in the code tags lol

ok I expanded it and same thing happens, it crashes on Release(), but when I remove the line afterwards that sets it to 0/NULL the other error appears.There's

<Unknown function>

Unknown
at the top of the call stack, so I guess there's something wrong in the COM?I don't think I initialized it wrong tho, just used EnumOutputs, I check the HRESULT and it's ok

edit: I tried to use IDXGIOutput1 too instead of IDXGIOutput, but I EnumOutputs() doesn't take IDXGIOutput1 as an argument, it wants an IDXGIOutput, or is IDXGIOutput1 a special case and used in a different way?

I check breakpoint by breakpoint the pointer addresses, all of the IDXGI objects seem to be getting created with valid addresses(they're not 0x00000000 or anything similar)

Ok I fixed it, DXGIOutput outputInterface = DXGIOutput(output); should have been DXGIOutput* outputInterface = new DXGIOutput(output); otherwise it gets destroyed in the end of the frame and then I do adapterOutputs.Add(&outputInterface); I was adding a pointer to an already destroyed object (facepalm).