• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
BaneTrapper

Structured code incorrectly? References are bad choice in provided case? Help find solution. Fixed

5 posts in this topic

Hello.

I don't even know how to explain this, so here i will try to ask in code.

 

//I have a class that is like this
class WorkerClass
{

public:
std::vector<Unit> &unit1;
std::vector<Unit> &unit2;
void DoStuff();
void SetUnits(std::vector<Unit> &unit1, std::vector<Unit> &unit2);
};
void WorkerClass::DoStuff()
{
//Change data around in unit1
//Change data around in unit2
}

In my case i got a function "DoStuff()" That dosen't want to care about anything except what is unit1 and unit2.

Problem is that unit1 and unit2 constantly change and they are accessed from:

 

class Unit
{

public:
//Stuff for unit

};
 
class UnitGroup

{

public:

std::vector<Unit> UnitList;

};
 
//This is what i will have
std::vector<UnitGroup> UnitGroupList;
std::vector<Unit> UnitList;
 
//What i will need to do is
WorkerClass::SetUnits( UnitGroupList[Collided_Unit_Group].UnitList[Some_Unit], UnitList[Some_Unit] );
WorkerClass::DoStuff();
 
//Now UnitGroupList.clear() is called that will clear all data from it.
//Then its populated with unknown amount of units groups, and those unit groups are populated with unknown amount of units
//Then i redo need to call WorkerClass::DoStuff() on new set units
 
WorkerClass::SetUnits( UnitGroupList[Different_Unit_Group].UnitList[Different_Unit], UnitList[Different_Unit] );
WorkerClass::DoStuff();
// ... repeat

Now the problem is the reference will point to old and new unit and produce  poop.

Is using a pointer in this case valid? i mean i am pointing to a vector holding a vector and changing its data is that valid? wont i get access violation?

 

And if so, what should i do? i am out of ideas...

 

EDIT:: A huge error in "SetUnits" i don't want to set a single unit i want to set the std::vector of units

Edited by BaneTrapper
1

Share this post


Link to post
Share on other sites

First, this:

 

std::vector<Unit> &unit1;
std::vector<Unit> &unit2;
 

 

 

should be this:

 

 

std::vector<Unit> unit1;
std::vector<Unit> unit2;
 

 

 

Second, why is SetUnits taking Unit1 and Unit2 as references and DoStuff has no parameters? They access the Units the same way. Shouldn't it be this?

 

 

void DoStuff(Unit &unit1, Unit &unit2);
void SetUnits(Unit &unit1, Unit &unit2); 
 
0

Share this post


Link to post
Share on other sites

I think, that the goal is to have a utility/worker class which accepts two external units which will be proceed later (actually it is quite hard to guess what is the goal of this code smile.png ). Maybe something like this:

//I have a class that is like this
class WorkerClass
{

private:
Unit *unit1;
Unit *unit2;

public:

void DoStuff();
void SetUnits(Unit &unit1, Unit &unit2);
};
void WorkerClass::SetUnits(Unit &pUnit1, Unit &pUnit2)
{
unit1 = &pUnit1;
unit2 = &pUnit2;
}

void WorkerClass::DoStuff()
{
//Change data around in unit1
//Change data around in unit2
}

The set method enforces real objects as parameter (NULL is not allowed), yet the workerclass works internally on pointers only.

Edited by Ashaman73
2

Share this post


Link to post
Share on other sites

First, this:

std::vector<Unit> &unit1;
std::vector<Unit> &unit2;

should be this:

std::vector<Unit> unit1;
std::vector<Unit> unit2;

This would make me at the end force me to do UnitGroupList[Some....].EnemyList[Some...] = unit1, same for other one.

Why do that, when i can and should directly access them.

 

Second, why is SetUnits taking Unit1 and Unit2 as references and DoStuff has no parameters? They access the Units the same way. Shouldn't it be this?

void DoStuff(Unit &unit1, Unit &unit2);
void SetUnits(Unit &unit1, Unit &unit2); 
 

First of all, the DoStuff() is in span off 5-400 seconds, and because it requires huge(many) amount of stuff, i prefer performance over storage(I understand i am saving on wrong part. That being said, i am exploring more ways on doing things and seeing how they shift structure of code...).

 

I don't want to pass everything needed, witch each function call, but instead have initalization that will set all its attributes it requires and then let it do whats its meant to do.

Also WorkerClass::SetUnits(std::vector<Unit> &unit1, std::vector<Unit> &unit2); is just getter/setter. with is used to initialize the class before running it.

Edited by BaneTrapper
0

Share this post


Link to post
Share on other sites

private:
Unit *unit1;
Unit *unit2;

void WorkerClass::SetUnits(Unit &pUnit1, Unit &pUnit2)
{
unit1 = &pUnit1;
unit2 = &pUnit2;
}

Dosen't &pUnit2; in your WorkerClass::SetUnits function return memory address of the reference?

Or does asking for memory address of reference give memory address of the object its pointing to?

 

Holy **** i didn't know that asking memory address of reference gives the object its pointing to address.

Thanks that would provide me enough stuff to work with!

 

EDIT::

void WorkerClass::SetUnits(Unit &pUnit1, Unit &pUnit2) sould be

void WorkerClass::SetUnits(std::vector<Unit> &pUnit1, std::vector<Unit> &pUnit2)

sorry for the error

 

EDIT2::
That would be it thanks. Fixed with

void WorkerClass::SetUnits(Unit &pUnit1, Unit &pUnit2)
{
unit1 = &pUnit1;
unit2 = &pUnit2;
}

Written a test program this works!

I had no idea that this would work... thanks much!

Edited by BaneTrapper
0

Share this post


Link to post
Share on other sites

class WorkerClass
{
public:

WorkerClass(std::vector<Unit>& unit1, std::vector<Unit>& unit2) 
   : m_unit1(unit1), m_unit2(unit2) {}

void DoStuff();
 
private:
  std::vector<Unit>& m_unit1;
  std::vector<Unit>& m_unit2;
};

 

With references you can't re-assign after construction, so you'd have to construct a new worker class each time. If reassignment is needed, then pointers are the only option.

1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0