Sign in to follow this  
tom_mai78101

OpenGL I am no longer able to load a cube mesh correctly. How do I fix this problem?

Recommended Posts

Wall of text below:

 

I'm having trouble loading up a correct cube mesh using OpenGL ES 2.0 on an Android device running ICS.

 

From what I observed, I see that the vertices of the cube is not only distorted, but also some of the vertices have incorrect vertex positions in the world matrix. You can tell by looking at some of the snapshots taken below:

 

vCO2fbl.pngWdD7AcX.pngW8MaGV9.png

 

 

 

 

 

I have checked and confirmed that my OBJ file parser is not causing any troubles, by comparing the values copied into the buffer objects to the values in the OBJ file itself. I have used the software, Blender, to re-create the cube mesh by exporting and overwriting the OBJ files. I have exclusively enabled "Triangulate faces" and "Include normal" in the Blender -> Export options. None of the actions above worked.

 

I have also checked my shader codes to see if they compiled and are referencing the correct variables. So far, there's nothing wrong. The OpenGL ES did not spit out any errors, when I was using glGetProgramInfo() and glGetShaderInfo(). They all pass. And I can see my model clearly, just that I didn't add any ambient lighting and shadows to the mesh.

 

I have somehow recreated the problem that I had asked a month ago prior that was solved by fixing the transformation matrix calculation methods. But this time, it's no longer the matrices. I have checked and confirmed that the transformation matrices are not causing the problem.

 

The cube that was exported/overwritten is the same cube mesh I had used in the Stack Overflow question above. Which looked like this below: (Left side: Perspective view of the back side of the cube mesh. Right side: Orthogonal view of the front size of the cube mesh.)

 

l0EaZpW.png

 

Below is an attachment of the Android APK, packed in a ZIP file.

 

[attachment=14673:3DOpenGL.zip]

 

Below is the project source file attached:

 

[attachment=14674:3DOpenGL_source.zip]

 

And below are some of the source code that I used to load the cube mesh model:  (Model class, OBJ model loader static method) They are shown for easier lookup.

 

package models;

import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import java.nio.FloatBuffer;
import java.nio.ShortBuffer;
import java.util.ArrayList;
import android.content.Context;
import android.content.res.AssetManager;
import android.util.Log;

public class Model {
	
	protected FloatBuffer vertexBuffer;
	protected ShortBuffer indexBuffer;
	
	public static Model loadOBJModel(Context c, String filename) {
		
		ArrayList<Float> tempVertices = new ArrayList<Float>();
		ArrayList<Float> tempNormals = new ArrayList<Float>();
		ArrayList<Short> tempVertexIndices = new ArrayList<Short>();
		ArrayList<Short> tempNormalIndices = new ArrayList<Short>();
		Model model = new Model();
		
		try {
			AssetManager manager = c.getAssets();
			BufferedReader reader = new BufferedReader(new InputStreamReader(manager.open(filename)));
			String line;
			while ((line = reader.readLine()) != null) {
				if (line.startsWith("v")) {
					for (int i = 0; i < 3; i++) {
						tempVertices.add(Float.valueOf(line.split(" ")[i + 1]));
					}
				}
				else if (line.startsWith("vn")) {
					for (int i = 0; i < 3; i++) {
						tempNormals.add(Float.valueOf(line.split(" ")[i + 1]));
					}
				}
				else if (line.startsWith("f")) {
					String[] tokens = line.split(" ");
					if (tokens[1].contains("/")) {
						for (int i = 0; i < 3; i++) {
							tempVertexIndices.add(Short.valueOf(tokens[i + 1].split("/")[0]));
							tempNormalIndices.add(Short.valueOf(tokens[i + 1].split("/")[2]));
						}
					}
					else {
						for (int i = 0; i < 3; i++) {
							tempVertexIndices.add(Short.valueOf(tokens[i + 1]));
						}
					}
				}
			}
			
			
			//TODO: Will add lighting back once everything is confirmed to work properly.
			float[] vertices = createFloatArray(tempVertices);
			//float[] normals= createFloatArray(tempNormals);
			short[] vertexIndices = createShortArray(tempVertexIndices);
			//short[] normalIndices = createShortArray(tempNormalIndices);
			
			model.vertexBuffer = ByteBuffer.allocateDirect(vertices.length * 4).order(ByteOrder.nativeOrder()).asFloatBuffer();
			model.vertexBuffer.put(vertices).position(0);
			model.indexBuffer = ByteBuffer.allocateDirect(vertexIndices.length * 2).order(ByteOrder.nativeOrder()).asShortBuffer();
			model.indexBuffer.put(vertexIndices).position(0);
			
		}
		catch (Exception e) {
			e.printStackTrace();
			Log.e("DEBUG loadCube()", "Exception error caught.", e);
		}
		
		return model;
	}
	
	//--------------------------------------
	
	private static float[] createFloatArray(ArrayList<Float> list) {
		float[] array = new float[list.size()];
		for (int i = 0; i < array.length; i++) {
			Float f = list.get(i);
			array[i] = (f != null ? f : Float.NaN);
		}
		return array;
	}
	
	private static short[] createShortArray(ArrayList<Short> list) {
		short[] array = new short[list.size()];
		for (int i = 0; i < array.length; i++) {
			Short f = list.get(i);
			array[i] = (f != null ? f : 0);
		}
		return array;
	}
}

 

Below is the Cube class: (Cube class, with transformation matrices, vertex and fragment shader codes, and the initialization)

 

package models;

import java.util.Arrays;
import android.content.Context;
import android.opengl.GLES20;
import android.opengl.Matrix;
import android.util.Log;


public class Cube {
	private String vertexCode = "" +
			"attribute vec4 a_position;              	\n" +
			"uniform mat4 u_mvpMatrix;                	\n" +
			"void main() {                           	\n" +
			"	gl_Position = u_mvpMatrix * a_position;	\n" +
			"}                         					\n";
	
	private String fragmentCode = "" +
			"precision mediump float;                   \n" +
			"void main() {                              \n" +
			"	gl_FragColor = vec4(0.0, 1.0, 0.0, 1.0);\n" +
			"}                                          \n";
	
	private int shaderProgram;
	
	private int attribute_Position;
	private int uniform_mvpMatrix;
	
	private float angle;
	private Model model;
	
	public Cube(Context c, String filename){
		model = Model.loadOBJModel(c, filename);
	}
	
	
	public void setup(){
		int vertexShader = GLES20.glCreateShader(GLES20.GL_VERTEX_SHADER);
		GLES20.glShaderSource(vertexShader, vertexCode);
		GLES20.glCompileShader(vertexShader);
		int fragmentShader = GLES20.glCreateShader(GLES20.GL_FRAGMENT_SHADER);
		GLES20.glShaderSource(fragmentShader, fragmentCode);
		GLES20.glCompileShader(fragmentShader);
		
		shaderProgram = GLES20.glCreateProgram();
		GLES20.glAttachShader(shaderProgram, vertexShader);
		GLES20.glAttachShader(shaderProgram, fragmentShader);
		GLES20.glBindAttribLocation(shaderProgram, 1, "a_position");
		GLES20.glLinkProgram(shaderProgram);
		
		int[] linked = new int[1];
		GLES20.glGetProgramiv(shaderProgram, GLES20.GL_LINK_STATUS, linked, 0);
		if (linked[0] == 0) {
			Log.e("DEBUG setup()", "Shader code error.");
			Log.e("DEBUG setup()", GLES20.glGetProgramInfoLog(shaderProgram));
			GLES20.glDeleteProgram(shaderProgram);
			return;
		}
		
		GLES20.glDeleteShader(vertexShader);
		GLES20.glDeleteShader(fragmentShader);
		
		attribute_Position = GLES20.glGetAttribLocation(shaderProgram, "a_position");
		uniform_mvpMatrix = GLES20.glGetUniformLocation(shaderProgram, "u_mvpMatrix");
		GLES20.glEnableVertexAttribArray(attribute_Position);
	}
	
	public void draw(float[] mMatrix, float[] vMatrix, float[] pMatrix){
		float[] mvpMatrix = new float[16];
		Matrix.setIdentityM(mMatrix, 0);
		Matrix.translateM(mMatrix, 0, 0f, -2.5f, -1.5f);
		Matrix.rotateM(mMatrix, 0, angle, 0f, 1f, 0f);
		
		// This is the transformation matrices that I had a problem with a month ago. It has been solved by using
		// an array copy of the original matrix. The behavior is already defined in the Android documentation.
		
		Matrix.multiplyMM(mvpMatrix, 0, vMatrix, 0, mMatrix, 0);
		Matrix.multiplyMM(mvpMatrix, 0, pMatrix, 0, Arrays.copyOf(mvpMatrix, 16), 0);
		
		
		
		GLES20.glUseProgram(shaderProgram);
		GLES20.glVertexAttribPointer(attribute_Position, 3, GLES20.GL_FLOAT, false, 3 * 4, model.vertexBuffer);
		
		GLES20.glUniformMatrix4fv(uniform_mvpMatrix, 1, false, mvpMatrix, 0);
		
		GLES20.glDrawElements(GLES20.GL_TRIANGLES, model.indexBuffer.capacity(), GLES20.GL_UNSIGNED_SHORT, model.indexBuffer);
		
		angle = ++angle % 360f;
	}
}

 

Oh boy, there's a lot of information provided just so I can nail this bug, squish it, and move on. I really need help on this one. Been looking for answers on Google search, and came up dry. The first three results are not what I wanted. The second result is the link that I asked for solutions a month ago. The rest of the results are tutorials.

 

If there's something I might have missed. Please let me know.

Edited by tom_mai78101

Share this post


Link to post
Share on other sites

There are at least two bugs in your model loading code:

 

line.startsWith("v")

What happens to lines with which start with "vn"? "vn" startsWith "v". This doesn't really matter right now, but you get unnecessary vertices, which are actually normals.

 

tempVertexIndices.add(Short.valueOf(tokens[i + 1].split("/")[0]));

You have to subtract one from the index numbers, because obj format starts counting indices from 1 instead of 0.

 

Hope this helps.

Edited by Sponji

Share this post


Link to post
Share on other sites

I'm currently debugging this problem, along with your tips.

line.startsWith("v");

 can also take in "v", "vn", and possibly "vt"? I did not know that...

 

--------------------------------------

 

Another question that I'm more confused is when the index buffer is read, does the index numbers in the buffers have to start off like:

 

0, 1, 2, 3, 4,...

 

And not the other way around?

 

1, 2, 3, 4, 5,...

 

I thought the index number and the vertex element in OpenGL ES reads the same, and that OpenGL ES automatically chooses the index element position accordingly. I'm checking this as I go.

Share this post


Link to post
Share on other sites

That is not what he means.

The values of the indices inside the .OBJ file are 1 greater than they should be (I seriously don’t understand the purpose of this—shame on the creators of .OBJ for what seems to be a newbie trap and nothing more), which means in order to make it useful to your program you need to subtract 1 from that value, not add one.

 

 

L. Spiro

Share this post


Link to post
Share on other sites

Thanks again for your input. I've now fully understood what all of you were saying.

 

I finally got the free time to continue debugging, and it looks like using:

String.startsWith(String prefix);

Is a bad idea. I've changed it to doing:

 

String header = line_read_from_input.split(" ")[0];
header.equals(String prefix);

So it's always correct.

 

Everything is now perfect. Life is good. Thanks to all and all a good night.

Edited by tom_mai78101

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628388
    • Total Posts
      2982403
  • Similar Content

    • By test opty
      Hi all,
       
      I'm starting OpenGL using a tut on the Web. But at this point I would like to know the primitives needed for creating a window using OpenGL. So on Windows and using MS VS 2017, what is the simplest code required to render a window with the title of "First Rectangle", please?
       
       
    • By DejayHextrix
      Hi, New here. 
      I need some help. My fiance and I like to play this mobile game online that goes by real time. Her and I are always working but when we have free time we like to play this game. We don't always got time throughout the day to Queue Buildings, troops, Upgrades....etc.... 
      I was told to look into DLL Injection and OpenGL/DirectX Hooking. Is this true? Is this what I need to learn? 
      How do I read the Android files, or modify the files, or get the in-game tags/variables for the game I want? 
      Any assistance on this would be most appreciated. I been everywhere and seems no one knows or is to lazy to help me out. It would be nice to have assistance for once. I don't know what I need to learn. 
      So links of topics I need to learn within the comment section would be SOOOOO.....Helpful. Anything to just get me started. 
      Thanks, 
      Dejay Hextrix 
    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
       
       
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
      Thanks!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
      Thanks.
  • Popular Now