• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
HelloSkitty

Printf acting weird

6 posts in this topic

I am trying to debug a program in order to find the cause of a segmentation fault.  So I commented all of the code and slowly uncommented from the start to find the location of the segmentation fault.  This was successful and I have discovered the function that is causing it.  Then, I decided to add a printf to the start of that function, and oddly enough nothing printed.  I then added printf to the calling function, and nothing printed there either.  So in the same manner of finding the location of the segmentation fault, I set about finding the place my program stopped printing.  And I did.  It was the line:

 

retVal->maxSize=10;

 

And I have no idea why.  All of the relevant code is here:

 

circular.h

typedef struct Quote {
	unsigned int time;
	double rate;
} quote;

typedef struct CBuf {
	unsigned int maxSize;
	unsigned int size;
	unsigned int first;
	unsigned int last;
	quote* arrayPointer;
} cbuf;

cbuf* cbuf_init();

void cbuf_delete(cbuf* cb_ptr);

void cbuf_update(cbuf* cb_ptr,unsigned int time,double rate);

double cbuf_average(cbuf* cb_ptr);

quote* cbuf_start(cbuf* cb_ptr);

quote* cbuf_end(cbuf* cb_ptr);

void cbuf_dump(cbuf* cb_ptr);

void cbuf_stats(cbuf* cb_ptr);

 

circular.c

#include "circular.h"
#include <stdlib.h>
#include <stdio.h>

cbuf* cbuf_init() {
	printf("cbufinit\n");
	cbuf* retVal;
	printf("makingretval\n");
	printf("%d\n",(*retVal).maxSize);
	retVal->maxSize=10;
	printf("9\n");
	retVal->size=0;
	retVal->first=0;
	retVal->last=0;
	quote* quotes=malloc(10*sizeof(quote));
	retVal->arrayPointer=quotes;
	return retVal;
}

// More code below, but this is the only function that is called
// makingretval and -72537468 are printed
// 9 is not printed

 

main6a.c

#include <stdio.h>
#include <stdlib.h>
#include "circular.h"

int main() { 
	printf("start\n");
	printf("1\n");
   cbuf *cb1 ;
	printf("2\n");
   cb1 = cbuf_init() ;
	printf("3\n");
   return 0 ;
}

// 1 and 2 are printed
// 3 is not printed

 

 

Everything compiles fine, it is simply that printf does not seem to work at all following the retVal->maxSize=10; line.  In a separate run, I added a getchar call after the printf("3\n") which ran fine.  So the program is still getting to the end with no issue.  I just want to know why it is not printing.

 

Thanks!

0

Share this post


Link to post
Share on other sites

Please allocate retVal before using it!

 

= malloc(sizeof(cbuf));

 

You re accessing a random memory position, which is undefined behavior. The printf not working is simply one of the many possible effects, thats why it is called undefined! :)

2

Share this post


Link to post
Share on other sites
printf() is a red herring. Your problem can be simplified to this:
int main()
{
    int* retval;
    *retval = 42;

    return 0;
}
You don't initialize retval, so it's pointing at random memory. Reading from it or writing to it is undefined behaviour, and may or may not cause catastrophic weirdness in your program.

You should malloc() retval or something similar so it has an actual address and not just random stack garbage :-)
2

Share this post


Link to post
Share on other sites

The problem is that you declare retVal as a pointer to cbuf, but you never assign it a value. Thus, retVal is an invalid pointer with a random value. When you start assigning to is cbuf properties, you start overwriting memory that does not belong to it.

 

You need to do something like:

 

    retVal = new cbuf(); // (c++)

 

or

 

    retVal = (cbuf*)malloc(sizeof(cbuf)); // c

1

Share this post


Link to post
Share on other sites

Thanks for all the fast responses!  Fixed it and it works now - I should probably be thankful my compiler/runner is in safe mode :D

0

Share this post


Link to post
Share on other sites

Also, please learn to use a debugger. Commenting out lines in order to hunt for bugs is so extremely slow and painful. The debugger can take you step by step through the code and give you all sorts of tools to help look at what's going on while the program runs.

Edited by Khatharr
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0