• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Rubiks14

[C++] Elusive access violation error

8 posts in this topic

So here's the deal, I've been working on a roguelike game in c++ using the advanced windows console functions in wincon.h. I have a randomly generated map and I'm drawing it to a screen. Every once in a blue moon when I'm running the program it will give me an access violation error on program close. I can run the program probably 50 times and if I'm lucky (unlucky actually) the error will show up.

 

I'm using codeblocks as my IDE and have the debugger set to break on an exception. I have been unable to actually recreate the access violation while using the debugger. It only seems to occur when I do a basic run of the program. It doesn't crash the program or lock up, it just gives the error code on close.

 

There is too much code to post here but you can look at it on github: https://github.com/Rubiks14/ASCII . I believe the error is happening in map.h but it might not hurt to look into screen.h and screen.cpp as well. Also I'm sorry for the craziness of the code in advance. Some of the comments are relevent but others need to be updated. I know there are a few things that need to be broken down into more functions and some stuff that would work better if passed by reference (the vectors), I'm just trying to eliminate this bug before altering anything else and before adding any new features.

 

One more thing. I think the problem is somewhere in the drawing procedures for the map or screen class.

 

 

EDIT: Fixed broken link

Edited by Rubiks14
0

Share this post


Link to post
Share on other sites

Thanks for the advice on the naming with the underscores and typedef. I don't have any of the room/map in a class. The map is just a struct and the features are just vectors of CHAR_INFO type.

 

Unfortunately I haven't been able to see the stack trace because I haven't been able to recreate it with the debugger running.

0

Share this post


Link to post
Share on other sites

I forgot to point out that your link is broken. It's got a period at the end of it and shouldn't.

 

Thanks for the advice on the naming with the underscores and typedef. I don't have any of the room/map in a class. The map is just a struct and the features are just vectors of CHAR_INFO type.

Structs can have constructors too.

 

Unfortunately I haven't been able to see the stack trace because I haven't been able to recreate it with the debugger running.

You can try building a release version with debug info.

2

Share this post


Link to post
Share on other sites

Unfortunately after doing that I still haven't come up with anything useful in helping me track down the error (it didn't occur). The only thing I can think to start doing now is disabling things one at a time to see if it keeps coming. It's too late for me to keep looking tonight. I'll give it another go tomorrow.

0

Share this post


Link to post
Share on other sites

The access violation is occurring when you are adding your features to the mapStorage vector in Map.h.

 

The feature location coordinates you produce have a lower limit of (1, 1) and an upper limit of (MapSize.X - 1, MapSize.Y - 1) which is perfectly valid, however when the Y coordinate is at the upper limit of this range and you attempt to access the tile below (e.g. line 260) the resulting index will be outside of the legal range of the vector which produces an access violation.

2

Share this post


Link to post
Share on other sites

MrP,

 

That seems to have fixed it. I didn't think about that. I had set the minimum to (1,1) to prevent from reaching memory in front of the vector but didn't think about it in the sense of after the vector.

 

Thank you and everyone else who assisted with this. Now I can clean this code up and finally move on to actually making this into a game.

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0