This topic is 1728 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

## Recommended Posts

I'm trying to make an optimized all software version of an OpenCL based ray-caster that I wrote a while ago and I'm struggling to find an efficient way to manage my threads.

What I want to do is have each thread casting rays into a different slice of the screen and then when they all finish show the rendered screen and repeat. I have a version that works but it is not ideal.

This is a slightly simplified version of my current code:

	while(1) //render loop
{
for(int i = 0; i < numCpus; i++)
{
}

for(int i = 0; i < numCpus; i++)
{
}

SDL_UpdateWindowSurface(mainwindow);
}


This is not ideal because I re-create the thread every time in the loop, which to my knowledge is inefficient. Semaphores, mutexes and the like all seem to try to stop two threads from doing something at the same time, I need to make sure that they do things at the same time. Anyone have an idea for a more efficient solution?

Edited by ic0de

##### Share on other sites
Yeah you shouldn't be creating and destroying the threads every loop iteration; you should be able to create/destroy them just once and re-use them.

You can move your while(1) loop into the thread's main function, so that the thread will continue to loop.
To synchronize the threads, so that they all loop together, you can use a mutex to control some kind of "command" structure. Each thread has it's own command/task, with it's own mutex, which ensures either the worker is doing the task, or the main thread is generating the task (but never both at once). Because each thread has their own task/mutex, they can all be doing work at the same time.
Something like:
struct RenderTask
{
Mutex lock;
Scene* input;
Window* output;
bool complete;
};

while(1)
{
int numComplete = 0;
{
++numComplete
}

if( numComplete == numThreads )//all jobs are done
{
fill in all tasks with data for next frame (including setting complete to false)
display results to screen
}
}

while(1)
{
{
}
}

Edited by Hodgman

##### Share on other sites

Have you tried using the parallel pattern library?

http://msdn.microsoft.com/en-us/library/dd492418.aspx

Cheers!

##### Share on other sites

Have you tried using the parallel pattern library?

http://msdn.microsoft.com/en-us/library/dd492418.aspx

Cheers!

I don't really think it's a problem with the library i'm using but rather my implementation.

##### Share on other sites

Well I didn't say that there was a problem with your current way of doing things. I just gave you some other way to handle threading. The PPL has some functions which make it pretty easy to implement multithreading especially in simple "embarrassingly parallel" cases.

Cheers!