# how to draw a circle with 'Bresenham'

This topic is 1727 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

## Recommended Posts

first i use D3DFVF_XYZRHW, the effect is ok with D3DPT_POINTLIST, but i do not know how to arrange the vertex to draw the solid circle with D3DPT_TRIANGLELIST

then i move to D3DFVF_XYZ, i have to change the parameter of D3DXMatrixLookAtLH to suit the radius, but the drawing effect is awful

##### Share on other sites

Why not with triangle fan?

D3DXVECTOR2* D3DXVec2Rotate(D3DXVECTOR2* vOut, D3DXVECTOR2* vIn, float rad, const D3DXVECTOR2* vCenter)
{

float X = vIn->x;
float Y = vIn->y;

X -= vCenter->x;
Y -= vCenter->y;

vOut->x = X * cr - Y * sr;
vOut->y = X * sr + Y * cr;

vOut->x += vCenter->x;
vOut->y += vCenter->y;

return vOut;
}

...
struct VERTEX
{
D3DXVECTOR4 p;
};

static const std::size_t numPts = 20; // points cnt on circle
std::vector<VERTEX> vVertices;
d3d9device->SetFVF(D3DFVF_XYZRHW); // pre-tranformed vertex
VERTEX center; // vertex in center of circle
center.p = D3DXVECTOR4(500.0f, 400.0f, 0.0f, 1.0f); // set circle center on screen center (1000x800) / 2
D3DXVECTOR2 ct(center.p.x, center.p.y);
vVertices.push_back(center); // add center first beause of triangle fan "rule"
for(std::size_t i = 0; i < numPts; ++i)
{
float ang = (D3DX_PI * 2.0f) * ((float)i / (float)numPts);
D3DXVec2Rotate(&pt, &pt, ang, &ct);
VERTEX vert;
vert.p = D3DXVECTOR4(pt.x, pt.y, 0.0f, 1.0f);
vVertices.push_back(vert);
}
vVertices.push_back(vVertices[1]); // add first point (on circle) to close
d3d9device->DrawPrimitiveUP( D3DPT_TRIANGLEFAN, numPts, &vVertices[0], sizeof(VERTEX) );

Edited by belfegor

##### Share on other sites

sinf and cosf is too slow

##### Share on other sites

http://www.gamedev.net/topic/259860-drawing-circle-in-directx/

Maybe the source code does what you are looking for.

 How many thousand / million circles you are planning to draw in order to be bottle necked by sin/cos ??? I'd say that sin&cos isn't the biggest problem here. Especially if you pre-create your geometry, the sin&cos won't have any effect while drawing.

Cheers!

Edited by kauna

##### Share on other sites

+1 What kauna said.

Alternative fast sin/cos

float fast_sin(float rad)
{
static const float B = 4 / D3DX_PI;
static const float C = -4 / (D3DX_PI * D3DX_PI);

return y;
}

{
static const float B = 4 / D3DX_PI;
static const float C = -4 / (D3DX_PI * D3DX_PI);

return y;
}


http://devmaster.net/forums/topic/4648-fast-and-accurate-sinecosine/

My code above is just an example, you could precalculate most stuff at init time, no need to do that every frame.

Edited by belfegor

##### Share on other sites

i want to use Bresenham and D3DFVF_XYZ and D3DFILL_WIREFRAME, but no idea

##### Share on other sites

Why not draw a line list then? You don't need to draw triangles in wireframe to get lines.

Cheers!

##### Share on other sites

wireframe is an example

using Bresenham, the vertex is out of order, i have no idea how to arrange the vertex

using cosf and sinf according to the angle is simple, but not effecitve

##### Share on other sites

What is the thing with Bresenham's algorithm? Can you make a drawing for us what you want to accomplish?

You want to draw a circle using points? That's highly inefficient (even more inefficient than using sin and cos btw).

Have you made some performance analysis which point out that sin and cos are your problem?

Best regards!

##### Share on other sites

that algorithm is simple, and it works fine with D3DFVF_XYZRHW and D3DPT_POINTLIST

i want to apply it to D3DFVF_XYZ and solid circle

##### Share on other sites

So do I understand you correctly that you want to draw a filled shape (circle in this case) and use Bresenham's algorithm (which is used mostly for drawing circle contour) ?

The difference between D3DFVF_XYZRHW and D3DFVF_XYZ is that the RHW version skips vertex shader / projection part ie. it assumes that the data is already transformed. D3DFVF_XYZ doesn't skip transformation and projection so you'll need to provide a correct world, view and projection matrix in order to draw correctly.

If you are drawing 2d shapes on the screen then the RHW version should do the trick. However, you may accomplish the same with D3DFVD_XYZ but you'll need correct matrices for it to work correctly. Do you need to draw circles in 3d space?

Cheers!

##### Share on other sites

So do I understand you correctly that you want to draw a filled shape (circle in this case) and use Bresenham's algorithm (which is used mostly for drawing circle contour) ?

The difference between D3DFVF_XYZRHW and D3DFVF_XYZ is that the RHW version skips vertex shader / projection part ie. it assumes that the data is already transformed. D3DFVF_XYZ doesn't skip transformation and projection so you'll need to provide a correct world, view and projection matrix in order to draw correctly.

If you are drawing 2d shapes on the screen then the RHW version should do the trick. However, you may accomplish the same with D3DFVD_XYZ but you'll need correct matrices for it to work correctly. Do you need to draw circles in 3d space?

Cheers!

yeah, that's what i mean, in 3d space

even i increase the radius and adjust the parameter of D3DXMatrixLookAtLH to suit the radius, the effect is awful

##### Share on other sites

+1 What kauna said.

Alternative fast sin/cos

float fast_sin(float rad)
{
static const float B = 4 / D3DX_PI;
static const float C = -4 / (D3DX_PI * D3DX_PI);

return y;
}

{
static const float B = 4 / D3DX_PI;
static const float C = -4 / (D3DX_PI * D3DX_PI);

return y;
}


http://devmaster.net/forums/topic/4648-fast-and-accurate-sinecosine/

My code above is just an example, you could precalculate most stuff at init time, no need to do that every frame.

is this fast cos/sin authoritative and cos/sin acceptable in reality?

##### Share on other sites

I am using it for my particle system, for me visually there is no noticeable difference between these and standard sin/cos. Why not try and see?

Edited by belfegor

##### Share on other sites

I am using it for my particle system, for me visually there is no noticeable difference between these and standard sin/cos. Why not try and see?

thanks, i will try and this remind me of the 'hacker's delight'

then what about Bresenham, can it be used in D3DFVF_XYZ

Edited by tcige

##### Share on other sites

Note for these function to work properly you must wrap your rad parameter -PI - PI

##### Share on other sites

then what about Bresenham, can it be used in D3DFVF_XYZ

I don't think so. The Bresenham's circle algorithm is suitable to drawing a circles in 2d. It was developed when drawing single pixels to the screen was the slowest thing ever... that's like some decades ago.

Just create a mesh using the given functions (as smooth as required) and I can guarantee that the sin and cos functions aren't the performance bottle neck. If you store the geometry inside a vertex buffer, it'll be enough to create the mesh once at the start up.

Give some screenshots to show what you want and what you have accomplished. It is really difficult to read people's mind you know.

Cheers!

Edited by kauna

##### Share on other sites

then what about Bresenham, can it be used in D3DFVF_XYZ

I don't think so. The Bresenham's circle algorithm is suitable to drawing a circles in 2d. It was developed when drawing single pixels to the screen was the slowest thing ever... that's like some decades ago.

Just create a mesh using the given functions (as smooth as required) and I can guarantee that the sin and cos functions aren't the performance bottle neck. If you store the geometry inside a vertex buffer, it'll be enough to create the mesh once at the start up.

Give some screenshots to show what you want and what you have accomplished. It is really difficult to read people's mind you know.

Cheers!

thanks a lot

i'm new to directx, and someone says cosf/sinf's efficiency is much slower than Bresenham

finally i find difficult to apply it to 3d, and i'll be glad to use cosf/sinf because it needs only a few lines