Sign in to follow this  
Nicholas Kong

Is there an overhead for performing chains of method calls?

Recommended Posts

Nicholas Kong    1535

Is there an overhead for performing chains of method calls?

 

Example of my code from past projects:

 

Main.getPolynomialHolder().get(polynomialIndex).getPolynomialVector().get(i).setExponent(Main.getPolynomialHolder().get(polynomialIndex).getPolynomialVector().get(i).getExponent()-1);

Share this post


Link to post
Share on other sites
SiCrane    11839
Maybe. It depends on your language, the quality of your compiler, compiler settings used, exactly how each function is implemented and so on.

Share this post


Link to post
Share on other sites
Nicholas Kong    1535

Maybe. It depends on your language, the quality of your compiler, compiler settings used, exactly how each function is implemented and so on.

The code is in Java. My IDE is Eclipse. The code uses the built-in Vector Class from the standard Java library.  

Share this post


Link to post
Share on other sites
Nicholas Kong    1535

There are actually two things.

 

First, the average cost of those function call.

 

It is something very specific to the hardware and the compiler combination.  It is something that lots of people have researched and measured over the years.  

 

However, since compilers have converged on the near-optimal case for function calls, and since processor speeds have basically top-lined around 2.5-3.0 GHz range a decade ago, the timing remains basically unchanged.

 

The amortized cost of an optimized build function call is approximately 7 nanoseconds overhead per function call, vs. the cost of direct access.  There is an additional approximately 7 nanoseconds overhead for virtual functions.

 

Again, for an optimized build, non-virtual functions generally average around 7ns each, virtual functions generally average around 14ns each.

 

Assuming you have all optimizations enabled in your code and it has been either directly compiled or JIT-optimized, you will probably see similar results.

 

 

 

Now for the bigger issue.

 

Your code has a nasty code smell.  It is often called "inappropriate intimacy".  The solution pattern is called the Law of Demeter, where basically you should only talk to the objects immediately available to you.  The most you should do is a.b().  

 

You have a.b().c().d().e().f(), which is less of a a 'code smell' and more like a reeking 2-day-old diaper.  Don't do that.

Thanks for the feedback on the code. The smell came from the design I had in mind. 

Share this post


Link to post
Share on other sites
Capoeirista    3266

The most you should do is a.b().  

I've always liked a quote from Brian Kernighan regarding debugging:

 

Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it

 

What frob said is spot on :)

Share this post


Link to post
Share on other sites
rip-off    10976

Is there any inlining taking place?

Almost certainly. A modern JVM will inline functions dynamically based on how they are actually used. An interesting consequence of this is that in some circumstances a JVM can inline in C++ what would be "virtual" calls.

Share this post


Link to post
Share on other sites
TheChubu    9446

Aren't all Java method calls "virtual" ? I think I read that when I was researching the final keyword for methods and their parameters. Which many concluded it basically does nothing since the most relevant work to see if it can be inlined is done by the VM by analyzing the behavior of the method directly rather than relying on keywords.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this