Sign in to follow this  
ak09

Struct copy inside itself

Recommended Posts

ak09    131
struct wheel
{
       wheel *copy;
       wheel()
       {
              // variables assignment
              copy = (wheel *)malloc(sizeof(wheel));
              *copy = *this;
       }
       // variables...
};
 

Is this a reasonable code? Will it behavior nice for my purpose of having a struct's copy that way?

 

Share this post


Link to post
Share on other sites
Brother Bob    10344

This depends greatly on how you handle the copying, and what a "copy" actually means in this case. You need to differentiate between the original and the copy in order to handle the copy of the original object as a copy, and not an original in itself that has yet another copy of itself.

 

Explain why you need this and what you intend to do with this copy instead and we may able to provide an actual answer to the specific question, or even provide a better solution.

Share this post


Link to post
Share on other sites
zacaj    667

Your code *is* valid.  copy will be an exact copy of the struct, including containing its own copy that points to itself.  

Share this post


Link to post
Share on other sites
ak09    131

I'm trying to have a copy of my dozens of variables struct inside it, because it'll only be used in that header file. There will be no reason why my main file should know about this copy's existance.
Using the above struct as an example, should be a funcion named spin(wheel w), which is called millions of times. All I need, for a faster performance, is to copy the struct once, right after it's creation, and not on every spin call.

Share this post


Link to post
Share on other sites
ak09    131

Your code *is* valid.  copy will be an exact copy of the struct, including containing its own copy that points to itself.  

Yeah, it's working fine so far.

Share this post


Link to post
Share on other sites
Khatharr    8812
The ctor does not set any variables (other than copy), so copy will simply point to block of memory identified as being of type 'wheel' with undefined values.

? Edited by Khatharr

Share this post


Link to post
Share on other sites

Is this C or C++? You're using malloc and structs, which implies C-style programming, but you have a constructor, implying it's actually C++.

 

If C++, why not do something like this:

class Wheel
{
      public:
      Wheel()
      {
           //Do the thing that you only want to do once here.
      }
      
      
      
}

 

Or this:

class Wheel
{
      public:
      Wheel()
      {
           //Do the thing that you only want to do once here.
      }
      
      void Spin()
      {
            if(!hasAlreadyBeenSpun)
                   this->doThatThingYouOnlyDoOnce();
      }
      
      private:
      bool hasAlreadyBeenSpun = false;
 
     void doThatThingYouOnlyDoOnce()
     {
          //Your code goes here.
     }
}

 

The first option is much better though, because if a function says "Spin()", I expect the function to do what it says. Coding is hard enough without function names lying to you. wink.png

 

Maybe you want the constructor to spin, and you actually want a function called "GetResultOfSpin()"?

Share this post


Link to post
Share on other sites
rip-off    10976

The code can become invalid if you add a non-trivial copy constructor to the wheel class, which you would have to do to avoid leaking memory. 

 

I cannot understand exactly what you want. Have you considered passing the wheel by (const) reference instead? If copies are expensive, what about making your wheel class noncopyable? Are you trying to use something like the pimpl idiom or the flyweight pattern?

Share this post


Link to post
Share on other sites
King Mir    2490
It looks like you need to think about your problem more, because I cannot see a useful application of what you're trying to do.

That said, the way to create a copy on the heap is this:
struct wheel
{
       wheel *copy;
       wheel() 
       {
              copy = new wheel(*this);
       }
       //also needs copy constructor, assignment, and destructor, to handel freeing correctly.
};
 
Even better you can use this:
 
#include<memory>
 
struct wheel
{
       std::shared_ptr<wheel> copy;
       wheel() 
       {
              copy.reset(new wheel(*this));
       }
       //copy constructor, assignment, and destructor not needed; free does not need to be called.
};

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this