• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
ak09

Struct copy inside itself

10 posts in this topic

struct wheel
{
       wheel *copy;
       wheel()
       {
              // variables assignment
              copy = (wheel *)malloc(sizeof(wheel));
              *copy = *this;
       }
       // variables...
};
 

Is this a reasonable code? Will it behavior nice for my purpose of having a struct's copy that way?

 

0

Share this post


Link to post
Share on other sites

This depends greatly on how you handle the copying, and what a "copy" actually means in this case. You need to differentiate between the original and the copy in order to handle the copy of the original object as a copy, and not an original in itself that has yet another copy of itself.

 

Explain why you need this and what you intend to do with this copy instead and we may able to provide an actual answer to the specific question, or even provide a better solution.

0

Share this post


Link to post
Share on other sites

Your code *is* valid.  copy will be an exact copy of the struct, including containing its own copy that points to itself.  

0

Share this post


Link to post
Share on other sites

I'm trying to have a copy of my dozens of variables struct inside it, because it'll only be used in that header file. There will be no reason why my main file should know about this copy's existance.
Using the above struct as an example, should be a funcion named spin(wheel w), which is called millions of times. All I need, for a faster performance, is to copy the struct once, right after it's creation, and not on every spin call.

0

Share this post


Link to post
Share on other sites

Your code *is* valid.  copy will be an exact copy of the struct, including containing its own copy that points to itself.  

Yeah, it's working fine so far.

0

Share this post


Link to post
Share on other sites
The ctor does not set any variables (other than copy), so copy will simply point to block of memory identified as being of type 'wheel' with undefined values.

? Edited by Khatharr
0

Share this post


Link to post
Share on other sites

Is this C or C++? You're using malloc and structs, which implies C-style programming, but you have a constructor, implying it's actually C++.

 

If C++, why not do something like this:

class Wheel
{
      public:
      Wheel()
      {
           //Do the thing that you only want to do once here.
      }
      
      
      
}

 

Or this:

class Wheel
{
      public:
      Wheel()
      {
           //Do the thing that you only want to do once here.
      }
      
      void Spin()
      {
            if(!hasAlreadyBeenSpun)
                   this->doThatThingYouOnlyDoOnce();
      }
      
      private:
      bool hasAlreadyBeenSpun = false;
 
     void doThatThingYouOnlyDoOnce()
     {
          //Your code goes here.
     }
}

 

The first option is much better though, because if a function says "Spin()", I expect the function to do what it says. Coding is hard enough without function names lying to you. wink.png

 

Maybe you want the constructor to spin, and you actually want a function called "GetResultOfSpin()"?

0

Share this post


Link to post
Share on other sites

The code can become invalid if you add a non-trivial copy constructor to the wheel class, which you would have to do to avoid leaking memory. 

 

I cannot understand exactly what you want. Have you considered passing the wheel by (const) reference instead? If copies are expensive, what about making your wheel class noncopyable? Are you trying to use something like the pimpl idiom or the flyweight pattern?

0

Share this post


Link to post
Share on other sites
It looks like you need to think about your problem more, because I cannot see a useful application of what you're trying to do.

That said, the way to create a copy on the heap is this:
struct wheel
{
       wheel *copy;
       wheel() 
       {
              copy = new wheel(*this);
       }
       //also needs copy constructor, assignment, and destructor, to handel freeing correctly.
};
 
Even better you can use this:
 
#include<memory>
 
struct wheel
{
       std::shared_ptr<wheel> copy;
       wheel() 
       {
              copy.reset(new wheel(*this));
       }
       //copy constructor, assignment, and destructor not needed; free does not need to be called.
};
1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0