• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Crusable77

Is this bad?

11 posts in this topic

Hello, I am working on a project in sfml and I am making a very basic tile map editor. I am working on the tile selection and this is how I got the selected tile to snap to a 64* 64 tile:

 

 
m_sfSelectedTilePos.x = (float)(((int)m_sfEvent.mouseButton.x / 64) * 64);
m_sfSelectedTilePos.y = (float)(((int)m_sfEvent.mouseButton.y / 64) * 64); 
0

Share this post


Link to post
Share on other sites
I don't think it is bad, but I think it is better to work with integers. Assumming the position of a tile is the top left corner, then a tile at index (1, 2) should have the position (1 * 64, 2 * 64) = (64, 128). So the float position can be calculated only when absolutely needed.

So then the index of a tile would be calculated by
m_sfSelectedTileIndex.x = m_sfEvent.mouseButton.x / 64;
m_sfSelectedTileIndex.y = m_sfEvent.mouseButton.y / 64;
Edited by ultramailman
0

Share this post


Link to post
Share on other sites

When you mean work with ints do you mean make all my floats into ints. Most SFML's classes I am using uses sf::Vector2f's.

0

Share this post


Link to post
Share on other sites

When you mean work with ints do you mean make all my floats into ints. Most SFML's classes I am using uses sf::Vector2f's.

Not at all, the position can still be float. Simply multiply the index by 64, and cast to a float.
0

Share this post


Link to post
Share on other sites

Two maxims: Programmers should never repeat themselves, and magic numbers are bad.

 

 

Create a function to snap to a tile.  Perhaps use the signature Vector2F SnapToTile(Vector2F source) { }.

 

Second, rather than using the constant 64, instead use a static const int defined in a header file somewhere.

 

 

Your version will always snap to the nearest border, and perhaps someday you would rather the function snap to the nearest tile boundary.

 

Your way of doing things is not bad, but Frob's way will probably work better in the long run.  Quickly adding to Frob's answer, I would poll the values from somewhere.  Most editors have a drop down menu that lets you select snapping values.

0

Share this post


Link to post
Share on other sites

I'd recommend using floor() rather than casting to int back and forth. The casting can be several times slower (if performance is an issue)

 

Note that floor( -3.3 ) = -4; while (int)-3.3 = -3; but floor's behavior is usually how you want snapping to work if negative numbers are possible.

2

Share this post


Link to post
Share on other sites

Two maxims: Programmers should never repeat themselves...

What did you mean by this?

0

Share this post


Link to post
Share on other sites

By the way, you can use floor() instead of converting to ints:

 

m_sfSelectedTilePos.x = floor(m_sfEvent.mouseButton.x / 64) * 64;
 

Edit: oops, just saw that Matias already said it. Sorry!

Edited by DaleyPaley
0

Share this post


Link to post
Share on other sites


Two maxims: Programmers should never repeat themselves...

What did you mean by this?


The code in the first post contains two lines of code that are almost identical. Chances are you can give the operation a good name and put it in a function.

I also recommend writing operations on vectors or points instead of having high-level code do everything component by component.
float snap_to_multiple(float x, float size) {
  return std::floor(x / size) * size;
}

Point snap_to_grid(Point p, float tile_size) {
  Point result;
  result.x = snap_to_multiple(p.x, tile_size);
  result.y = snap_to_multiple(p.y, tile_size);
  
  return result;
}

// ...

m_sfSelectedTilePos = snap_to_grid(m_sfEvent.mouseButton, 64.0f);

Edited by Álvaro
1

Share this post


Link to post
Share on other sites

A simple solution to force casting to snap the value is to use a half-unit offset:

 

iX = (int)(fX + 0.5f);

 

or to support both positive and negative values:

 

iX =  fX > 0 ? (int)(fX + 0.5f) : (int)(fX - 0.5f);

 

Note: casting to int truncates towards zero.

 

Edit: I was too rash - better solutions have been posted above since you're not dealing with unit intervals.

0

Share this post


Link to post
Share on other sites

If you want to round an int down to a multiple of 64, you can use bitmasking:

 

x = x & ~63;

 

Note that this only works for powers of two.

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0