• Advertisement
Sign in to follow this  

DX11 DX11 - Swap Chain - Slow Engine

This topic is 1712 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hi guys,

 

PS. FPS I GOT IN MY ENGINE: 50 - 70 fps, res: 1080x1920, system can run Crysis 3 at high settings, so that's not the problem.

 

Scene:

2zdx0ck.png

 

right now I'm facing another issue, which is the performance of my Engine. Now the problem is not my architecture, well at least I don't think so, so I tried running a Profiler.

 

Most of the performance was taken off in the initialization of course, but then later on in the render loop then rendering of the depth, normal, diffuse maps are quite fast, relatively to other things. Now the real problem comes when the swapchain->present(0,0) is called. As i understand it takes a long time because it's waiting for the previous frame to finish, right?

 

I have head some rumors about that if statements in a shader are quite weird, because even though it is a negative statement, false, it will still semi-run/check all the contents inside the if statement, which makes it quite slow, is this true or just some rubbish?

 

Also my FPS is NOT affected if I change my regular shader for all the objects (tried to remove all so only the positions were calculated in world space and then returned a white color), but then if I changed my Post Processing shader to a very simple version which ONLY returns the diffuse map, my FPS is boosted 2x - 3x times! But why? (Shader is below if you're interested, but there are still errors).

 

Texture2D t_dffmap : register(t0);
Texture2D t_depthmap : register(t1);
Texture2D t_normalmap : register(t2);
Texture2D t_random : register(t3);
Texture2D t_blmextract : register(t4);
Texture2D t_megaparticles : register(t5);
Texture2D t_fractalnoise : register(t6);
Texture2D t_softp : register(t7);
Texture2D t_softp_depth : register(t8);
Texture2D t_shadowmap : register(t9);
Texture2D t_glowmap : register(t10);
SamplerState ss;

cbuffer PARAMSBUFFER : register(b0)
{
	float time;
	float blur;
	float bloomExtract;
	float bloom;
	float pixelDisortion;
	float pixelDisorterAmount;
	float ssao;
	float bluramount;
	float megaparticles;
	float radialblur;
	float radial_start;
	float radial_width;
	float2 radial_center;
	float fractalNoise;
	float glowmap;

	matrix view;
};

cbuffer BloomBuffer : register(b1)
{
	float BloomThreshold;
	float BloomSaturation;
	float BaseSaturation;
	float BloomIntensity;
	float BaseIntensity;
};

cbuffer SSAOBuffer : register(b2)
{
	float g_scale;
	float g_bias;
	float g_sample_rad;
	float g_intensity;
	float ssaoIterations;
	float3 pppspace;
};

cbuffer GODRAYBuffer : register(b3)
{
	float3 LightPosition;
	float pad;
	matrix WorldViewProjection;
	
	float GOD_Density;
	float GOD_Weight;
	float GOD_Decay;
	float GOD_Exposure;
	float GOD_NUM_SAMPLES;
	float GodRays;
	float2 ppad;
};

struct VS_Output
{  
    float4 Pos : SV_POSITION;              
    float2 Tex : TEXCOORD0;
	float2 LightPos : TEXCOORD1;	
};
 
VS_Output VShader(uint id : SV_VertexID)
{
    VS_Output Output;
    Output.Tex = float2((id << 1) & 2, id & 2);
    Output.Pos = float4(Output.Tex * float2(2,-2) + float2(-1,1), 0, 1);
	
    return Output;
}

// Helper for modifying the saturation of a color.
float4 AdjustSaturation(float4 color, float saturation)
{
    // The constants 0.3, 0.59, and 0.11 are chosen because the
    // human eye is more sensitive to green light, and less to blue.
    float grey = dot(color, float3(0.3, 0.59, 0.11));

    return lerp(grey, color, saturation);
}

// Ambient Occlusion Stuff --------------------------------------------------

float3 getPosition(in float2 uv)
{
	return mul( t_depthmap.Sample(ss, uv).xyz, view);
}

float3 getNormal(in float2 uv)
{
	return normalize(t_normalmap.Sample(ss, uv).xyz * 2.0f - 1.0f);
}

float2 getRandom(in float2 uv)
{
	return normalize( mul(t_random.Sample(ss, float2(800, 600) * uv / float2(64, 64)).xy * 2.0f - 1.0f, view) );
}

float doAmbientOcclusion(in float2 tcoord,in float2 uv, in float3 p, in float3 cnorm)
{
	float3 diff = getPosition(tcoord + uv) - p;
	const float3 v = normalize(diff);
	const float d = length(diff)*g_scale;
	return max(0.0,dot(cnorm,v)-g_bias)*(1.0/(1.0+d))*g_intensity;
}

// End

float4 PShader(VS_Output input) : SV_TARGET
{
	if (bloomExtract == 1)
	{
		// Look up the original image color.
		float4 c = t_dffmap.Sample(ss, input.Tex);

		// Adjust it to keep only values brighter than the specified threshold.
		return saturate((c - BloomThreshold) / (1 - BloomThreshold));
	}

	float4 color = float4(1.0f, 1.0f, 1.0f, 1.0f);
	
	if (pixelDisortion == 1)
	{
		// Distortion factor
		float NoiseX = pixelDisorterAmount * (time/1000) * sin(input.Tex.x * input.Tex.y+time/1000);
		NoiseX=fmod(NoiseX,8) * fmod(NoiseX,4); 

		// Use our distortion factor to compute how much it will affect each
		// texture coordinate
		float DistortX = fmod(NoiseX,5);
		float DistortY = fmod(NoiseX,5+0.002);
 
		// Create our new texture coordinate based on our distortion factor
		input.Tex = float2(DistortX,DistortY);
	}

	if (fractalNoise == 1)
	{
		float offset = saturate((t_fractalnoise.Sample(ss, input.Tex) / 10.0f));

		input.Tex += 1 * (t_fractalnoise.Sample(ss, input.Tex).xy - 0.5)/15;
	}

	float4 dffMAP = t_dffmap.Sample(ss, input.Tex);

	if (megaparticles == 1)
	{
		dffMAP.a = 0.0f;

		dffMAP += t_megaparticles.Sample(ss, input.Tex);
	}

	color = dffMAP;

	if(bloom == 1)
	{
		// Look up the bloom and original base image colors.
		float4 cbloom = t_blmextract.Sample(ss, input.Tex);
		float4 base = color;
    
		// Adjust color saturation and intensity.
		cbloom = AdjustSaturation(cbloom, BloomSaturation) * BloomIntensity;
		base = AdjustSaturation(base, BaseSaturation) * BaseIntensity;
    
		// Darken down the base image in areas where there is a lot of bloom,
		// to prevent things looking excessively burned-out.
		base *= (1 - saturate(cbloom));
    
		// Combine the two images.
		color = base + cbloom;
	}

	if (blur == 1)
	{
		float hblur[17] = {0, -1, 2, -3, 4, -5, 6, -7, 8, -9, 10, -11, 12, -13, 14, -15, 16};

		int i = 0;
		for(;i < bluramount;)
		{
			color += t_dffmap.Sample(ss, input.Tex + float2(0.002f * hblur[i+1],0.002f * hblur[i]));

			i++;
		}

		i++;
		color = color / i;
	}
	else if (radialblur == 1)
	{
		const int nsamples = 16;

		input.Tex -= 0.5;
    
		for(int i=0; i<nsamples; i++) 
		{
    		float scale = radial_start + radial_width*(i/(float) (nsamples-1));
    		color += t_dffmap.Sample(ss, input.Tex.xy*scale + radial_center );
   		}
   		color /= nsamples;
	}
	
	if (ssao == 1)
	{
		// Apply SSAO

		const float2 vec[4] = {float2(1,0),float2(-1,0),
				float2(0,1),float2(0,-1)};

		float3 p = getPosition(input.Tex);
		float3 n = getNormal(input.Tex);
		float2 rand = getRandom(input.Tex);

		float ao = 0.0f;
		float rad = g_sample_rad/p.z; // g_s_r

		//**SSAO Calculation**//
		int iterations = ssaoIterations;
		for (int j = 0; j < iterations; ++j)
		{
		  float2 coord1 = reflect(vec[j],rand)*rad;
		  float2 coord2 = float2(coord1.x*0.707 - coord1.y*0.707,
					  coord1.x*0.707 + coord1.y*0.707);
  
		  ao += doAmbientOcclusion(input.Tex,coord1*0.25, p, n);
		  ao += doAmbientOcclusion(input.Tex,coord2*0.5, p, n);
		  ao += doAmbientOcclusion(input.Tex,coord1*0.75, p, n);
		  ao += doAmbientOcclusion(input.Tex,coord2, p, n);
		}
		ao/=(float)iterations*4.0;
		color.rgb *= ao;
	}

	// Soft Particles
	float pDepth = t_softp_depth.Sample(ss, input.Tex);
	float wDepth = t_depthmap.Sample(ss, input.Tex);
	float twD = t_depthmap.Sample(ss, input.Tex);

	if ((wDepth < pDepth) || twD == 0)
	{
		float4 pColor = t_softp.Sample(ss, input.Tex);

		if (twD != 0)
			pColor.a = saturate((wDepth - pDepth) * 1);

		color += pColor;
	}
	// End

	if (glowmap == 1)
	{
		color += t_glowmap.Sample(ss, input.Tex);
	}

	if (GodRays == 1)
	{
		float2 deltaTexCoord = (input.Tex - input.LightPos.xy);  
		deltaTexCoord *= GOD_Density / GOD_NUM_SAMPLES;  
		//float4 color = t_dffmap.Sample(ss, input.Tex);
		float illuminationDecay = 1.0f;  
		for (int i = 0; i < GOD_NUM_SAMPLES; i++)  
		{  
			input.Tex -= deltaTexCoord;  
			float4 sample = t_dffmap.Sample(ss, input.Tex);
			sample *= illuminationDecay * GOD_Weight;  
			color += sample;  
			illuminationDecay *= GOD_Decay;  
		}  

		return color * GOD_Exposure;  
	}

	return color;
}

 

 

Now I understand that in GameDev there are many experienced programmers in graphics, so now I ask them/you, what can speed up an engine, what should I avoid? Tricks?

 

And that's basically it, thanks for taking interest! happy.png

Share this post


Link to post
Share on other sites
Advertisement

1. You are most obviously fillrate-bound. Post the FPS in lower resolutions (e.g. 640x480).

 

2. You took a shorter / simpler route and created an uber-shader. That's great during debugging/development, but as you noticed, it has a negative impact.

 

3. It is very easy to check the impact of conditions. Just create a separate technique/shader pair that will have only single codepath (say - just bloom), without any conditions whatsoever.

 

4. Make sure VSync is off.  With 52 , it doesn't look like VSync is On, but better safe than sorry...

 

Of course, as always, there will be 10 other things that impact FPS (many of them on the CPU side - AI, pathfinding, ...) , but let's first address those that have biggest impact.

Share this post


Link to post
Share on other sites

You can put them in the same hlsl file, as long as you're willing to compile it more than once.

 

You simply swap tests like "if (blur == 1) { ... }" for "#if defined(BLUR) ... #endif" and compile once with "/D BLUR" on the command line, once with "/D SSAO", etc. You can also set the defines in code if you're compiling shaders at runtime.

 

You then pick the correct shader to use, instead of setting a constant.

Share this post


Link to post
Share on other sites

SSAO and god rays can be very pixel heavy effects and I'm guessing you're doing them at full resolution (1920x1080).  Even full screen blurs can put a fair amount of pressure on fill rate at high resolutions.  When you take into account that more than likely every one of your branches is being evaluated even if the conditions are false, this could be adding up to make a very expensive shader.

 

A lot of these effects are rendered to smaller render targets, such as something like 1/4 size of the backbuffer (experiment with the size to get a good image quality vs. performance trade off).  And as mentioned above, even though it's 2013 we still really need to be using the preprocessor for our branches rather than if statements.  My recommendation would be render SSAO to a small target by itself, then god rays to another small target by themselves, then have your big post process shader at the end composite those effects along with blurs and distortion etc. using #defines to turn effects on and off as needed.

Share this post


Link to post
Share on other sites

If statements can be cheap in hlsl, if there's no branch involved and the code you execute is simple. For example this if statement is a cheap one:

 

if (x > 7) x = 7;

 

They are also free if the condition can be evaluated at compile time.

 

They get expensive when the extra code that gets executed is significant, because the compiler will generally execute the code anyway and multiply the result by either 0 or 1 depending on the result of the if.

 

You can also ask the compiler to [branch] instead of evaluating the whole thing and throw away the result. The expense of that depends on things like what pattern of pixels goes down each path, but it can be beneficial if you avoid executing the extra code a lot of the time. While the compiler will sometimes automatically decide to do a real branch, you're best off specifying it yourself as you get extra errors back if if it can't do a branch due to texturing issues (i.e. tex2D vs tex2Dlod).

 

Your best option when optimizing is to use a tool like GPU Shader Analyzer to see what instructions get generated, as well as profiling the performance yourself, because if statement performance depends on the input data.

Share this post


Link to post
Share on other sites

Ok, now I've improved the frame rate a bit, so basically what I do is that I have an individual material for each mesh, (a shader) which can be modified by the user on creation. So this also helped me to escape the fixed shadings. Now the only problem is that I need to write a class that can parse any kind of shader with it's needs, because some shaders needs a specific input and some don't, and the class needs to detect that.

 

And a funny note, whilst doing this I lost some shader data, basically my whole post processing shader, because I closed Visual Studio without undoing, but then I realized that I had a copy here in this forum ohmy.png

Share this post


Link to post
Share on other sites

Did you, or did you not, yet, create a separate shader with just one effect (Bloom) as I proposed above, to check the actual difference in performance ?

 

Easiest way would be to just add  a different shader technique to a same HLSL file. If you are not familiar with techniques, and are not willing to learn them - then just create a separate shader HLSL file with the new shorter pixel shader.

 

Then post the FPS here.

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Now

  • Advertisement
  • Similar Content

    • By AxeGuywithanAxe
      I wanted to see how others are currently handling descriptor heap updates and management.
      I've read a few articles and there tends to be three major strategies :
      1 ) You split up descriptor heaps per shader stage ( i.e one for vertex shader , pixel , hull, etc)
      2) You have one descriptor heap for an entire pipeline
      3) You split up descriptor heaps for update each update frequency (i.e EResourceSet_PerInstance , EResourceSet_PerPass , EResourceSet_PerMaterial, etc)
      The benefits of the first two approaches is that it makes it easier to port current code, and descriptor / resource descriptor management and updating tends to be easier to manage, but it seems to be not as efficient.
      The benefits of the third approach seems to be that it's the most efficient because you only manage and update objects when they change.
    • By evelyn4you
      hi,
      until now i use typical vertexshader approach for skinning with a Constantbuffer containing the transform matrix for the bones and an the vertexbuffer containing bone index and bone weight.
      Now i have implemented realtime environment  probe cubemaping so i have to render my scene from many point of views and the time for skinning takes too long because it is recalculated for every side of the cubemap.
      For Info i am working on Win7 an therefore use one Shadermodel 5.0 not 5.x that have more options, or is there a way to use 5.x in Win 7
      My Graphic Card is Directx 12 compatible NVidia GTX 960
      the member turanszkij has posted a good for me understandable compute shader. ( for Info: in his engine he uses an optimized version of it )
      https://turanszkij.wordpress.com/2017/09/09/skinning-in-compute-shader/
      Now my questions
       is it possible to feed the compute shader with my orignial vertexbuffer or do i have to copy it in several ByteAdressBuffers as implemented in the following code ?
        the same question is about the constant buffer of the matrixes
       my more urgent question is how do i feed my normal pipeline with the result of the compute Shader which are 2 RWByteAddressBuffers that contain position an normal
      for example i could use 2 vertexbuffer bindings
      1 containing only the uv coordinates
      2.containing position and normal
      How do i copy from the RWByteAddressBuffers to the vertexbuffer ?
       
      (Code from turanszkij )
      Here is my shader implementation for skinning a mesh in a compute shader:
      1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 struct Bone { float4x4 pose; }; StructuredBuffer<Bone> boneBuffer;   ByteAddressBuffer vertexBuffer_POS; // T-Pose pos ByteAddressBuffer vertexBuffer_NOR; // T-Pose normal ByteAddressBuffer vertexBuffer_WEI; // bone weights ByteAddressBuffer vertexBuffer_BON; // bone indices   RWByteAddressBuffer streamoutBuffer_POS; // skinned pos RWByteAddressBuffer streamoutBuffer_NOR; // skinned normal RWByteAddressBuffer streamoutBuffer_PRE; // previous frame skinned pos   inline void Skinning(inout float4 pos, inout float4 nor, in float4 inBon, in float4 inWei) {  float4 p = 0, pp = 0;  float3 n = 0;  float4x4 m;  float3x3 m3;  float weisum = 0;   // force loop to reduce register pressure  // though this way we can not interleave TEX - ALU operations  [loop]  for (uint i = 0; ((i &lt; 4) &amp;&amp; (weisum&lt;1.0f)); ++i)  {  m = boneBuffer[(uint)inBon].pose;  m3 = (float3x3)m;   p += mul(float4(pos.xyz, 1), m)*inWei;  n += mul(nor.xyz, m3)*inWei;   weisum += inWei;  }   bool w = any(inWei);  pos.xyz = w ? p.xyz : pos.xyz;  nor.xyz = w ? n : nor.xyz; }   [numthreads(1024, 1, 1)] void main( uint3 DTid : SV_DispatchThreadID ) {  const uint fetchAddress = DTid.x * 16; // stride is 16 bytes for each vertex buffer now...   uint4 pos_u = vertexBuffer_POS.Load4(fetchAddress);  uint4 nor_u = vertexBuffer_NOR.Load4(fetchAddress);  uint4 wei_u = vertexBuffer_WEI.Load4(fetchAddress);  uint4 bon_u = vertexBuffer_BON.Load4(fetchAddress);   float4 pos = asfloat(pos_u);  float4 nor = asfloat(nor_u);  float4 wei = asfloat(wei_u);  float4 bon = asfloat(bon_u);   Skinning(pos, nor, bon, wei);   pos_u = asuint(pos);  nor_u = asuint(nor);   // copy prev frame current pos to current frame prev pos streamoutBuffer_PRE.Store4(fetchAddress, streamoutBuffer_POS.Load4(fetchAddress)); // write out skinned props:  streamoutBuffer_POS.Store4(fetchAddress, pos_u);  streamoutBuffer_NOR.Store4(fetchAddress, nor_u); }  
    • By mister345
      Hi, can someone please explain why this is giving an assertion EyePosition!=0 exception?
       
      _lightBufferVS->viewMatrix = DirectX::XMMatrixLookAtLH(XMLoadFloat3(&_lightBufferVS->position), XMLoadFloat3(&_lookAt), XMLoadFloat3(&up));
      It looks like DirectX doesnt want the 2nd parameter to be a zero vector in the assertion, but I passed in a zero vector with this exact same code in another program and it ran just fine. (Here is the version of the code that worked - note XMLoadFloat3(&m_lookAt) parameter value is (0,0,0) at runtime - I debugged it - but it throws no exceptions.
          m_viewMatrix = DirectX::XMMatrixLookAtLH(XMLoadFloat3(&m_position), XMLoadFloat3(&m_lookAt), XMLoadFloat3(&up)); Here is the repo for the broken code (See LightClass) https://github.com/mister51213/DirectX11Engine/blob/master/DirectX11Engine/LightClass.cpp
      and here is the repo with the alternative version of the code that is working with a value of (0,0,0) for the second parameter.
      https://github.com/mister51213/DX11Port_SoftShadows/blob/master/Engine/lightclass.cpp
    • By mister345
      Hi, can somebody please tell me in clear simple steps how to debug and step through an hlsl shader file?
      I already did Debug > Start Graphics Debugging > then captured some frames from Visual Studio and
      double clicked on the frame to open it, but no idea where to go from there.
       
      I've been searching for hours and there's no information on this, not even on the Microsoft Website!
      They say "open the  Graphics Pixel History window" but there is no such window!
      Then they say, in the "Pipeline Stages choose Start Debugging"  but the Start Debugging option is nowhere to be found in the whole interface.
      Also, how do I even open the hlsl file that I want to set a break point in from inside the Graphics Debugger?
       
      All I want to do is set a break point in a specific hlsl file, step thru it, and see the data, but this is so unbelievably complicated
      and Microsoft's instructions are horrible! Somebody please, please help.
       
       
       

    • By mister345
      I finally ported Rastertek's tutorial # 42 on soft shadows and blur shading. This tutorial has a ton of really useful effects and there's no working version anywhere online.
      Unfortunately it just draws a black screen. Not sure what's causing it. I'm guessing the camera or ortho matrix transforms are wrong, light directions, or maybe texture resources not being properly initialized.  I didnt change any of the variables though, only upgraded all types and functions DirectX3DVector3 to XMFLOAT3, and used DirectXTK for texture loading. If anyone is willing to take a look at what might be causing the black screen, maybe something pops out to you, let me know, thanks.
      https://github.com/mister51213/DX11Port_SoftShadows
       
      Also, for reference, here's tutorial #40 which has normal shadows but no blur, which I also ported, and it works perfectly.
      https://github.com/mister51213/DX11Port_ShadowMapping
       
  • Advertisement