• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
jdub

Issue with HLSL shader code

4 posts in this topic

I have the following relevant HLSL code:

struct VS_INPUT
{
	float4 Position : POSITION;
	float2 TexCoord : TEXCOORD0;
	float3 Normal : NORMAL; //world space normal
};

struct PS_INPUT
{
	float4 Position : SV_POSITION;
	float2 TexCoord : TEXCOORD0;
	float3 Normal : NORMAL; //view-space normal
};

PS_INPUT VShader(VS_INPUT input, uniform bool useLighting, uniform bool isTransformed, uniform bool isTextured) 
{
	PS_INPUT output = (PS_INPUT)0;

	output.Position = input.Position;
	output.Position.w = 1.0f;

	if(isTextured)
	{
		output.TexCoord = input.TexCoord;
	}

	if(!isTransformed)
	{
		output.Position = mul(output.Position, world);
		output.Position = mul(output.Position, view);
		output.Position = mul(output.Position, projection);
	}

	if(useLighting)
	{
		//transform normal to view space
		output.Normal = mul( input.Normal, (float3x3)world );
		normalize( output.Normal );
	}

	return output;
}

float4 PShader(PS_INPUT input, uniform bool useLighting, uniform bool isTextured) : SV_TARGET
{
	float3 intensity;
	float3 light_dir;

	if(useLighting)
	{
		//apply diffuse lighting
		//----------------------
		//Invert the direction of the light vector so that it can be used to compare with Normals
		//Use dot product to decide intensity of light on each triangle
		light_dir = -light_dir;
		intensity = saturate(dot(input.Normal, light_dir));

		return float4(1.0f, 1.0f, 1.0f, 0.5f);
		//return float4(1.0f, saturate(intensity * light_color), 1.0f, 0.5f); 
	}
	if(isTextured)
	{
		float3 color = Texture.Sample(SampleType, input.TexCoord);

		return float4(color.x, color.y, color.z, 0.5f);
	}

	return float4(0.5f, 0.5f, 0.5f, 0.0f);
}

technique11 RenderTextured
{
	pass P0
	{
		SetVertexShader( CompileShader( vs_4_0, VShader(false, false, true) ) );
		SetGeometryShader( NULL );
		SetPixelShader( CompileShader( ps_4_0, PShader(false, true) ) );
	}
}

 

My first question is:  is it a good idea to organize my code like this (with shader code inside if statements inside one big pixel shader and vertex shader) or should I be organizing each different shader effect into it's own set of pixel/vertex shader functions?

 

I have an issue that occurs when I try and run this code inside the Visual Studio Graphics debugger. When I try to debug the vertex shader, the code starts execution inside of the if(isTextured) block skipping the beginning of the code entirely. the value of all data inside the output variable is all NaN until it executes the statement mul(output.Position, world).  The value of world matrix is the translation (1,0,0) of the identity matrix.  After the mul statement is executed, the output data takes the position of the input value.  However w takes the value 0.5f.  This is completely stumping me.  Any ideas?

0

Share this post


Link to post
Share on other sites

One warning from my experience, don't check isTextured like this:

if(isTextured)
...

 

Because HLSL has a weird way of handling uninitialized variables or false.

 

Do it like this:

if (isTextured == 1)
...

 

and in the other cases do this:

if(isTextured == 0) // the same as !isTextured
...
0

Share this post


Link to post
Share on other sites

if(isTextured)
    {
        output.TexCoord = input.TexCoord;
    }

 

 

In my opinion the branch above isn't needed. You'll need to initialize the texcoord anyway so why not just copy the incoming texture coordinate there instead of making a branch.

 

Cheers!

1

Share this post


Link to post
Share on other sites

+1 what kauna said.

Also instead of "isTextured" you could pass white texture and get same result. IMO you are doing premature optimization.

0

Share this post


Link to post
Share on other sites

My first question is: is it a good idea to organize my code like this (with shader code inside if statements inside one big pixel shader and vertex shader) or should I be organizing each different shader effect into it's own set of pixel/vertex shader functions?

That totally depends if you care about performance more than about your productivity.

 

It is, obviously, much easier for you to put everything into one pixel shader and not handle effects/techniques overhead,  but that also means you are totally abusing your poor gfx card [that most ceretainly did not sign up for that].

 

 

If you do, however, care for the performance a bit, then just bite the bullet and do it right.

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0