Sign in to follow this  
Enerjak

OpenGL does this code look ok?

Recommended Posts

Enerjak    277

I'm trying to create an openGL window in my engine and the following code runs.........just not good.....so I was wondering if there's anything wrong with this code:

 

// create OpenGLWindow;
	bool IOpenGLRenderWindow::createWindow(std::string wiName, 
		std::string title, 
		unsigned int width, 
		unsigned int height, 
		bool fullscreen, 
		bool VSync, 
		bool Stencil, 
		unsigned int bits, 
		unsigned int numSamples)
	{
		// set values from class to values in-coming
		m_windowWidth = width;	// set the width;
		m_windowHeight = height;  // set height;
		m_windowName = wiName;	// the window's name;
		m_windowTitle = title;	// the title of the window.
		m_fullScreen = fullscreen; // full screen
		m_VSync = VSync;		   // V-Sync.
		m_Stencil = Stencil;	   // stencil
		m_bits = bits;				// bits
		m_numSamples = numSamples;	// the sample quality;

		WNDCLASSEX winClass;
		ZeroMemory(&winClass,sizeof(winClass));

		winClass.cbSize = sizeof(WNDCLASSEX);
		winClass.style  = CS_HREDRAW | CS_VREDRAW;
		winClass.lpfnWndProc = IWindowUtility::getSingleton()->WinProc;
		winClass.hInstance =  GetModuleHandle(NULL);
		winClass.hCursor   = LoadCursor(NULL,IDC_ARROW);
		winClass.hIcon	   = LoadIcon(NULL,IDI_APPLICATION);
		winClass.lpszClassName = this->m_windowName.c_str();

		if(!RegisterClassEx(&winClass))
		{
			IDebuggingUtility::operatingSystemBug("OpenGLRenderWindow::CreateWindow");	
		}

		// styles needed.
		DWORD dwStyle;		// regular style
		DWORD dwExStyle;	// extra style.
		// set the window rect.
		RECT winRect;
		winRect.left = 0;					// left region
		winRect.top = 0;					// top
		winRect.right = m_windowWidth;// right
		winRect.bottom = m_windowHeight;    // bottom.

		// check if full screen.
		if(m_fullScreen)
		{
			DEVMODE devMode;
			ZeroMemory(&devMode, sizeof(DEVMODE));

			devMode.dmSize = sizeof(DEVMODE);
			devMode.dmBitsPerPel    = m_bits;
			devMode.dmPanningWidth  = m_windowWidth;
			devMode.dmPanningHeight = m_windowHeight;
			devMode.dmFields		= DM_BITSPERPEL | DM_PANNINGWIDTH | DM_PANNINGHEIGHT; 

			// check if full screen.
			if(ChangeDisplaySettings(&devMode, CDS_FULLSCREEN) != DISP_CHANGE_SUCCESSFUL)
			{
				m_fullScreen = false;
				IDebuggingUtility::operatingSystemBug("ChangeDisplayMode");
				
			}

			dwStyle = WS_POPUP;
			dwExStyle = WS_EX_APPWINDOW;
			ShowCursor(false);
		}
		else
		{
			dwStyle = WS_OVERLAPPEDWINDOW;
			dwExStyle = WS_EX_APPWINDOW | WS_EX_WINDOWEDGE;
			ShowCursor(true);
		}

		AdjustWindowRectEx(&winRect, dwStyle,NULL,dwExStyle);

		// create the window
		m_windowHandle = CreateWindowEx(dwExStyle,
			this->m_windowName.c_str(),
			this->m_windowTitle.c_str(),
			dwStyle,
			0,
			0,
			winRect.right - winRect.left,
			winRect.bottom - winRect.top,
			NULL,
			NULL,
			GetModuleHandle(NULL),
			NULL);

		if(m_windowHandle)
		{
			ShowWindow(m_windowHandle,SW_SHOW);
			UpdateWindow(m_windowHandle);
		}
		else
		{
			
			IDebuggingUtility::operatingSystemBug("CreateWindowEx");
		}

		// get Device context
		this->m_deviceContext = GetDC(m_windowHandle);
		
		// check if device gotten
		if(m_deviceContext == NULL)
		{
			IDebuggingUtility::operatingSystemBug("GetDC");
			const char* error = (char*)gluErrorString(glGetError());
			string err = "The device Context is NULL.";
			err += error;
			throw IException(ET_APIERROR,err,"GetDC");
		}

		// set pixel information
		ZeroMemory(&this->m_pPixelDesc,sizeof(m_pPixelDesc));

		m_pPixelDesc.nSize = sizeof(m_pPixelDesc);
		m_pPixelDesc.nVersion = 1;
		m_pPixelDesc.dwFlags = PFD_DRAW_TO_WINDOW | PFD_SUPPORT_OPENGL| PFD_DOUBLEBUFFER;
		m_pPixelDesc.iPixelType = PFD_TYPE_RGBA;
		m_pPixelDesc.cColorBits = m_bits;
		
		if(m_Stencil)
		{
			m_pPixelDesc.cStencilBits = 8;
			m_pPixelDesc.cDepthBits = 24;
		}
		else
		{
			m_pPixelDesc.cStencilBits = 0;
			m_pPixelDesc.cDepthBits = 24;
		}
		m_pPixelDesc.iLayerType = PFD_MAIN_PLANE;
		int pixelFormat = 0;

		pixelFormat = ChoosePixelFormat(m_deviceContext,&m_pPixelDesc);
		if(!pixelFormat)
		{
			IDebuggingUtility::operatingSystemBug("ChoosePixelFormat");
			const char* error = (char*)gluErrorString(glGetError());
			string err = "Pixel format not working....... ";
			err += error;
			throw IException(ET_APIERROR, err,"ChoosePixelFormat");
		}

		// set the pixel format
		if(!SetPixelFormat(m_deviceContext,pixelFormat,&m_pPixelDesc))
		{
			IDebuggingUtility::operatingSystemBug("SetPixelFormat");
			const char* error = (char*)gluErrorString(glGetError());
			string err = "Pixel Format cannot be set: ";
			err += error;
			string func = "SetPixelFormat";
			throw IException(ET_APIERROR, err,func);
		}

		// create the device context
		this->m_GLRC = ::wglCreateContext(m_deviceContext);

		if(m_GLRC == NULL)
		{
			IDebuggingUtility::operatingSystemBug("wglCreateContext");
			const char* error = (char*)gluErrorString(glGetError());
			string err = "Context creation failed: ";
			err += error;
			string func = "wlgCreateContext";
			throw IException(ET_APIERROR,err,func);
		}
		if(m_GLRC != GLEW_OK)
		{
			const char* error = (char*)gluErrorString(glGetError());
			
			throw IException(ET_APIERROR, string(error),"Device Context");
		}

		// set the current device context
		wglMakeCurrent(this->m_deviceContext, m_GLRC);

		GLenum glew = glewInit();

		if(glew != GLEW_OK)
		{
			const char* error = (char*)gluErrorString(glew);
			string err = "glew not initialized ";
			err += error;
			throw IException(ET_APIERROR, err,"Cannot initalize glew");
		}

		int attributes[] = 
		{
			WGL_CONTEXT_MINOR_VERSION_ARB, 4,
			WGL_CONTEXT_MAJOR_VERSION_ARB, 1,
			WGL_CONTEXT_FLAGS_ARB, WGL_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB,
			0
		};

		if(wglewIsSupported("WGL_ARB_Create_Context") == 1)
		{
			this->m_GLRC = ::wglCreateContextAttribsARB(this->m_deviceContext, NULL, attributes);
			wglMakeCurrent(NULL,NULL);
			wglDeleteContext(m_GLRC);
			wglMakeCurrent(m_deviceContext, m_GLRC);
		}
		else
		{
			const char* error = (char*)gluErrorString(glew);
			string err = "WGL_ARG_Create_Context is flawed. ";
			err += error;

			throw IException(ET_APIERROR,err,"Error in WGL_ARG");
		}
		return IRenderWindow::createWindow(this->m_windowName,
										   m_windowTitle,
										   m_windowWidth,
										   m_windowHeight,
										   this->m_fullScreen,
										   this->m_VSync,
										   this->m_Stencil,
										   this->m_bits,
										   this->m_numSamples);
		}

		void IOpenGLRenderWindow::_setClearColor(BYTE alpha, BYTE red, BYTE green, BYTE blue)
		{
			if(m_deviceContext)
			{
				glClearColor(red,green,blue,alpha);
			}
			IRenderWindow::_setClearColor(alpha, red, green, blue);
		}

		void IOpenGLRenderWindow::_renderStart()
		{
			glClear(GL_COLOR_BUFFER_BIT);
		}

		void IOpenGLRenderWindow::_renderEnd()
		{
			bool isOK = SwapBuffers(m_deviceContext);

			if(!isOK)
			{
				IDebuggingUtility::operatingSystemBug("IOpenGLRenderWindow::_renderEnd");
			}
		}

 

seems ok to me, maybe i didn't initialize the pixel format good?

 

Share this post


Link to post
Share on other sites
Enerjak    277

What does "runs.........just not good" mean?

Right, should of posted a screenie........lol

 

http://puu.sh/2TWb2.jpg

basically, I don't know WHY its giving me that........I suppose It could be many many things using a console rather then a win32 project? Doubt it.

Share this post


Link to post
Share on other sites
Brother Bob    10344

Use the debugger to determine where the error message is generated and under what conditions you'll get there, then figure out why it got there.

 

But you may not even have to use a debugger in this case, but rather just read the message and locate the corresponding message in the code: there's only one place in the code you posted where any string from the error window is present. If there is an error window with the title "Device Context" and the message "invalid operation", then these strings must come from somewhere.

Share this post


Link to post
Share on other sites
Ben Bowen    115

I love it how the screen shot has nothing to do with this topic, or even the code. hahaha the Window title says Direct11 and all they needed to tell us was "invalid operation"

You have the anti-virus update reminder shit overlapping the screenshot and ... both IE and Firefox in your task bar ...

 

Just hilarious.

Edited by Reflexus

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By Kjell Andersson
      I'm trying to get some legacy OpenGL code to run with a shader pipeline,
      The legacy code uses glVertexPointer(), glColorPointer(), glNormalPointer() and glTexCoordPointer() to supply the vertex information.
      I know that it should be using setVertexAttribPointer() etc to clearly define the layout but that is not an option right now since the legacy code can't be modified to that extent.
      I've got a version 330 vertex shader to somewhat work:
      #version 330 uniform mat4 osg_ModelViewProjectionMatrix; uniform mat4 osg_ModelViewMatrix; layout(location = 0) in vec4 Vertex; layout(location = 2) in vec4 Normal; // Velocity layout(location = 3) in vec3 TexCoord; // TODO: is this the right layout location? out VertexData { vec4 color; vec3 velocity; float size; } VertexOut; void main(void) { vec4 p0 = Vertex; vec4 p1 = Vertex + vec4(Normal.x, Normal.y, Normal.z, 0.0f); vec3 velocity = (osg_ModelViewProjectionMatrix * p1 - osg_ModelViewProjectionMatrix * p0).xyz; VertexOut.velocity = velocity; VertexOut.size = TexCoord.y; gl_Position = osg_ModelViewMatrix * Vertex; } What works is the Vertex and Normal information that the legacy C++ OpenGL code seem to provide in layout location 0 and 2. This is fine.
      What I'm not getting to work is the TexCoord information that is supplied by a glTexCoordPointer() call in C++.
      Question:
      What layout location is the old standard pipeline using for glTexCoordPointer()? Or is this undefined?
       
      Side note: I'm trying to get an OpenSceneGraph 3.4.0 particle system to use custom vertex, geometry and fragment shaders for rendering the particles.
    • By markshaw001
      Hi i am new to this forum  i wanted to ask for help from all of you i want to generate real time terrain using a 32 bit heightmap i am good at c++ and have started learning Opengl as i am very interested in making landscapes in opengl i have looked around the internet for help about this topic but i am not getting the hang of the concepts and what they are doing can some here suggests me some good resources for making terrain engine please for example like tutorials,books etc so that i can understand the whole concept of terrain generation.
       
    • By KarimIO
      Hey guys. I'm trying to get my application to work on my Nvidia GTX 970 desktop. It currently works on my Intel HD 3000 laptop, but on the desktop, every bind textures specifically from framebuffers, I get half a second of lag. This is done 4 times as I have three RGBA textures and one depth 32F buffer. I tried to use debugging software for the first time - RenderDoc only shows SwapBuffers() and no OGL calls, while Nvidia Nsight crashes upon execution, so neither are helpful. Without binding it runs regularly. This does not happen with non-framebuffer binds.
      GLFramebuffer::GLFramebuffer(FramebufferCreateInfo createInfo) { glGenFramebuffers(1, &fbo); glBindFramebuffer(GL_FRAMEBUFFER, fbo); textures = new GLuint[createInfo.numColorTargets]; glGenTextures(createInfo.numColorTargets, textures); GLenum *DrawBuffers = new GLenum[createInfo.numColorTargets]; for (uint32_t i = 0; i < createInfo.numColorTargets; i++) { glBindTexture(GL_TEXTURE_2D, textures[i]); GLint internalFormat; GLenum format; TranslateFormats(createInfo.colorFormats[i], format, internalFormat); // returns GL_RGBA and GL_RGBA glTexImage2D(GL_TEXTURE_2D, 0, internalFormat, createInfo.width, createInfo.height, 0, format, GL_FLOAT, 0); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); DrawBuffers[i] = GL_COLOR_ATTACHMENT0 + i; glBindTexture(GL_TEXTURE_2D, 0); glFramebufferTexture(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0 + i, textures[i], 0); } if (createInfo.depthFormat != FORMAT_DEPTH_NONE) { GLenum depthFormat; switch (createInfo.depthFormat) { case FORMAT_DEPTH_16: depthFormat = GL_DEPTH_COMPONENT16; break; case FORMAT_DEPTH_24: depthFormat = GL_DEPTH_COMPONENT24; break; case FORMAT_DEPTH_32: depthFormat = GL_DEPTH_COMPONENT32; break; case FORMAT_DEPTH_24_STENCIL_8: depthFormat = GL_DEPTH24_STENCIL8; break; case FORMAT_DEPTH_32_STENCIL_8: depthFormat = GL_DEPTH32F_STENCIL8; break; } glGenTextures(1, &depthrenderbuffer); glBindTexture(GL_TEXTURE_2D, depthrenderbuffer); glTexImage2D(GL_TEXTURE_2D, 0, depthFormat, createInfo.width, createInfo.height, 0, GL_DEPTH_COMPONENT, GL_FLOAT, 0); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glBindTexture(GL_TEXTURE_2D, 0); glFramebufferTexture(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, depthrenderbuffer, 0); } if (createInfo.numColorTargets > 0) glDrawBuffers(createInfo.numColorTargets, DrawBuffers); else glDrawBuffer(GL_NONE); if (glCheckFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE) std::cout << "Framebuffer Incomplete\n"; glBindFramebuffer(GL_FRAMEBUFFER, 0); width = createInfo.width; height = createInfo.height; } // ... // FBO Creation FramebufferCreateInfo gbufferCI; gbufferCI.colorFormats = gbufferCFs.data(); gbufferCI.depthFormat = FORMAT_DEPTH_32; gbufferCI.numColorTargets = gbufferCFs.size(); gbufferCI.width = engine.settings.resolutionX; gbufferCI.height = engine.settings.resolutionY; gbufferCI.renderPass = nullptr; gbuffer = graphicsWrapper->CreateFramebuffer(gbufferCI); // Bind glBindFramebuffer(GL_DRAW_FRAMEBUFFER, fbo); // Draw here... // Bind to textures glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, textures[0]); glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, textures[1]); glActiveTexture(GL_TEXTURE2); glBindTexture(GL_TEXTURE_2D, textures[2]); glActiveTexture(GL_TEXTURE3); glBindTexture(GL_TEXTURE_2D, depthrenderbuffer); Here is an extract of my code. I can't think of anything else to include. I've really been butting my head into a wall trying to think of a reason but I can think of none and all my research yields nothing. Thanks in advance!
    • By Adrianensis
      Hi everyone, I've shared my 2D Game Engine source code. It's the result of 4 years working on it (and I still continue improving features ) and I want to share with the community. You can see some videos on youtube and some demo gifs on my twitter account.
      This Engine has been developed as End-of-Degree Project and it is coded in Javascript, WebGL and GLSL. The engine is written from scratch.
      This is not a professional engine but it's for learning purposes, so anyone can review the code an learn basis about graphics, physics or game engine architecture. Source code on this GitHub repository.
      I'm available for a good conversation about Game Engine / Graphics Programming
    • By C0dR
      I would like to introduce the first version of my physically based camera rendering library, written in C++, called PhysiCam.
      Physicam is an open source OpenGL C++ library, which provides physically based camera rendering and parameters. It is based on OpenGL and designed to be used as either static library or dynamic library and can be integrated in existing applications.
       
      The following features are implemented:
      Physically based sensor and focal length calculation Autoexposure Manual exposure Lense distortion Bloom (influenced by ISO, Shutter Speed, Sensor type etc.) Bokeh (influenced by Aperture, Sensor type and focal length) Tonemapping  
      You can find the repository at https://github.com/0x2A/physicam
       
      I would be happy about feedback, suggestions or contributions.

  • Popular Now