• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
lipsryme

Problem with Color Correction and 3D LUT

12 posts in this topic

I'm having some issues with color correction using a 3D LUT.

I'm using a neutral LUT 16x16x16 from the UnrealEngine page here: http://udn.epicgames.com/Three/rsrc/Three/ColorGrading/RGBTable16x1.png

 

I've open it up in photoshop and saved it as a Volume Texture DDS (32bpp unsigned ARGB8) using the nvidia plugin.

 

And here's my shader:

float4 PS(in VSOutput input) : SV_Target
{
	float3 rawColor = InputTexture0.Sample(LinearClampSampler, input.UV).rgb;

	float3 scale = (float3(16, 16, 16) - 1.0f) / float3(16, 16, 16);
	float3 offset = 1.0f / (2.0f - float3(16, 16, 16));

	float3 colorCorrected = LUT.Sample(LinearClampSampler, scale * rawColor + offset).rgb;
	
	return float4(colorCorrected, 1.0f);
}

The code is from this sample here: http://http.developer.nvidia.com/GPUGems2/gpugems2_chapter24.html

Can someone spot the problem ? : /

 

Not sure if the problem has to do with the order of rendering.

I'm currently tonemapping my linear result to a R8G8B8A8_UNORM_SRGB target, then use this as the input for the color correction which then outputs to my R8G8B8A8_UNORM_SRGB backbuffer.

 

Here's a screen of what my result looks like:

http://d.pr/i/xGYR

 

And here's the original for comparison:

http://d.pr/i/I6SL

Edited by lipsryme
0

Share this post


Link to post
Share on other sites
float3 Scale = (16.0f - 1.0f) / 16.0f; //volume texture size
float3 Offset = 1.0f / (2.0f * 16.0f);
 
 
Here's my code for the scale and offset calculations. Seems that your offset has a slight error.
 
Cheers!
1

Share this post


Link to post
Share on other sites

You are probably sampling off the pixel center? Either use point sampling or load instruction or correct your sampling position.

 

Cheers!

0

Share this post


Link to post
Share on other sites

I'm using DX11 so I it shouldn't...

When using point sampling it looks horrible with a lot of banding artifacts (also doesn't fix the pixel borders):

http://d.pr/i/4dP7

 

How would I need to correct it to work ?

Edited by lipsryme
0

Share this post


Link to post
Share on other sites

That's really strange ... It should work with point sampling too, and it shouldn't produce any banding artifacts.

 

Are you using MSAA ?

 

Cheers!

0

Share this post


Link to post
Share on other sites

I'm not...
Do you suppose this is related to gamma correction issues? I just don't see what could possibly wrong. I'm using the output of my tonemapping as the input scene which is in regular 32 bit unsigned format and being output to an srgb target after being linear.

 

update: Gamma correction does not seem to be the problem. I've tried using regular R8G8B8A8_UNORM for both outputs. Besides being in the wrong color space the border issue was still there. Maybe it's the LUT texture ?

 

update2: I just tried making it the only post effect in my chain, and I've tried using regular LDR for shading. The pixel border still appears. This has to be either an issue with the input texture or the sampling process..

If I just output rawColor inside the color correction shader I get the perfect original scene. But using the LUT I get the border.

It looks almost like an edge highlighting. Using LinearWrap makes it even more apparent.

Edited by lipsryme
0

Share this post


Link to post
Share on other sites

Only difference I can see between your and my implementation that I use SampleLevel(s_linear,Color,0) to sample the volume texture, so that mip maps won't affect the output.

 

[edit]Are you able to use "load" instruction? It should be equivalent to point sampling, although you'll index the texture instead of using texture coordinates.

 

Cheers!

Edited by kauna
1

Share this post


Link to post
Share on other sites

That was it ! Amazing how a mipmap could screw this up...

Thanks so much smile.png

Edited by lipsryme
0

Share this post


Link to post
Share on other sites

Glad to be able to help. I was fighting the same code (with different issues though) last week.

 

Cheers!

0

Share this post


Link to post
Share on other sites

Curious, something to do with gamma correction somewhere? Is your volume texture format defined as _SRGB or not? 

 

Cheers!

0

Share this post


Link to post
Share on other sites

It's not I'm doing gamma conversion in shader during lookups.

Though sampling it as linear makes it too dark.

 

Edit: Is there an order I have to maintain when I apply the color transforms in photoshop ?

Edited by lipsryme
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0