Jump to content
  • Advertisement
Sign in to follow this  
Sky Warden

How can I avoid circular dependency?

This topic is 1936 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I often meet a condition in programming where I have a class which takes an instance of another class and makes use of some functions in that imported class, while that class also needs some functions in the first class.

 

Like class A has function x() and y(), and class B has function i() and j(). Class A needs to use function i() in class B, and function j() in class B needs to use function y() in class A.

 

How can I reduce this to minimum? Is there any better way to do this? For some reasons, function y is only available in class A.

 

Oh, almost forgot this question. How can I do this the right way?

 

Thank you everyone.

Edited by Sky Warden

Share this post


Link to post
Share on other sites
Advertisement

Well my first thought is that since the two classes seem to need each other so closely - and are apparently unable to function without each other - surely they should be merged somehow? In most designs classes do not interact mutually but only in one direction, but I suppose there are situations where you can end up with circular dependencies.

 

What is your exact situation?

Share this post


Link to post
Share on other sites

Well my first thought is that since the two classes seem to need each other so closely - and are apparently unable to function without each other - surely they should be merged somehow? In most designs classes do not interact mutually but only in one direction, but I suppose there are situations where you can end up with circular dependencies.

 

What is your exact situation?

Thanks for the reply, Bacterius.

 

So there's a protocol class which has a function to write data to the socket. This protocol class needs a function from another class and it sends some data to the said class. Still in one direction, right. Then this another class has a function which process the data sent by the protocol, and after processing the data it needs to write data to the socket. This is where things go circular.

Share this post


Link to post
Share on other sites

I don't really got you point. As @Bacterius said, you can easily merge A and B.
Another way, you can define a pure virtual base class X which has function x(), y(), i(), j(). So that A or B inherit from X, so they can used them without any trouble. all right?

Share this post


Link to post
Share on other sites

I don't really got you point. As @Bacterius said, you can easily merge A and B.
Another way, you can define a pure virtual base class X which has function x(), y(), i(), j(). So that A or B inherit from X, so they can used them without any trouble. all right?

How about I make a subclass of the protocol class so I can inherit the write function? Is it a bad idea? Merging both function may make some of my things to work nastily, so I won't do that unless I can find another way.

Share this post


Link to post
Share on other sites

According to your situation, why do you seperate those function base on their responsibility. I would like to define the protocolClass as a virtual class so that it could provide a processData() method, it no need to worry about the write and send function. SocketBuffer will take care of that. 

class ProtocolClass{

  SocketBuffer processData() =0;  // process the data by the protocol

}

 

//SocketBuffer defines thoes write and read functions.

class SocketBuffer{

   void send(SocketBuffer *said) = 0;

    void write(SocketBuffer *target) = 0;

}

 

class testClass: public ProtocolClass, public SocketBuffer{

    // to-do

 

}

 

does it meet your need?

Share this post


Link to post
Share on other sites

According to your situation, why do you seperate those function base on their responsibility. I would like to define the protocolClass as a virtual class so that it could provide a processData() method, it no need to worry about the write and send function. SocketBuffer will take care of that.

 

Actually I've solved this by subclass-ing the protocol class. The subclass inherits all of the functions the protocol class provides, and I can define the service specific functions in that subclass to make everything neat and stuff. :lol:

Share this post


Link to post
Share on other sites
Why not have the other class return the data it wants to send to the socket. Then your protocol class can do its job and send it to the socket without the other class know how its being sent?

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

We are the game development community.

Whether you are an indie, hobbyist, AAA developer, or just trying to learn, GameDev.net is the place for you to learn, share, and connect with the games industry. Learn more About Us or sign up!

Sign me up!