• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
MindOfCorruption97

Bullets won't shoot up or down

8 posts in this topic

Hey, I have a problem.
You see, for some reason, I am not able to shoot up or down. After a few hours looking I couldn't seem to find the error to this issue. So can anyone help me point out what is causing the bullets not go up nor down.

 

Player.h

#ifndef PLAYER_H
#define	PLAYER_H

#include <GL/glfw.h>
#include <vector>

#include "tools.h"

using namespace std;

class Bullet;

class Player{
public:
    void init();
    void draw();
    void update();
    
    void keyListener();
    void mouseMotionListener();
    void mouseClickListener();
    
    void setVx(int Vx){intVx = Vx;}
    void setVy(int Vy){intVy = Vy;}
    void velocity();
    void shoot(int intDir);
    
    void nothing(){}
    
    Rectangle getPlayer(){return rectPlayer;}
    Point getMotion(){return ptMotion;}
    Point getClick(){return ptClick;}
private:
    int intX,intY,intVx,intVy,intWidth,intHeight;
    bool blInitiated;
    
    vector<Bullet> vectBullet;
    
    Rectangle rectPlayer;
    Point ptMotion,ptClick;
};

class Bullet{
public:
    Bullet(int X,int Y);
    ~Bullet();
    
    void draw();
    void update();
    
    void setVx(int Vx){intVx = Vx;}
    void setVy(int Vy){intVy = Vy;}
    void velocity();
    
    Rectangle getBullet(){return rectBullet;}
private:
    int intX,intY,intVx,intVy;
    
    Rectangle rectBullet;
};

#endif

Player.cpp

#include "Player.h"

void Player::init(){
    blInitiated = false;
    
    intX = 0;
    intY = 0;
    intWidth = 50;
    intHeight = 50;
    
    rectPlayer = createRectangle(intX,intY,intWidth,intHeight);
    
    blInitiated = true;
}
void Player::draw(){
    glColor3f(0.0,0.0,255.0);
    drawRectangle(rectPlayer.intX,rectPlayer.intY,rectPlayer.intWidth,rectPlayer.intHeight);
    
    for(int i = 0;i < vectBullet.size();i++){
        vectBullet.at(i).draw();
    }
}
void Player::update(){
    if(!blInitiated){init();}else{nothing();}
    
    rectPlayer.intX = intX;
    rectPlayer.intY = intY;
    rectPlayer.intWidth = intWidth;
    rectPlayer.intHeight = intHeight;
    
    velocity();
    
    for(int i = 0;i < vectBullet.size();i++){
        vectBullet.at(i).update();
    }
}

void Player::velocity(){
    intX += intVx;
    intY += intVy;
}
void Player::shoot(int intDir){
    vectBullet.push_back(Bullet(intX + 23,intY + 23));
    if(intDir == 1){vectBullet.back().setVy(-10);}
    else if(intDir == 2){vectBullet.back().setVy(-10);}
    if(intDir == 3){vectBullet.back().setVx(-10);}
    else if(intDir == 4){vectBullet.back().setVx(+10);}
}

void Player::keyListener(){
    if(glfwGetKey('A') == GLFW_PRESS){setVx(-3);}
    else if(glfwGetKey('D') == GLFW_PRESS){setVx(+3);}
    else{setVx(0);}
    if(glfwGetKey('W') == GLFW_PRESS){setVy(-3);}
    else if(glfwGetKey('S') == GLFW_PRESS){setVy(+3);}
    else{setVy(0);}
    
    if(glfwGetKey(GLFW_KEY_UP) == GLFW_PRESS){shoot(1);}
    else if(glfwGetKey(GLFW_KEY_DOWN) == GLFW_PRESS){shoot(2);}
    else if(glfwGetKey(GLFW_KEY_LEFT) == GLFW_PRESS){shoot(3);}
    else if(glfwGetKey(GLFW_KEY_RIGHT) == GLFW_PRESS){shoot(4);}
}
void Player::mouseMotionListener(){glfwGetMousePos(&ptMotion.intX,&ptMotion.intY);}
void Player::mouseClickListener(){
    if(glfwGetMouseButton(GLFW_MOUSE_BUTTON_LEFT) == GLFW_PRESS){
        glfwGetMousePos(&ptClick.intX,&ptClick.intY);
    }
}

//||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
//||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
//||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||

Bullet::Bullet(int X, int Y){
    intX = X;
    intY = Y;
    rectBullet = createRectangle(intX,intY,4,4);
}
Bullet::~Bullet(){}

void Bullet::draw(){
    glColor3f(0.0,0.0,255.0);
    drawRectangle(rectBullet.intX,rectBullet.intY,rectBullet.intWidth,rectBullet.intHeight);
}
void Bullet::update(){
    
    rectBullet.intX = intX;
    rectBullet.intY = intY;
    
    velocity();
}

void Bullet::velocity(){
    intX += intVx;
    intY += intVy;
}

It's just Vy(velocity of Y) won't set. I tried replacing "setVy" with "setVx" so I know the keyboard isn't the problem. It's something to do with setVy but I don't know what.

PS. I tested it out and I know the problem is somewhere in the "shoot()".

0

Share this post


Link to post
Share on other sites

First of all:

if(intDir == 1){vectBullet.back().setVy(-10);}
else if(intDir == 2){vectBullet.back().setVy(-10);}

I don't think this will result in the shoot going in opposite ways.

0

Share this post


Link to post
Share on other sites

First of all:

if(intDir == 1){vectBullet.back().setVy(-10);}
else if(intDir == 2){vectBullet.back().setVy(-10);}

I don't think this will result in the shoot going in opposite ways.

Sorry, minor mistake. But the bullets still won't shoot on the Y axis. Is there anything else wrong witht the code?

0

Share this post


Link to post
Share on other sites
Take a look in your keylistener and shoot functions for player. Change the else ifs to just ifs, because what is happening there is that if you press right and then press and hold down, it will not shoot down as well because of the else clause.
0

Share this post


Link to post
Share on other sites
I'm guessing that your IntX, IntY, IntVx, and IntVY are all getting affected by the Player code, you have no distinction since you created a Bullet Constructor in the Player code but no Player Constructor. You intiialize an IntX and IntY in the Bullet constructor and what should be a Player IntX and IntY in the initialize event. I suggest splitting the Bullet class out to it own file and reference the Bullet object in your player code.
0

Share this post


Link to post
Share on other sites

The debugger is your best friend here. Step through your shoot and update code and check that they are actually being called and the variables have the expected values and are getting updated as expected. That should tell you where things are going wrong.

2

Share this post


Link to post
Share on other sites

Take a look in your keylistener and shoot functions for player. Change the else ifs to just ifs, because what is happening there is that if you press right and then press and hold down, it will not shoot down as well because of the else clause.

I tried that but it seems like the keyboard is not the issue. When I replace the setVy with setVx the program responds to the keyboard input. But if I replace it back then it won't respond with the setVy. Basically something is wrong with the methods/variable itself not the keyboard.

0

Share this post


Link to post
Share on other sites

Yeah, I was gonna post something to that effect, but I thought it might be pedantic after you'd already said it. I can't tell if he's in 'that phase' or if he just missed your first comment.

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0