• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
polyfrag

Copy constructor not being called?

3 posts in this topic

I have a base class BrushSide with a vertex array member m_va that has a copy constructor.

class BrushSide
{
public:
	Plane m_plane;
	VertexArray m_va;
	unsigned int m_texture;
	
	BrushSide(const BrushSide& original);
	BrushSide(){}
	virtual ~BrushSide(){}
	virtual void usetex();
};
class VertexArray
{
public:
	int numverts;
	Vec3f* vertices;
	Vec2f* texcoords;
	Vec3f* normals;

	VertexArray(const VertexArray& original);
	VertexArray()
	{
		numverts = 0;
	}

	~VertexArray()
	{
		free();
	}

	void alloc(int numv);
	void free();
};

VertexArray::VertexArray(const VertexArray& original)
{
	g_log<<"vertex array copy constructor"<<endl;

	alloc(original.numverts);
	memcpy(vertices, original.vertices, sizeof(Vec3f)*numverts);
	memcpy(texcoords, original.texcoords, sizeof(Vec2f)*numverts);
	memcpy(normals, original.normals, sizeof(Vec3f)*numverts);
}

I have a derived class EdBrushSide with a copy constructor that gets called.

class EdBrushSide : public BrushSide
{
public:
	int m_ntris;
	Triangle2* m_tris;
	Plane m_tceq[2];	//tex coord uv equations

	EdBrushSide(const EdBrushSide& original);
	EdBrushSide();
	EdBrushSide(Vec3f normal, Vec3f point);
	~EdBrushSide();
	void makeva();
	void usetex();
};

EdBrushSide::EdBrushSide(const EdBrushSide& original)
{
	g_log<<"edbrushside copy constructor"<<endl;

	m_plane = original.m_plane;
	m_texture = original.m_texture;
	m_va = original.m_va;

	m_ntris = original.m_ntris;
	m_tceq[0] = original.m_tceq[0];
	m_tceq[1] = original.m_tceq[1];
	m_tris = new Triangle2[m_ntris];
	//memcpy(m_tris, original.m_tris, sizeof(Triangle2)*m_ntris);
	for(int i=0; i<m_ntris; i++)
		m_tris[i] = original.m_tris[i];
}

I see "edbrushside copy constructor" in the log but no "vertex array copy constructor". What's wrong?

 

And before I was doing this, which I think is a better way of doing it, but still wasn't working,

BrushSide::BrushSide(const BrushSide& original) : m_va(original.m_va)
{
	m_plane = original.m_plane;
	m_texture = original.m_texture;
}

EdBrushSide::EdBrushSide(const EdBrushSide& original) : BrushSide(original)
{
	g_log<<"edbrushside copy constructor"<<endl;

	m_ntris = original.m_ntris;
	m_tceq[0] = original.m_tceq[0];
	m_tceq[1] = original.m_tceq[1];
	m_tris = new Triangle2[m_ntris];
	//memcpy(m_tris, original.m_tris, sizeof(Triangle2)*m_ntris);
	for(int i=0; i<m_ntris; i++)
		m_tris[i] = original.m_tris[i];
}
0

Share this post


Link to post
Share on other sites

The copy constructor for VertexArray wouldn't be invoked in the first bit of code you posted; just the assignment operator.

 

In the second bit of code it should though. You said that code "still wasn't working" - what exactly do you mean?

 

btw, your code should probably follow the rule of three.

Edited by phil_t
2

Share this post


Link to post
Share on other sites

 

 

You said that code "still wasn't working" - what exactly do you mean?

 

Never mind, you solved my problem. I'm debugging a deleted memory reference bug and that was really what wasn't working.

0

Share this post


Link to post
Share on other sites

For an STL list push_back should I be editting the copy constructor or assignment operator?

 

[edit] Never mind, assignment operator.

Edited by polyfrag
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0