Jump to content
  • Advertisement
Sign in to follow this  
ArmsOfSorrow

Code review - Tetris clone

This topic is 2139 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

First of all, hello gamedev.net community,

 

I just signed up here to get some general advice regarding programming questions and since I'm just a beginner, there are many things I can learn from more experienced programmers around here. I've recently coded a tetris clone and while it is functional, the code design is far from being good. That's why I would like to hear some suggestions on what I could have done better/more efficiently/with less cluttered code/etc..

 

I'm not quite sure, whether I should just put the code into this post; if so, I'll edit it later, but for now I have uploaded the project to my Skydrive. Here's the link: http://sdrv.ms/1dM0h1Q

 

Feel free to point out things, just don't be too harsh on me, even though I know the code is not very good. I'm looking forward to reading your comments.

Edited by ArmsOfSorrow

Share this post


Link to post
Share on other sites
Advertisement

The project files don't actually contain the source code for the game.  You need to post the header and cpp files to show everyone the sources.

Share this post


Link to post
Share on other sites

I've corrected my post since the wording might have been a bit misleading; I'm aware that VS project files do not contain source code. It's not the project files on my Skydrive, it's the whole project folder containing all source files.

Share this post


Link to post
Share on other sites

I am tu busy to read and comment but I can say that I dislike such kind of comments 

 

 

/// <summary>
/// Updates the position of all blocks above the line that has been cleared.
/// </summary>
/// <param name="clearedY">The Y-coordinate of the cleared line.</param>
public void UpdateLandedPositions(float clearedY)
{
 

c# for me personally was always depressing 

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

GameDev.net is your game development community. Create an account for your GameDev Portfolio and participate in the largest developer community in the games industry.

Sign me up!