• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
KoldGames

Read string of unknown size from binary using ifstream - C++

6 posts in this topic

Hello! I have my own custom binary model format and I am trying to read it using ifstream, but ran into a problem. I have a class called NXNode which contains the name of each scene node. The problem is that the name's size varies. How would I read the string correctly when I don't know it's size? I know BinaryReader.ReadString() does it without me specifying the size, so it must be possible with C++ too right? Thanks! smile.png

 

[EDIT: Here's some code if it helps]

NXNode::NXNode(ifstream* reader, NXNode* parent) : NXNode()
{
	if (parent != NULL)
		Parent = parent;
	
	reader->read((char*) &Name, sizeof(string));
	reader->read((char*)&HasChildren, sizeof(bool));
	reader->read((char*)&MeshCount, sizeof(short));
	reader->read((char*)&ChildCount, sizeof(short));
	
	float nums[16];
	for (int i = 0; i < 16; i++)
	{
		reader->read((char*) &nums[i], sizeof(float));
	}

	if (HasChildren)
	{
		Children = new NXNode[ChildCount];
		for (int i = 0; i < ChildCount; i++)
		{
			Children[i] = NXNode(reader, this);
		}
	}
}
Edited by KoldGames
0

Share this post


Link to post
Share on other sites

What is usually done is either a few bytes are prefixed to the string that tell you how many characters are in it, or the string is NULL terminated (so you write the trailing '\0' when you write the string) and when you read you just keep reading until you hit the NULL character.

1

Share this post


Link to post
Share on other sites

Just to throw more onto what was already said, it is typically preferred to store the length of the string and then read the whole string all at once instead of repeatedly reading a single character at a time for performance reasons.

 

 

L. Spiro

1

Share this post


Link to post
Share on other sites

Hello! So I now the length for each string in my file. In this case, the length is 7 (box.obj). Here's how it's setup now:

int nameLength;
reader->read((char*) &nameLength, sizeof(int));
reader->read((char*) &Name, sizeof(nameLength));

But now, it won't read. My app crashes. Am I doing that the write way? Thanks! :)

0

Share this post


Link to post
Share on other sites

Note that depending on the type of Name, reading and writing using &Name could be very bad ju-ju.

0

Share this post


Link to post
Share on other sites

And while we are on that note of precautions-

 

If “Name” is some kind of pointer then it should be allocated to be able to hold nameLength characters (or (nameLength + 1) if the ternimator is not included).

If “nameLength” does not include the terminating '\0' character, it must be explicitly added since it is not being added during the read.

 

 

L. Spiro

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0