Sign in to follow this  
Seabolt

OpenGL FBO rendering behavior

Recommended Posts

Seabolt    781

Hey guys, I have some questions about how an FBO may work.

I'm trying to incorporate FBOs into an existing rendering pipeline. To maintain current architecture I'm trying to use only one FBO for the program. I know it may not be ideal, but it should still work, (unless someone knows a better way to do MRT in OpenGL). I really can't know about any other targets I may be bound with when I create the render target, so I'm creating them and attaching them to the FBO later on.

So my current path is like such:

If it's a color target: Create a texture.

If it's a depth target: Create a renderbuffer.

Then when I bind the targets for a draw:
Bind a framebuffer
For each color target
     If it's a color target.
         Attach my texture to the frame buffer
    If it's a depth target
        Attach my renderbuffer to the frame buffer
Enable the draw buffer for any color target attachments

This runs with no problems, but in gDebugger I don't see anything being drawn to my color target's texture. Any ideas?

 

//
// Create our gl texture handle
//

glGenTextures( 1, &texture->m_Texture );																	
GL_ERROR( "Failed to generate render target texture" );
glBindTexture( GL_TEXTURE_2D, texture->m_Texture );															
GL_ERROR( "Failed to bind the render target texture when initializing" );

//
// Set the texture data parameters and some filtering data.
// TODO: We need to pass in platform agnostic filtering information here.
//
	
GLenum platformFormat = GetPlatformTextureFormat( format ); 
GLenum imageFormat = GetOpenGLImageFormat( platformFormat );
GLenum componentType = GetOpenGLComponentType( platformFormat );
glTexImage2D( GL_TEXTURE_2D, 0, platformFormat, width, height, 0, imageFormat, componentType, 0 );			
GL_ERROR( "Failed to set the texture image parameters for a render target texture" );

glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);										
GL_ERROR( "Failed to set the filtering parameters for a render target texture" );
glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);											
GL_ERROR( "Failed to set the filtering parameters for a render target texture" );

and for depth stencil render targets I use this code:

 

pglGenRenderbuffers( 1, &m_PlatformData.m_TargetHandle );				
GL_ERROR( "Failed to generate render buffer handle" );

pglBindRenderbuffer( GL_RENDERBUFFER, m_PlatformData.m_TargetHandle );		
GL_ERROR( "Failed to bind the render buffer" );

pglRenderbufferStorage( GL_RENDERBUFFER, platformFormat, width, height );	
GL_ERROR( "Failed to set render buffer storage" );
		
pglBindRenderbuffer( GL_RENDERBUFFER, 0 );		
pglBindFramebuffer( GL_FRAMEBUFFER, m_FrameBufferObject ); 
GL_ERROR( "Failed to bind context frame buffer" );

int numDrawBuffers = 0;
GLenum drawBuffers[ VTG_MAX_RENDER_TARGETS ] = {GL_COLOR_ATTACHMENT0};
for( int currentTarget = 0; currentTarget < VTG_MAX_RENDER_TARGETS; ++currentTarget )
{
	if( m_BoundRenderTargets[ currentTarget ] )
	{
	        m_BoundRenderTargets[ currentTarget ]->Bind( currentTarget );
		drawBuffers[ currentTarget ] = GL_COLOR_ATTACHMENT0 + currentTarget;
		numDrawBuffers++;
	}
}

pglDrawBuffers( numDrawBuffers, drawBuffers );	
GL_ERROR( "Failed to specify draw buffers" );

if( m_BoundDepthTarget )
{
	m_BoundDepthTarget->Bind( -1 );
}

//
// Now we need to make sure we are complete.
//

CheckForCompleteness();

The bind function for a render target looks like this: 

 

	if( m_Texture )
	{
		//glBindTexture( GL_TEXTURE_2D, m_Texture->m_Texture );	
                GL_ERROR( "Failed to bind the texture" );
		pglFramebufferTexture2D( GL_FRAMEBUFFER, attachment, GL_TEXTURE_2D, m_Texture->m_Texture, 0 );
		GL_ERROR( "Failed to set the render target as a texture" );
	}
	else
	{
		//
		// Attach to the currently bound frame buffer object.
		// TODO: Need some way to ensure there is an FBO bound...
		//

		pglFramebufferRenderbuffer( GL_FRAMEBUFFER,
			attachment,
			GL_RENDERBUFFER,
			m_PlatformData.m_TargetHandle );
		GL_ERROR( "Failed to attach the render buffer to the frame buffer" );
	}
			
GL_ERROR( "Failed to bind the default back buffer" );

This code executes with no problem. Then when I update all render targets I do this code:

 


 

Share this post


Link to post
Share on other sites
3TATUK2    714

First, i'd check whether your framebuffer is proper ...

printf("%i\n",glCheckFramebufferStatus(GL_FRAMEBUFFER)==GL_FRAMEBUFFER_COMPLETE);

Also, I'd avoid using a renderbuffer for the depth.. just use a regular GL_DEPTH_COMPONENT texture....

 

Lastly, probably can try to avoid re-attaching the textures to the framebuffer each time. Just attach them once when you create it and they're still attached next time you bind the framebuffer.

Share this post


Link to post
Share on other sites
Seabolt    781

I am check the framebuffer completeness, it's all good. 
I'm using a renderbuffer for the depth because it's faster and I want to test renderbuffer functionality as well.

My problem is that I don't know what render targets are going to be bound to a framebuffer each frame, so I have to rebind the texture/renderbuffers each frame.

Share this post


Link to post
Share on other sites
Seabolt    781

So it seems that it will write to the render target texture as long as the texture is bound. If I bind another texture it seems to overwrite it. Should that happen? What if I want to bind a texture for something I want to draw into the render target, how would I do that?

Share this post


Link to post
Share on other sites
Seabolt    781

Jesus christ, I apologize guys, I'm all over the place right now.

I can get the model to draw if I don't use a depth stencil buffer.

Is it possible the texture and renderbuffer are conflicting somehow? The renderbuffer is being bound to the GL_DEPTH_STENCIL_ATTACHMENT point of the FBO so it shouldn't be overwriting anything...

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By Zaphyk
      I am developing my engine using the OpenGL 3.3 compatibility profile. It runs as expected on my NVIDIA card and on my Intel Card however when I tried it on an AMD setup it ran 3 times worse than on the other setups. Could this be a AMD driver thing or is this probably a problem with my OGL code? Could a different code standard create such bad performance?
    • By Kjell Andersson
      I'm trying to get some legacy OpenGL code to run with a shader pipeline,
      The legacy code uses glVertexPointer(), glColorPointer(), glNormalPointer() and glTexCoordPointer() to supply the vertex information.
      I know that it should be using setVertexAttribPointer() etc to clearly define the layout but that is not an option right now since the legacy code can't be modified to that extent.
      I've got a version 330 vertex shader to somewhat work:
      #version 330 uniform mat4 osg_ModelViewProjectionMatrix; uniform mat4 osg_ModelViewMatrix; layout(location = 0) in vec4 Vertex; layout(location = 2) in vec4 Normal; // Velocity layout(location = 3) in vec3 TexCoord; // TODO: is this the right layout location? out VertexData { vec4 color; vec3 velocity; float size; } VertexOut; void main(void) { vec4 p0 = Vertex; vec4 p1 = Vertex + vec4(Normal.x, Normal.y, Normal.z, 0.0f); vec3 velocity = (osg_ModelViewProjectionMatrix * p1 - osg_ModelViewProjectionMatrix * p0).xyz; VertexOut.velocity = velocity; VertexOut.size = TexCoord.y; gl_Position = osg_ModelViewMatrix * Vertex; } What works is the Vertex and Normal information that the legacy C++ OpenGL code seem to provide in layout location 0 and 2. This is fine.
      What I'm not getting to work is the TexCoord information that is supplied by a glTexCoordPointer() call in C++.
      Question:
      What layout location is the old standard pipeline using for glTexCoordPointer()? Or is this undefined?
       
      Side note: I'm trying to get an OpenSceneGraph 3.4.0 particle system to use custom vertex, geometry and fragment shaders for rendering the particles.
    • By markshaw001
      Hi i am new to this forum  i wanted to ask for help from all of you i want to generate real time terrain using a 32 bit heightmap i am good at c++ and have started learning Opengl as i am very interested in making landscapes in opengl i have looked around the internet for help about this topic but i am not getting the hang of the concepts and what they are doing can some here suggests me some good resources for making terrain engine please for example like tutorials,books etc so that i can understand the whole concept of terrain generation.
       
    • By KarimIO
      Hey guys. I'm trying to get my application to work on my Nvidia GTX 970 desktop. It currently works on my Intel HD 3000 laptop, but on the desktop, every bind textures specifically from framebuffers, I get half a second of lag. This is done 4 times as I have three RGBA textures and one depth 32F buffer. I tried to use debugging software for the first time - RenderDoc only shows SwapBuffers() and no OGL calls, while Nvidia Nsight crashes upon execution, so neither are helpful. Without binding it runs regularly. This does not happen with non-framebuffer binds.
      GLFramebuffer::GLFramebuffer(FramebufferCreateInfo createInfo) { glGenFramebuffers(1, &fbo); glBindFramebuffer(GL_FRAMEBUFFER, fbo); textures = new GLuint[createInfo.numColorTargets]; glGenTextures(createInfo.numColorTargets, textures); GLenum *DrawBuffers = new GLenum[createInfo.numColorTargets]; for (uint32_t i = 0; i < createInfo.numColorTargets; i++) { glBindTexture(GL_TEXTURE_2D, textures[i]); GLint internalFormat; GLenum format; TranslateFormats(createInfo.colorFormats[i], format, internalFormat); // returns GL_RGBA and GL_RGBA glTexImage2D(GL_TEXTURE_2D, 0, internalFormat, createInfo.width, createInfo.height, 0, format, GL_FLOAT, 0); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); DrawBuffers[i] = GL_COLOR_ATTACHMENT0 + i; glBindTexture(GL_TEXTURE_2D, 0); glFramebufferTexture(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0 + i, textures[i], 0); } if (createInfo.depthFormat != FORMAT_DEPTH_NONE) { GLenum depthFormat; switch (createInfo.depthFormat) { case FORMAT_DEPTH_16: depthFormat = GL_DEPTH_COMPONENT16; break; case FORMAT_DEPTH_24: depthFormat = GL_DEPTH_COMPONENT24; break; case FORMAT_DEPTH_32: depthFormat = GL_DEPTH_COMPONENT32; break; case FORMAT_DEPTH_24_STENCIL_8: depthFormat = GL_DEPTH24_STENCIL8; break; case FORMAT_DEPTH_32_STENCIL_8: depthFormat = GL_DEPTH32F_STENCIL8; break; } glGenTextures(1, &depthrenderbuffer); glBindTexture(GL_TEXTURE_2D, depthrenderbuffer); glTexImage2D(GL_TEXTURE_2D, 0, depthFormat, createInfo.width, createInfo.height, 0, GL_DEPTH_COMPONENT, GL_FLOAT, 0); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glBindTexture(GL_TEXTURE_2D, 0); glFramebufferTexture(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, depthrenderbuffer, 0); } if (createInfo.numColorTargets > 0) glDrawBuffers(createInfo.numColorTargets, DrawBuffers); else glDrawBuffer(GL_NONE); if (glCheckFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE) std::cout << "Framebuffer Incomplete\n"; glBindFramebuffer(GL_FRAMEBUFFER, 0); width = createInfo.width; height = createInfo.height; } // ... // FBO Creation FramebufferCreateInfo gbufferCI; gbufferCI.colorFormats = gbufferCFs.data(); gbufferCI.depthFormat = FORMAT_DEPTH_32; gbufferCI.numColorTargets = gbufferCFs.size(); gbufferCI.width = engine.settings.resolutionX; gbufferCI.height = engine.settings.resolutionY; gbufferCI.renderPass = nullptr; gbuffer = graphicsWrapper->CreateFramebuffer(gbufferCI); // Bind glBindFramebuffer(GL_DRAW_FRAMEBUFFER, fbo); // Draw here... // Bind to textures glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, textures[0]); glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, textures[1]); glActiveTexture(GL_TEXTURE2); glBindTexture(GL_TEXTURE_2D, textures[2]); glActiveTexture(GL_TEXTURE3); glBindTexture(GL_TEXTURE_2D, depthrenderbuffer); Here is an extract of my code. I can't think of anything else to include. I've really been butting my head into a wall trying to think of a reason but I can think of none and all my research yields nothing. Thanks in advance!
    • By Adrianensis
      Hi everyone, I've shared my 2D Game Engine source code. It's the result of 4 years working on it (and I still continue improving features ) and I want to share with the community. You can see some videos on youtube and some demo gifs on my twitter account.
      This Engine has been developed as End-of-Degree Project and it is coded in Javascript, WebGL and GLSL. The engine is written from scratch.
      This is not a professional engine but it's for learning purposes, so anyone can review the code an learn basis about graphics, physics or game engine architecture. Source code on this GitHub repository.
      I'm available for a good conversation about Game Engine / Graphics Programming
  • Popular Now