• Advertisement
Sign in to follow this  

DX11 HDR adaptation, avg lum isn't calculated properly

This topic is 1534 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hello,

 

after starting over with implemented HDR for my new engine, I'm experiencing an issue I had the last time too: The scenes adaptation reacts mostly entierly to the luminance in the center of the scene, not the averaged value. Take a look at the two screenshots. The first one shows a fully adapated scene. The second one is almost exactly the same, though slightly moved to the right. Now obviously the shadowy part of that object is in the middle, and that seems to drag the "average" luminance I calculated to become extremely low, therefore the scene flashes in all white. If I move the camera slightly to eigther the right, left, up or down, it becomes "normal" again. This happens everywheren, whenever there is a very dark/bright part in the middle of the screen, the adaptation goes nuts. Therefore I deduce that the average luminance calculation is broken. I've even got multiple different settings, and all produce this same behaviour:

 

- DirectX11, shader:

#include "../../../Base3D/Effects/Vertex.afx"

sampler InputSampler : register(s0);

Texture2D <float4> Luminance  : register(t0);

float4 mainPS(VS_OUTPUT i) : SV_TARGET0
{
	float4 inTex = Luminance.Sample(InputSampler, i.vTex0);
	
	return inTex;
};

I'm using this shader with a linear sampler to downsample the scenes luminance by 2times until there is only a 1x1 target left.

 

- DirectX11 auto mipmap generation:

 

Since the downsampling first produced the issue, I decided to try out auto-mipmap generation. It still produces exactly the same effect, the luminance in the middle of the scene almost entirely determines the avg luminance.

#include "../../../Base3D/Effects/Vertex.afx"

cbuffer instance : register(b2)
{
	float2 params; // x = delta, y = miplevel
}

sampler InputSampler : register(s0);

Texture2D <float> CurrentLum  : register(t0);
Texture2D <float> PreviousLum  : register(t1);

float4 mainPS(VS_OUTPUT i) : SV_TARGET0
{
	float fAdaptedLum = PreviousLum.Sample(InputSampler, i.vTex0);
	float fCurrentLum = CurrentLum.SampleLevel(InputSampler, i.vTex0, (int)params.y);
	
	const float fTau = 0.5f;
    float fNewAdaptation = fAdaptedLum + (fCurrentLum - fAdaptedLum) * (1 - exp(-params.x * fTau));

	return float4(fNewAdaptation, 0.0f, 0.0, 1.0);
};

- DirectX9, shader (almost identically to the DX11 one), also the same result.

 

Now, is there anything I'm missing? The way I used to do this has been taken from an old NVIDIA sample, but this one doesn't even get gamma-correction right, so I doubt it is accurate...

 

 

Share this post


Link to post
Share on other sites
Advertisement

some cards doesn't handle mipmap generation for float textures, and some do it on the CPU side (even for non float), you need to generate mipmaps with your on shaders.

 

(oh and auto generation doesnt work for render targets, havent looked your code through.)

Edited by skarab

Share this post


Link to post
Share on other sites


some cards doesn't handle mipmap generation for float textures, and some do it on the CPU side (even for non float), you need to generate mipmaps with your on shaders.

(oh and auto generation doesnt work for render targets, havent looked your code through.)

 

DirectX11 at least should be able to handle auto generation for render targets, in fact its the only use for it. http://msdn.microsoft.com/en-us/library/windows/desktop/ff476426%28v=vs.85%29.aspx See the remarks about needing to have RENDER_TARGET and SHADER_RESOURCE set. I did check the result though, and the mip levels are correctly calculated at least that there are miplevels, but it appears it doesn't sample right...

Share this post


Link to post
Share on other sites

When you sample the Luminance texture, you need to sample the lowest mip level, since this is the level which holds the average value.

You call Luminance.Sample(), so unless you create the SRV with only the last mip-level, this will almost certainly will not sample from there. You also don't need texCoord from the VS, as the final mip-level is 1 pixel, and you can just use (0.5, 0.5).

 

The old NVIDIA sample probably did gamma correction inside the shader. Now-days, if you create your resources as SRGB, it's done automatically in the HW.

Share this post


Link to post
Share on other sites

Using texture.SampleLevel, you can just pass in an absurdly high value for the LOD (something like 666 biggrin.png) and it will clamp to the smallest miplevel, which should be your 1x1 level.  I'm not too certain about sampling from a luminance rendertarget however; last time I did this I sampled from an RGBA one and dotted the float4 with (0.3, 0.59, 0.11, 0.0) to get the luminance.

 

The other thing I found is that for certain game types - such as an FPS - you move through the world so fast that the average luminance in the scene changes rapidly, which led to a flickering/strobing effect.  To resolve that I updated the average luminance at some well-defined interval (0.1 seconds worked well for me, you can feel free to experiment) and interpolated between that and the previous average luminance based on time passed.  That worked quite well and gave a good illusion of eye-adaptation over time - not physically correct (in real life it takes a lot longer) but good enough to show off the effect in a reasonably convincing manner.

Share this post


Link to post
Share on other sites

 


some cards doesn't handle mipmap generation for float textures, and some do it on the CPU side (even for non float), you need to generate mipmaps with your on shaders.

(oh and auto generation doesnt work for render targets, havent looked your code through.)

 

DirectX11 at least should be able to handle auto generation for render targets, in fact its the only use for it. http://msdn.microsoft.com/en-us/library/windows/desktop/ff476426%28v=vs.85%29.aspx See the remarks about needing to have RENDER_TARGET and SHADER_RESOURCE set. I did check the result though, and the mip levels are correctly calculated at least that there are miplevels, but it appears it doesn't sample right...

 

Have you checked you create the RTs with D3D11_RESOURCE_MISC_GENERATE_MIPS?

Furthermore, check your sampling states are correct.

 

I wouldn't trust mipmapping to do this work though. Drivers often allow overriding mip settings to improve performance by trading quality; or to avoid blurry textures; which could break your HDR.

Share this post


Link to post
Share on other sites


Have you checked the mipmap visually ? (maybe there is no bilinear support as well, I dont know this directx 11 thing sorry)


Have you checked you create the RTs with D3D11_RESOURCE_MISC_GENERATE_MIPS?

 

Regarding this, I did check that at least my render target is created with the GENERATE_MIPS flag, and the mips are indeed being generated. I don't have any screenshots, but I'm not sure I could tell whether it would have correct filtering or not, so I'll try to get a cap of the mipmaps so some of you could look at it...


When you sample the Luminance texture, you need to sample the lowest mip level, since this is the level which holds the average value.

You call Luminance.Sample(), so unless you create the SRV with only the last mip-level, this will almost certainly will not sample from there. You also don't need texCoord from the VS, as the final mip-level is 1 pixel, and you can just use (0.5, 0.5).

 

No, no, I'm calling Sample on the 1x1 luminance output target from the last call, I'm using SampleLevel passing in the correct mip level (11 for 1378x768) on the scenes luminance texture. Thanks to for the hint with the texture coordinates, it didn't fix anything but at least now my shader is a little simplier.

 


The old NVIDIA sample probably did gamma correction inside the shader. Now-days, if you create your resources as SRGB, it's done automatically in the HW.

 

I'm pretty sure it didn't do it anywhere, there was no pow() anywhere, and SRGB in the effects was explicitely set to false. Maybe someone screwed up before posting the sample, or something...

 


Using texture.SampleLevel, you can just pass in an absurdly high value for the LOD (something like 666 biggrin.png) and it will clamp to the smallest miplevel, which should be your 1x1 level. I'm not too certain about sampling from a luminance rendertarget however; last time I did this I sampled from an RGBA one and dotted the float4 with (0.3, 0.59, 0.11, 0.0) to get the luminance.

 

Ah, thats good to know and saves me some complexity :D Well, I'm doing the RGB to LUM conversion before calculating the average luminance, so that should be fine :D


The other thing I found is that for certain game types - such as an FPS - you move through the world so fast that the average luminance in the scene changes rapidly, which led to a flickering/strobing effect. To resolve that I updated the average luminance at some well-defined interval (0.1 seconds worked well for me, you can feel free to experiment) and interpolated between that and the previous average luminance based on time passed. That worked quite well and gave a good illusion of eye-adaptation over time - not physically correct (in real life it takes a lot longer) but good enough to show off the effect in a reasonably convincing manner.

 

I though that could be a reason too, and I quess I'll need a solution to that at some point, but in my case even a suddle move of the camera like in this case of 1 screen pixel, it goes from average dark to unrealistically bright in half a second, so thats something else...

 


I wouldn't trust mipmapping to do this work though. Drivers often allow overriding mip settings to improve performance by trading quality; or to avoid blurry textures; which could break your HDR.

 

Well, I went to doing auto-mipmapping since my first sample-shader approach failed with the same result. Is there anything wrong about my pass-through shader, the first one I posted? I made sure the filter for the scene luminance is set to linear, so I quess I need to do something else inside the shader to get it to work?

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Now

  • Advertisement
  • Similar Content

    • By AxeGuywithanAxe
      I wanted to see how others are currently handling descriptor heap updates and management.
      I've read a few articles and there tends to be three major strategies :
      1 ) You split up descriptor heaps per shader stage ( i.e one for vertex shader , pixel , hull, etc)
      2) You have one descriptor heap for an entire pipeline
      3) You split up descriptor heaps for update each update frequency (i.e EResourceSet_PerInstance , EResourceSet_PerPass , EResourceSet_PerMaterial, etc)
      The benefits of the first two approaches is that it makes it easier to port current code, and descriptor / resource descriptor management and updating tends to be easier to manage, but it seems to be not as efficient.
      The benefits of the third approach seems to be that it's the most efficient because you only manage and update objects when they change.
    • By evelyn4you
      hi,
      until now i use typical vertexshader approach for skinning with a Constantbuffer containing the transform matrix for the bones and an the vertexbuffer containing bone index and bone weight.
      Now i have implemented realtime environment  probe cubemaping so i have to render my scene from many point of views and the time for skinning takes too long because it is recalculated for every side of the cubemap.
      For Info i am working on Win7 an therefore use one Shadermodel 5.0 not 5.x that have more options, or is there a way to use 5.x in Win 7
      My Graphic Card is Directx 12 compatible NVidia GTX 960
      the member turanszkij has posted a good for me understandable compute shader. ( for Info: in his engine he uses an optimized version of it )
      https://turanszkij.wordpress.com/2017/09/09/skinning-in-compute-shader/
      Now my questions
       is it possible to feed the compute shader with my orignial vertexbuffer or do i have to copy it in several ByteAdressBuffers as implemented in the following code ?
        the same question is about the constant buffer of the matrixes
       my more urgent question is how do i feed my normal pipeline with the result of the compute Shader which are 2 RWByteAddressBuffers that contain position an normal
      for example i could use 2 vertexbuffer bindings
      1 containing only the uv coordinates
      2.containing position and normal
      How do i copy from the RWByteAddressBuffers to the vertexbuffer ?
       
      (Code from turanszkij )
      Here is my shader implementation for skinning a mesh in a compute shader:
      1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 struct Bone { float4x4 pose; }; StructuredBuffer<Bone> boneBuffer;   ByteAddressBuffer vertexBuffer_POS; // T-Pose pos ByteAddressBuffer vertexBuffer_NOR; // T-Pose normal ByteAddressBuffer vertexBuffer_WEI; // bone weights ByteAddressBuffer vertexBuffer_BON; // bone indices   RWByteAddressBuffer streamoutBuffer_POS; // skinned pos RWByteAddressBuffer streamoutBuffer_NOR; // skinned normal RWByteAddressBuffer streamoutBuffer_PRE; // previous frame skinned pos   inline void Skinning(inout float4 pos, inout float4 nor, in float4 inBon, in float4 inWei) {  float4 p = 0, pp = 0;  float3 n = 0;  float4x4 m;  float3x3 m3;  float weisum = 0;   // force loop to reduce register pressure  // though this way we can not interleave TEX - ALU operations  [loop]  for (uint i = 0; ((i &lt; 4) &amp;&amp; (weisum&lt;1.0f)); ++i)  {  m = boneBuffer[(uint)inBon].pose;  m3 = (float3x3)m;   p += mul(float4(pos.xyz, 1), m)*inWei;  n += mul(nor.xyz, m3)*inWei;   weisum += inWei;  }   bool w = any(inWei);  pos.xyz = w ? p.xyz : pos.xyz;  nor.xyz = w ? n : nor.xyz; }   [numthreads(1024, 1, 1)] void main( uint3 DTid : SV_DispatchThreadID ) {  const uint fetchAddress = DTid.x * 16; // stride is 16 bytes for each vertex buffer now...   uint4 pos_u = vertexBuffer_POS.Load4(fetchAddress);  uint4 nor_u = vertexBuffer_NOR.Load4(fetchAddress);  uint4 wei_u = vertexBuffer_WEI.Load4(fetchAddress);  uint4 bon_u = vertexBuffer_BON.Load4(fetchAddress);   float4 pos = asfloat(pos_u);  float4 nor = asfloat(nor_u);  float4 wei = asfloat(wei_u);  float4 bon = asfloat(bon_u);   Skinning(pos, nor, bon, wei);   pos_u = asuint(pos);  nor_u = asuint(nor);   // copy prev frame current pos to current frame prev pos streamoutBuffer_PRE.Store4(fetchAddress, streamoutBuffer_POS.Load4(fetchAddress)); // write out skinned props:  streamoutBuffer_POS.Store4(fetchAddress, pos_u);  streamoutBuffer_NOR.Store4(fetchAddress, nor_u); }  
    • By mister345
      Hi, can someone please explain why this is giving an assertion EyePosition!=0 exception?
       
      _lightBufferVS->viewMatrix = DirectX::XMMatrixLookAtLH(XMLoadFloat3(&_lightBufferVS->position), XMLoadFloat3(&_lookAt), XMLoadFloat3(&up));
      It looks like DirectX doesnt want the 2nd parameter to be a zero vector in the assertion, but I passed in a zero vector with this exact same code in another program and it ran just fine. (Here is the version of the code that worked - note XMLoadFloat3(&m_lookAt) parameter value is (0,0,0) at runtime - I debugged it - but it throws no exceptions.
          m_viewMatrix = DirectX::XMMatrixLookAtLH(XMLoadFloat3(&m_position), XMLoadFloat3(&m_lookAt), XMLoadFloat3(&up)); Here is the repo for the broken code (See LightClass) https://github.com/mister51213/DirectX11Engine/blob/master/DirectX11Engine/LightClass.cpp
      and here is the repo with the alternative version of the code that is working with a value of (0,0,0) for the second parameter.
      https://github.com/mister51213/DX11Port_SoftShadows/blob/master/Engine/lightclass.cpp
    • By mister345
      Hi, can somebody please tell me in clear simple steps how to debug and step through an hlsl shader file?
      I already did Debug > Start Graphics Debugging > then captured some frames from Visual Studio and
      double clicked on the frame to open it, but no idea where to go from there.
       
      I've been searching for hours and there's no information on this, not even on the Microsoft Website!
      They say "open the  Graphics Pixel History window" but there is no such window!
      Then they say, in the "Pipeline Stages choose Start Debugging"  but the Start Debugging option is nowhere to be found in the whole interface.
      Also, how do I even open the hlsl file that I want to set a break point in from inside the Graphics Debugger?
       
      All I want to do is set a break point in a specific hlsl file, step thru it, and see the data, but this is so unbelievably complicated
      and Microsoft's instructions are horrible! Somebody please, please help.
       
       
       

    • By mister345
      I finally ported Rastertek's tutorial # 42 on soft shadows and blur shading. This tutorial has a ton of really useful effects and there's no working version anywhere online.
      Unfortunately it just draws a black screen. Not sure what's causing it. I'm guessing the camera or ortho matrix transforms are wrong, light directions, or maybe texture resources not being properly initialized.  I didnt change any of the variables though, only upgraded all types and functions DirectX3DVector3 to XMFLOAT3, and used DirectXTK for texture loading. If anyone is willing to take a look at what might be causing the black screen, maybe something pops out to you, let me know, thanks.
      https://github.com/mister51213/DX11Port_SoftShadows
       
      Also, for reference, here's tutorial #40 which has normal shadows but no blur, which I also ported, and it works perfectly.
      https://github.com/mister51213/DX11Port_ShadowMapping
       
  • Advertisement