• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Juliean

DX11
HDR adaptation, avg lum isn't calculated properly

7 posts in this topic

Hello,

 

after starting over with implemented HDR for my new engine, I'm experiencing an issue I had the last time too: The scenes adaptation reacts mostly entierly to the luminance in the center of the scene, not the averaged value. Take a look at the two screenshots. The first one shows a fully adapated scene. The second one is almost exactly the same, though slightly moved to the right. Now obviously the shadowy part of that object is in the middle, and that seems to drag the "average" luminance I calculated to become extremely low, therefore the scene flashes in all white. If I move the camera slightly to eigther the right, left, up or down, it becomes "normal" again. This happens everywheren, whenever there is a very dark/bright part in the middle of the screen, the adaptation goes nuts. Therefore I deduce that the average luminance calculation is broken. I've even got multiple different settings, and all produce this same behaviour:

 

- DirectX11, shader:

#include "../../../Base3D/Effects/Vertex.afx"

sampler InputSampler : register(s0);

Texture2D <float4> Luminance  : register(t0);

float4 mainPS(VS_OUTPUT i) : SV_TARGET0
{
	float4 inTex = Luminance.Sample(InputSampler, i.vTex0);
	
	return inTex;
};

I'm using this shader with a linear sampler to downsample the scenes luminance by 2times until there is only a 1x1 target left.

 

- DirectX11 auto mipmap generation:

 

Since the downsampling first produced the issue, I decided to try out auto-mipmap generation. It still produces exactly the same effect, the luminance in the middle of the scene almost entirely determines the avg luminance.

#include "../../../Base3D/Effects/Vertex.afx"

cbuffer instance : register(b2)
{
	float2 params; // x = delta, y = miplevel
}

sampler InputSampler : register(s0);

Texture2D <float> CurrentLum  : register(t0);
Texture2D <float> PreviousLum  : register(t1);

float4 mainPS(VS_OUTPUT i) : SV_TARGET0
{
	float fAdaptedLum = PreviousLum.Sample(InputSampler, i.vTex0);
	float fCurrentLum = CurrentLum.SampleLevel(InputSampler, i.vTex0, (int)params.y);
	
	const float fTau = 0.5f;
    float fNewAdaptation = fAdaptedLum + (fCurrentLum - fAdaptedLum) * (1 - exp(-params.x * fTau));

	return float4(fNewAdaptation, 0.0f, 0.0, 1.0);
};

- DirectX9, shader (almost identically to the DX11 one), also the same result.

 

Now, is there anything I'm missing? The way I used to do this has been taken from an old NVIDIA sample, but this one doesn't even get gamma-correction right, so I doubt it is accurate...

 

 

0

Share this post


Link to post
Share on other sites

some cards doesn't handle mipmap generation for float textures, and some do it on the CPU side (even for non float), you need to generate mipmaps with your on shaders.

 

(oh and auto generation doesnt work for render targets, havent looked your code through.)

Edited by skarab
0

Share this post


Link to post
Share on other sites


some cards doesn't handle mipmap generation for float textures, and some do it on the CPU side (even for non float), you need to generate mipmaps with your on shaders.

(oh and auto generation doesnt work for render targets, havent looked your code through.)

 

DirectX11 at least should be able to handle auto generation for render targets, in fact its the only use for it. http://msdn.microsoft.com/en-us/library/windows/desktop/ff476426%28v=vs.85%29.aspx See the remarks about needing to have RENDER_TARGET and SHADER_RESOURCE set. I did check the result though, and the mip levels are correctly calculated at least that there are miplevels, but it appears it doesn't sample right...

0

Share this post


Link to post
Share on other sites

Have you checked the mipmap visually ? (maybe there is no bilinear support as well, I dont know this directx 11 thing sorry)

0

Share this post


Link to post
Share on other sites

When you sample the Luminance texture, you need to sample the lowest mip level, since this is the level which holds the average value.

You call Luminance.Sample(), so unless you create the SRV with only the last mip-level, this will almost certainly will not sample from there. You also don't need texCoord from the VS, as the final mip-level is 1 pixel, and you can just use (0.5, 0.5).

 

The old NVIDIA sample probably did gamma correction inside the shader. Now-days, if you create your resources as SRGB, it's done automatically in the HW.

0

Share this post


Link to post
Share on other sites

Using texture.SampleLevel, you can just pass in an absurdly high value for the LOD (something like 666 biggrin.png) and it will clamp to the smallest miplevel, which should be your 1x1 level.  I'm not too certain about sampling from a luminance rendertarget however; last time I did this I sampled from an RGBA one and dotted the float4 with (0.3, 0.59, 0.11, 0.0) to get the luminance.

 

The other thing I found is that for certain game types - such as an FPS - you move through the world so fast that the average luminance in the scene changes rapidly, which led to a flickering/strobing effect.  To resolve that I updated the average luminance at some well-defined interval (0.1 seconds worked well for me, you can feel free to experiment) and interpolated between that and the previous average luminance based on time passed.  That worked quite well and gave a good illusion of eye-adaptation over time - not physically correct (in real life it takes a lot longer) but good enough to show off the effect in a reasonably convincing manner.

0

Share this post


Link to post
Share on other sites

 


some cards doesn't handle mipmap generation for float textures, and some do it on the CPU side (even for non float), you need to generate mipmaps with your on shaders.

(oh and auto generation doesnt work for render targets, havent looked your code through.)

 

DirectX11 at least should be able to handle auto generation for render targets, in fact its the only use for it. http://msdn.microsoft.com/en-us/library/windows/desktop/ff476426%28v=vs.85%29.aspx See the remarks about needing to have RENDER_TARGET and SHADER_RESOURCE set. I did check the result though, and the mip levels are correctly calculated at least that there are miplevels, but it appears it doesn't sample right...

 

Have you checked you create the RTs with D3D11_RESOURCE_MISC_GENERATE_MIPS?

Furthermore, check your sampling states are correct.

 

I wouldn't trust mipmapping to do this work though. Drivers often allow overriding mip settings to improve performance by trading quality; or to avoid blurry textures; which could break your HDR.

0

Share this post


Link to post
Share on other sites


Have you checked the mipmap visually ? (maybe there is no bilinear support as well, I dont know this directx 11 thing sorry)


Have you checked you create the RTs with D3D11_RESOURCE_MISC_GENERATE_MIPS?

 

Regarding this, I did check that at least my render target is created with the GENERATE_MIPS flag, and the mips are indeed being generated. I don't have any screenshots, but I'm not sure I could tell whether it would have correct filtering or not, so I'll try to get a cap of the mipmaps so some of you could look at it...


When you sample the Luminance texture, you need to sample the lowest mip level, since this is the level which holds the average value.

You call Luminance.Sample(), so unless you create the SRV with only the last mip-level, this will almost certainly will not sample from there. You also don't need texCoord from the VS, as the final mip-level is 1 pixel, and you can just use (0.5, 0.5).

 

No, no, I'm calling Sample on the 1x1 luminance output target from the last call, I'm using SampleLevel passing in the correct mip level (11 for 1378x768) on the scenes luminance texture. Thanks to for the hint with the texture coordinates, it didn't fix anything but at least now my shader is a little simplier.

 


The old NVIDIA sample probably did gamma correction inside the shader. Now-days, if you create your resources as SRGB, it's done automatically in the HW.

 

I'm pretty sure it didn't do it anywhere, there was no pow() anywhere, and SRGB in the effects was explicitely set to false. Maybe someone screwed up before posting the sample, or something...

 


Using texture.SampleLevel, you can just pass in an absurdly high value for the LOD (something like 666 biggrin.png) and it will clamp to the smallest miplevel, which should be your 1x1 level. I'm not too certain about sampling from a luminance rendertarget however; last time I did this I sampled from an RGBA one and dotted the float4 with (0.3, 0.59, 0.11, 0.0) to get the luminance.

 

Ah, thats good to know and saves me some complexity :D Well, I'm doing the RGB to LUM conversion before calculating the average luminance, so that should be fine :D


The other thing I found is that for certain game types - such as an FPS - you move through the world so fast that the average luminance in the scene changes rapidly, which led to a flickering/strobing effect. To resolve that I updated the average luminance at some well-defined interval (0.1 seconds worked well for me, you can feel free to experiment) and interpolated between that and the previous average luminance based on time passed. That worked quite well and gave a good illusion of eye-adaptation over time - not physically correct (in real life it takes a lot longer) but good enough to show off the effect in a reasonably convincing manner.

 

I though that could be a reason too, and I quess I'll need a solution to that at some point, but in my case even a suddle move of the camera like in this case of 1 screen pixel, it goes from average dark to unrealistically bright in half a second, so thats something else...

 


I wouldn't trust mipmapping to do this work though. Drivers often allow overriding mip settings to improve performance by trading quality; or to avoid blurry textures; which could break your HDR.

 

Well, I went to doing auto-mipmapping since my first sample-shader approach failed with the same result. Is there anything wrong about my pass-through shader, the first one I posted? I made sure the filter for the scene luminance is set to linear, so I quess I need to do something else inside the shader to get it to work?

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • By YixunLiu
      Hi,
      I have a surface mesh and I want to use a cone to cut a hole on the surface mesh.
      Anybody know a fast method to calculate the intersected boundary of these two geometries?
       
      Thanks.
       
      YL
       
    • By hiya83
      Hi, I tried searching for this but either I failed or couldn't find anything. I know there's D11/D12 interop and there are extensions for GL/D11 (though not very efficient). I was wondering if there's any Vulkan/D11 or Vulkan/D12 interop?
      Thanks!
    • By lonewolff
      Hi Guys,
      I am just wondering if it is possible to acquire the address of the backbuffer if an API (based on DX11) only exposes the 'device' and 'context' pointers?
      Any advice would be greatly appreciated
    • By MarcusAseth
      bool InitDirect3D::Init() { if (!D3DApp::Init()) { return false; } //Additional Initialization //Disable Alt+Enter Fullscreen Toggle shortkey IDXGIFactory* factory; CreateDXGIFactory(__uuidof(IDXGIFactory), reinterpret_cast<void**>(&factory)); factory->MakeWindowAssociation(mhWindow, DXGI_MWA_NO_WINDOW_CHANGES); factory->Release(); return true; }  
      As stated on the title and displayed on the code above, regardless of it Alt+Enter still takes effect...
      I recall something from the book during the swapChain creation, where in order to create it one has to use the same factory used to create the ID3D11Device, therefore I tested and indeed using that same factory indeed it work.
      How is that one particular factory related to my window and how come the MakeWindowAssociation won't take effect with a newly created factory?
      Also what's even the point of being able to create this Factories if they won't work,?(except from that one associated with the ID3D11Device) 
    • By ProfL
      Can anyone recommend a wrapper for Direct3D 11 that is similarly simple to use as SFML? I don't need all the image formats etc. BUT I want a simple way to open a window, allocate a texture, buffer, shader.
  • Popular Now