• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
????? ?????

BulletManager, reflection from walls

4 posts in this topic

Hello everybody! I'm trying to solve test task:


 Given a list of segments (walls) , given the coordinates of two points on a two-dimensional space . Need to write a class BulletManager, which will include the following functions:

• void Update (float time), where time - global time of update in seconds. Function calculates the trajectory of bullets at a specified time and in contact with the wall, remove it from the list of segments . While hitting the wall, the bullet is reflected.
• void Fire (float2 pos, float2 dir, float speed, float time, float life_time), where pos - the starting position of the bullet in meters , dir - direction , speed - speed in meters per second , time - the shot in seconds , life_time - time to self-destruction bullets . This function adds a bullet in manager for further processing by an update .

Sorry for my English, the text above is google-translated.

 

I've made it, all is good, except of reflextion: bullet reflects, but not always correctly. Here is my function:

void BulletManager::Update(float time)
{
	for (int n = 0; n < bullets.size();)
	{
		auto bul = bullets.begin() + n;
		XMFLOAT2* bulDir = &bul->get()->GetDir();

		float x = bul->get()->GetInitPosition().x + (bulDir->x * (time - bul->get()->GetTime()) * bul->get()->GetSpeed());
		float y = bul->get()->GetInitPosition().y + (bulDir->y * (time - bul->get()->GetTime()) * bul->get()->GetSpeed());
		XMFLOAT2 point = XMFLOAT2(x, y);
		bul->get()->SetPosition(point);

		//Check bullet life time
		if (bul->get()->GetLifeTime() - (time - bul->get()->GetTime()) <= 0.0f)
		{
			bullets.erase(bul);
			n--;
			continue;
		}

		//Check, if bullet collides with sides
		for (int i=0; i<SidesCoordList.size(); i++)
		{
			if ( IsIntersecting(SidesCoordList[i], point, 1.0f) )
			{
				//Calculating normal vector for current side
				float A = abs(SidesCoordList[i].point1.y - SidesCoordList[i].point2.y);
				float B = abs(SidesCoordList[i].point2.x - SidesCoordList[i].point1.x);
				XMFLOAT2 normal = XMFLOAT2(A, B);
				normal = XMFLOAT2(normal.x / Calculations::VecLength(normal), normal.y / Calculations::VecLength(normal));

				//Calculating angles to get reflected directional vector
				float alpha = atan(A/B);
				float beta = acos(bulDir->x);
				float gamma = XM_PIDIV2 - (alpha - beta);
				float theta = beta + 2*gamma + XM_PI;

				//Setting new direction (after reflection)
				bul->get()->GetDir() = Calculations::RotateVector(bul->get()->GetDir(), theta);

				bul->get()->GetInitPosition() = bul->get()->GetPosition();
				bul->get()->GetTime() = time;
			}
		}
		n++;
	}
}

What's wrong with my code?

 

Thanks.

0

Share this post


Link to post
Share on other sites

It looks like you're repeating some work when you erase bullets. Since your n++ is at the end of your for loop's contents, the flow is something like this for a size 3 list where the 2nd bullet is too old.

 

* do bullet[0] work;

* bullet[1] is too old, erase him, --i;

* do bullet[0] work again

* do bullet[1] work (originally bullet[2]);

 

So you might wind up doing the reflection logic twice, or move twice as fast "skipping" a frame.

 

And in you're sets at the end, you're using get functions which is weird to me.

// earlier in your code you use this to set position
bul->get()->SetPosition(point);
 
// Then later in your code you're setting with code like this:
bul->get()->GetTime() = time;

 

I didn't check the math of your reflection code yet. I'm on vacation! :) Make sure y is going the direction you think it should. By default in drawing, +y is down the screen, but in math +y is up.

 

If this didn't help, what is the problem you're seeing in you're reflection?

 

- Eck

1

Share this post


Link to post
Share on other sites


It looks like you're repeating some work when you erase bullets

Yeah, I didn't point that. Thanks, I've corrected.

 


you're using get functions which is weird to me
I store my bullet as smart pointer in vector: vector<shared_ptr<Bullet>>, and I use common get() function: http://www.cplusplus.com/reference/memory/shared_ptr/get/

 


By default in drawing, +y is down the screen, but in math +y is up
I know, but I use Left-Handed coordinate system, where +y is up. By the way, if I replace my reflection code with function from xnamath.h
XMVector2Reflect(vecBulDir, vecNormal)

all works correctly. But my task is to write my own reflection sad.png

0

Share this post


Link to post
Share on other sites
If you want a more stable loop in which you will need to delete things, use this:
for (int n = bullets.size(); --n >= 0;)
Then you can avoid hacky n-- code in the loop body, plus it’s faster too.

Also, I’ve recently just explained why std::shared_ptr is bad for your health.  You should drop it and find an alternative or write your own game-friendly shared pointer.
 
Finally, a reflection vector.
Given an Incident vector I (the direction of the bullet) and the Normal vector N, a Reflect function can be made as follows:
 
VECTOR Reflect( const VECTOR & I, const VECTOR N ) {
    return I - 2.0f * dot( N, I ) * N;
}
This is exactly the same as calling XMVector2Reflect(), so if XMVector2Reflect( vecBulDir, vecNormal ) works, Reflect( vecBulDir, vecNormal ) works.


L. Spiro Edited by L. Spiro
1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0