Advertisement Jump to content
Sign in to follow this  
pressgreen

Qestion about passing incremented values

This topic is 1871 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Ok, so I completely understand the recursive portion of the Merge Sort algorithm but what I am having problems with is this example of the actual merge portion of the algorithm. In the first conditional statement were one is comparing the first element of the two input vectors I understand, but its the next line were p1 or p2 are being incremented up 1, while specifying which element is to be moved on to the empty vector, I am not understanding. Is it adding element 0 and then ++ to element 1 for the next comparison or is it passing element 1?

 

I guess my main question is, does the value of a variable get read first and then incremented or is the variables' value incremented and then read?

 

int newVariable = 0, oldVariableX = 0;

 

newVariable = oldVariableX++

 

Does  ( newVariable = 0   or   newVarivable = 1  ) ?

void Merge(Vector<int> & vec, Vector<int> & v1, Vector<int> & v2) 
{
     int n1 = v1.size();
     int n2 = v2.size();
     int p1 = 0;
     int p2 = 0;
     while (p1 < n1 && p2 < n2) {
         if (v1[p1] < v2[p2]) {
          vec.add(v1[p1++]);
         } else {
          vec.add(v2[p2++]);
         }
     }
    while (p1 < n1) vec.add(v1[p1++]);
    while (p2 < n2) vec.add(v2[p2++]);
}

Share this post


Link to post
Share on other sites
Advertisement
In your example the variable gets first read and then incremented.
Do you wish first do increment or decrement you have to write the operater in front of the variable instead behind like you did.

Share this post


Link to post
Share on other sites

Where the "++" is in relation to the variable determines what happens

int x1 = 0;
int y = x1++; //x1 = 1, y = 0
int x2 = 0;
int z = ++x2; //x2 = 1, z = 1

Share this post


Link to post
Share on other sites

Prefixed increases are more elegant on a computational cost point of view.

 

When you put the increment before the variable, the machine will actually increment and then use that already incremented variable.

In contrast, if you use the postfixed increment, the machine will "create a copy" the value of the variable, increment the variable and then use the (not incremented) copied value; a more costly operation.

 

Please, someone correct me if I'm wrong here.

 

Answering your question, newVariable would equal to 0.

If you used ++oldVariable instead, it would equal to 1.

Edited by dejaime

Share this post


Link to post
Share on other sites

Actually with that said and now understanding the incrementing better, Why are there two more while loops placed at the end of this function? I mean should not the first while loop be filling the empty vector with sorted merged values from the input vectors?

 

Why are they adding these last two while loops?

Share this post


Link to post
Share on other sites

Edit: Rephrased this... several times, actually.

 

The first while loop checks if both input vectors have unmerged entries. If they both have unmerged entries, it compares which is the smaller of the 2, and merges that into the output vector.

 

After doing this, it merges the remaining vectors, by just merging whatever is left in vector1, then vector2.

Either vector1 or vector2 will be empty at this point (due to the first while loop having been completed), so the final part really just merges the remaining vector in at the end.

Edited by CoreLactose

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

GameDev.net is your game development community. Create an account for your GameDev Portfolio and participate in the largest developer community in the games industry.

Sign me up!