I just completed an OpenGL wrapper class, but at one point, i could not see any better solution that using this goto.

void COpenGL::LoadTexture(BYTE *pTex, UINT w, UINT h, UINT bpp, UINT format)
{
        if(!IsInitialized())
                return;
        
        if(Texture.ID == 0){
                CreateTexture();
                goto LoadTexJmp;
        }
        
        if(Texture.ID != 0){
                glBindTexture(GL_TEXTURE_2D, Texture.ID);
                
                if(Texture.Width != w || Texture.Height != h || Texture.BPP != bpp || Texture.Format != format){
                        
                        DeleteTexture();
                        CreateTexture();

                        LoadTexJmp:
                        Texture.Width = w;
                        Texture.Height = h;
                        Texture.BPP = bpp;
                        Texture.Format = format;

                        glTexImage2D(GL_TEXTURE_2D, 0, Texture.BPP, Texture.Width, Texture.Height, 0, Texture.Format, GL_UNSIGNED_BYTE, pTex);
                } else {
                        glTexSubImage2D(GL_TEXTURE_2D, 0, 0,0, Texture.Width, Texture.Height, Texture.Format, GL_UNSIGNED_BYTE, pTex);
                }
        }
}

Any idea?

Use another function? Make it private to the class so it is just an implementation detail.

hehe right, i knew i was missing something, thx.

Why do you have an If Not Is Something guarding a return that short circuits the rest of the function? Why don't you just do an If Is Something to guard the entire function?

Why do you have an If Not Is Something guarding a return that short circuits the rest of the function? Why don't you just do an If Is Something to guard the entire function?

Yes, please don't start a goto war, that was not my intention. I decided to keep the goto, after all since it make the code simpler. It's just a tool after all, to use with moderation.

Ex. the code above looked good, but

	if(Texture.ID == 0 || Texture.Width != w || Texture.Height != h || Texture.BPP != bpp || Texture.Format != format) {
		if(Texture.ID != 0)
			DeleteTexture();

In this case, the texture never get deleted, i think. Anyway, it's more confusing than letting it as it is.

Sorry for wasting your time...

This post can be closed.

Why do you have an If Not Is Something guarding a return that short circuits the rest of the function? Why don't you just do an If Is Something to guard the entire function?

It just feeled better that way for that particular pieces of code, this way avoid an extra tab for the code below, i use the other way for shorter function.