Sign in to follow this  
KaiserJohan

OpenGL Deferred shading and point light range issue

Recommended Posts

I'm making a deferred shader and I'm having issue with point lights in that their range dosnt seem to be clamped. 

 

When looking "through" the light volume, the entire area behind it is fully lit. The pictures below shows the problem.

 

I suppose there must be something I am missing when calculating the distance?

 

http://postimg.org/image/65ps4d6qn/

http://postimg.org/image/w7mr7a0rt/

 

Here is the shading pass function (depth testing is disabled aswell):

    void OpenGLRenderer::ShadingPass(const RenderableLighting& lighting)
    {
        GLCALL(glUseProgram(mShadingProgram.mProgramHandle));
        GLCALL(glBindFramebuffer(GL_READ_FRAMEBUFFER, mGBuffer.mFramebuffer));
        GLCALL(glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT));

        // activate all the gbuffer textures
        GLCALL(glActiveTexture(GL_TEXTURE0 + GBuffer::GBUFFER_TEXTURE_POSITION));
        GLCALL(glBindTexture(GL_TEXTURE_2D, mGBuffer.mGBufferTextures[GBuffer::GBUFFER_TEXTURE_POSITION]))
        GLCALL(glGenerateMipmap(GL_TEXTURE_2D));
        GLCALL(glActiveTexture(GL_TEXTURE0 + GBuffer::GBUFFER_TEXTURE_NORMAL));
        GLCALL(glBindTexture(GL_TEXTURE_2D, mGBuffer.mGBufferTextures[GBuffer::GBUFFER_TEXTURE_NORMAL]));
        GLCALL(glGenerateMipmap(GL_TEXTURE_2D));
        GLCALL(glActiveTexture(GL_TEXTURE0 + GBuffer::GBUFFER_TEXTURE_DIFFUSE));
        GLCALL(glBindTexture(GL_TEXTURE_2D, mGBuffer.mGBufferTextures[GBuffer::GBUFFER_TEXTURE_DIFFUSE]));
        GLCALL(glGenerateMipmap(GL_TEXTURE_2D));

        // draw fullscreen rect for ambient light
        mUniBufferShadingPass.SetData(UnifShading(Mat4(1.0f), lighting.mAmbientLight, Vec4(0.0f), lighting.mGamma, lighting.mScreenSize, UnifShading::LIGHT_TYPE_AMBIENT, 0.0f, 0.0f));
        mShadingGeometry.DrawRectangle2D();

        // for point lights
        GLCALL(glEnable(GL_BLEND));
        GLCALL(glBlendEquation(GL_FUNC_ADD));
        GLCALL(glBlendFunc(GL_ONE, GL_ONE));

        // do all point lights
        for (const RenderableLighting::PointLight& pointLight : lighting.mPointLights)
        {
            mUniBufferShadingPass.SetData(UnifShading(pointLight.mWVPMatrix, pointLight.mLightColor, pointLight.mLightPosition, lighting.mGamma, lighting.mScreenSize, UnifShading::LIGHT_TYPE_POINT, pointLight.mFalloffFactor, pointLight.mMaxDistance));
            mShadingGeometry.DrawSphere();
        }

        // reset state
        GLCALL(glDisable(GL_BLEND));
        GLCALL(glBindFramebuffer(GL_READ_FRAMEBUFFER, 0));
        GLCALL(glUseProgram(0));
    }

Here is the shading pass fragment shader:

    const std::string gShadingFragmentShader = 
    "#version 330                                                                                                           \n \
                                                                                                                            \n \
    layout(std140) uniform;                                                                                                 \n \
                                                                                                                            \n \
    uniform UnifShading                                                                                                     \n \
    {                                                                                                                       \n \
        mat4 mWVPMatrix;                                                                                                    \n \
        vec4 mLightColor;                                                                                                   \n \
        vec4 mLightPosOrDir;                                                                                                \n \
        vec4 mGamma;                                                                                                        \n \
        vec2 mScreenSize;                                                                                                   \n \
                                                                                                                            \n \
        int   mLightType;                                                                                                   \n \
        float mFalloffFactor;                                                                                               \n \
        float mMaxDistance;                                                                                                 \n \
    } UnifShadingPass;                                                                                                      \n \
                                                                                                                            \n \
    uniform sampler2D unifPositionTexture;                                                                                  \n \
    uniform sampler2D unifNormalTexture;                                                                                    \n \
    uniform sampler2D unifDiffuseTexture;                                                                                   \n \
                                                                                                                            \n \
    out vec4 fragColor;                                                                                                     \n \
                                                                                                                            \n \
    vec4 CalcPointLight(vec3 worldPos, vec3 normal)                                                                        \n \
    {                                                                                                                       \n \
       vec3 positionDiff = (UnifShadingPass.mLightPosOrDir.xyz - worldPos);                                                   \n \
                                                                                                                              \n \
       float dist = max(length(positionDiff) - UnifShadingPass.mMaxDistance, 0);                                            \n \
                                                                                                                            \n \
       float attenuation = 1 / ((dist / UnifShadingPass.mMaxDistance + 1) * (dist / UnifShadingPass.mMaxDistance + 1));  \n \
       attenuation = max((attenuation - UnifShadingPass.mMaxDistance) / (1 - UnifShadingPass.mMaxDistance), 0);             \n \
                                                                                                                            \n \
       vec3 lightDir = normalize(positionDiff);                                                                             \n \
       float angleNormal = clamp(dot(normalize(normal), lightDir), 0, 1);                                                   \n \
                                                                                                                            \n \
       return angleNormal * attenuation * UnifShadingPass.mLightColor;                                                      \n \
    }                                                                                                                       \n \
                                                                                                                            \n \
    vec4 CalcDirectionalLight(vec3 worldPos, vec3 normal)                                                                  \n \
    {                                                                                                                       \n \
        return UnifShadingPass.mLightColor;  // TODO                                                                                \n \
    }                                                                                                                       \n \
                                                                                                                            \n \
    vec4 CalcAmbientLight()                                                                                                 \n \
    {                                                                                                                       \n \
        return UnifShadingPass.mLightColor;                                                                                 \n \
    }                                                                                                                       \n \
                                                                                                                            \n \
    void main()                                                                                                             \n \
    {                                                                                                                       \n \
        vec2 texcoord = gl_FragCoord.xy / UnifShadingPass.mScreenSize;                                                      \n \
                                                                                                                            \n \
        vec3 worldPos = texture(unifPositionTexture, texcoord).xyz;                                                         \n \
        vec3 normal   = texture(unifNormalTexture, texcoord).xyz;                                                           \n \
        vec3 diffuse  = texture(unifDiffuseTexture, texcoord).xyz;                                                          \n \
        normal        = normalize(normal);                                                                                  \n \
                                                                                                                            \n \
        if (UnifShadingPass.mLightType == 1)                                                                                \n \
            fragColor = vec4(diffuse, 1.0) * CalcPointLight(worldPos, normal);                                              \n \
        else if (UnifShadingPass.mLightType == 2)                                                                           \n \
            fragColor = vec4(diffuse, 1.0) * CalcDirectionalLight(worldPos, normal);                                        \n \
        else if (UnifShadingPass.mLightType == 3)                                                                           \n \
            fragColor = vec4(diffuse, 1.0) * CalcAmbientLight();                                                            \n \
        else                                                                                                                \n \
            fragColor = vec4(diffuse, 0.0);                                                                                 \n \
    }                                                                                                                       \n";
Edited by KaiserJohan

Share this post


Link to post
Share on other sites

It is because you are calculating your light strength at each pixel as 1/r^2 which is physically correct, but when using point light volumes as you are results in the shown issue, There are two options:

1) Change the light strength to being 1 - dis / maxDis which will give you a linear light strength to the edge of the lights 'radius' but isn't physically correct

2) You can change the light volume from being a sphere at the lights position to being a fullscreen quad. This essentially will calculate the light strenght for ALL pixels which is physically accurate since light strength is an inverse squared relationship (1/r^2). Since 1/r^2 will never actually be 0 then your point light will have even a tiny effect on pixels extremely far away and a large effect on very close pixels. 

 

I hope that explains your issue.

Share this post


Link to post
Share on other sites

You can also modify the distance-squared attenuation and force it to reach zero at some point:

atten = 1/(d^2)
threshold = 0.1
newAtten = saturate( (atten-threshold)/(1-threshold) )

Maximum shading radius is where newAtten == 0, or where atten == threshold

e.g.

0.1 == 1/(d^2), solve for d

d = 3.16228

 

[edit] After actually looking at your code, you're already doing something like this unsure.png

Can you explain the theory behind your attenuation formula and the use of the maxDistance parameter?

Edited by Hodgman

Share this post


Link to post
Share on other sites

I'd rather go for 1);

 

Here's what I got then
 

http://postimg.org/image/xtld8cevz/  -  you can see the bounding sphere not touching the chair

http://postimg.org/image/q087316yb/   - it actually lits the chair

 

With the small change to calculate attenuation:

    vec4 CalcPointLight(vec3 worldPos, vec3 normal)                                                                        \n \
    {                                                                                                                       \n \
       vec3 positionDiff = (UnifShadingPass.mLightPosOrDir.xyz - worldPos);                                                   \n \
                                                                                                                              \n \
       float dist = max(length(positionDiff) - UnifShadingPass.mMaxDistance, 0);                                            \n \
                                                                                                                            \n \
       //float attenuation = 1 / ((dist / UnifShadingPass.mMaxDistance + 1) * (dist / UnifShadingPass.mMaxDistance + 1));  \n \
       //attenuation = max((attenuation - UnifShadingPass.mMaxDistance) / (1 - UnifShadingPass.mMaxDistance), 0);             \n \
        float attenuation = 1.0 - (dist / UnifShadingPass.mMaxDistance);                                                                                                                   \n \
       vec3 lightDir = normalize(positionDiff);                                                                             \n \
       float angleNormal = clamp(dot(normalize(normal), lightDir), 0, 1);                                                   \n \
                                                                                                                            \n \
       return angleNormal * attenuation * UnifShadingPass.mLightColor;                                                      \n \
    }                                                                                                                       \n \

Share this post


Link to post
Share on other sites

My idea with max distance is to have it be 0 at maxDistance and 1 at the centre, so it clamps between the two. Then to have an additional parameter, what I call "FalloffFactor" to be how steep the falloff is between 1 and maxdistance

 

At the moment I'm ready to accept the simplest just to get the actual light volume working properly before trying a better formula, as shown it dosnt work properly in the pcitures in the previous post - something is bollocks and I dont know what

 

The light spheres radius is the maxdistance btw

Edited by KaiserJohan

Share this post


Link to post
Share on other sites
 vec4 CalcPointLight(vec3 worldPos, vec3 normal)                                                                        \n \
    {                                                                                                                       \n \
       vec3 positionDiff = (UnifShadingPass.mLightPosOrDir.xyz - worldPos);                                                   \n \
                                                                                                                              \n \
       float dist = length(positionDiff);                                            \n \
                                                                                                                            \n \
        float attenuation = clamp(1.0 - (dist / UnifShadingPass.mMaxDistance), 0.0, 1.0);                                                                                                                   \n \
       vec3 lightDir = normalize(positionDiff);                                                                             \n \
       float angleNormal = clamp(dot(normalize(normal), lightDir), 0, 1);                                                   \n \
                                                                                                                            \n \
       return angleNormal * attenuation * UnifShadingPass.mLightColor;                                                      \n \
    } 

That *should* do it, note how the formula is a little different, also the clamp will tidy things up a little bit. As for your falloff you will need to form some kind off function to get you a desired curve.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628401
    • Total Posts
      2982456
  • Similar Content

    • By test opty
      Hi all,
       
      I'm starting OpenGL using a tut on the Web. But at this point I would like to know the primitives needed for creating a window using OpenGL. So on Windows and using MS VS 2017, what is the simplest code required to render a window with the title of "First Rectangle", please?
       
       
    • By DejayHextrix
      Hi, New here. 
      I need some help. My fiance and I like to play this mobile game online that goes by real time. Her and I are always working but when we have free time we like to play this game. We don't always got time throughout the day to Queue Buildings, troops, Upgrades....etc.... 
      I was told to look into DLL Injection and OpenGL/DirectX Hooking. Is this true? Is this what I need to learn? 
      How do I read the Android files, or modify the files, or get the in-game tags/variables for the game I want? 
      Any assistance on this would be most appreciated. I been everywhere and seems no one knows or is to lazy to help me out. It would be nice to have assistance for once. I don't know what I need to learn. 
      So links of topics I need to learn within the comment section would be SOOOOO.....Helpful. Anything to just get me started. 
      Thanks, 
      Dejay Hextrix 
    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
       
       
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
      Thanks!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
      Thanks.
  • Popular Now