Sign in to follow this  
KaiserJohan

OpenGL Deferred shading and point light range issue

Recommended Posts

KaiserJohan    2317

I'm making a deferred shader and I'm having issue with point lights in that their range dosnt seem to be clamped. 

 

When looking "through" the light volume, the entire area behind it is fully lit. The pictures below shows the problem.

 

I suppose there must be something I am missing when calculating the distance?

 

http://postimg.org/image/65ps4d6qn/

http://postimg.org/image/w7mr7a0rt/

 

Here is the shading pass function (depth testing is disabled aswell):

    void OpenGLRenderer::ShadingPass(const RenderableLighting& lighting)
    {
        GLCALL(glUseProgram(mShadingProgram.mProgramHandle));
        GLCALL(glBindFramebuffer(GL_READ_FRAMEBUFFER, mGBuffer.mFramebuffer));
        GLCALL(glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT));

        // activate all the gbuffer textures
        GLCALL(glActiveTexture(GL_TEXTURE0 + GBuffer::GBUFFER_TEXTURE_POSITION));
        GLCALL(glBindTexture(GL_TEXTURE_2D, mGBuffer.mGBufferTextures[GBuffer::GBUFFER_TEXTURE_POSITION]))
        GLCALL(glGenerateMipmap(GL_TEXTURE_2D));
        GLCALL(glActiveTexture(GL_TEXTURE0 + GBuffer::GBUFFER_TEXTURE_NORMAL));
        GLCALL(glBindTexture(GL_TEXTURE_2D, mGBuffer.mGBufferTextures[GBuffer::GBUFFER_TEXTURE_NORMAL]));
        GLCALL(glGenerateMipmap(GL_TEXTURE_2D));
        GLCALL(glActiveTexture(GL_TEXTURE0 + GBuffer::GBUFFER_TEXTURE_DIFFUSE));
        GLCALL(glBindTexture(GL_TEXTURE_2D, mGBuffer.mGBufferTextures[GBuffer::GBUFFER_TEXTURE_DIFFUSE]));
        GLCALL(glGenerateMipmap(GL_TEXTURE_2D));

        // draw fullscreen rect for ambient light
        mUniBufferShadingPass.SetData(UnifShading(Mat4(1.0f), lighting.mAmbientLight, Vec4(0.0f), lighting.mGamma, lighting.mScreenSize, UnifShading::LIGHT_TYPE_AMBIENT, 0.0f, 0.0f));
        mShadingGeometry.DrawRectangle2D();

        // for point lights
        GLCALL(glEnable(GL_BLEND));
        GLCALL(glBlendEquation(GL_FUNC_ADD));
        GLCALL(glBlendFunc(GL_ONE, GL_ONE));

        // do all point lights
        for (const RenderableLighting::PointLight& pointLight : lighting.mPointLights)
        {
            mUniBufferShadingPass.SetData(UnifShading(pointLight.mWVPMatrix, pointLight.mLightColor, pointLight.mLightPosition, lighting.mGamma, lighting.mScreenSize, UnifShading::LIGHT_TYPE_POINT, pointLight.mFalloffFactor, pointLight.mMaxDistance));
            mShadingGeometry.DrawSphere();
        }

        // reset state
        GLCALL(glDisable(GL_BLEND));
        GLCALL(glBindFramebuffer(GL_READ_FRAMEBUFFER, 0));
        GLCALL(glUseProgram(0));
    }

Here is the shading pass fragment shader:

    const std::string gShadingFragmentShader = 
    "#version 330                                                                                                           \n \
                                                                                                                            \n \
    layout(std140) uniform;                                                                                                 \n \
                                                                                                                            \n \
    uniform UnifShading                                                                                                     \n \
    {                                                                                                                       \n \
        mat4 mWVPMatrix;                                                                                                    \n \
        vec4 mLightColor;                                                                                                   \n \
        vec4 mLightPosOrDir;                                                                                                \n \
        vec4 mGamma;                                                                                                        \n \
        vec2 mScreenSize;                                                                                                   \n \
                                                                                                                            \n \
        int   mLightType;                                                                                                   \n \
        float mFalloffFactor;                                                                                               \n \
        float mMaxDistance;                                                                                                 \n \
    } UnifShadingPass;                                                                                                      \n \
                                                                                                                            \n \
    uniform sampler2D unifPositionTexture;                                                                                  \n \
    uniform sampler2D unifNormalTexture;                                                                                    \n \
    uniform sampler2D unifDiffuseTexture;                                                                                   \n \
                                                                                                                            \n \
    out vec4 fragColor;                                                                                                     \n \
                                                                                                                            \n \
    vec4 CalcPointLight(vec3 worldPos, vec3 normal)                                                                        \n \
    {                                                                                                                       \n \
       vec3 positionDiff = (UnifShadingPass.mLightPosOrDir.xyz - worldPos);                                                   \n \
                                                                                                                              \n \
       float dist = max(length(positionDiff) - UnifShadingPass.mMaxDistance, 0);                                            \n \
                                                                                                                            \n \
       float attenuation = 1 / ((dist / UnifShadingPass.mMaxDistance + 1) * (dist / UnifShadingPass.mMaxDistance + 1));  \n \
       attenuation = max((attenuation - UnifShadingPass.mMaxDistance) / (1 - UnifShadingPass.mMaxDistance), 0);             \n \
                                                                                                                            \n \
       vec3 lightDir = normalize(positionDiff);                                                                             \n \
       float angleNormal = clamp(dot(normalize(normal), lightDir), 0, 1);                                                   \n \
                                                                                                                            \n \
       return angleNormal * attenuation * UnifShadingPass.mLightColor;                                                      \n \
    }                                                                                                                       \n \
                                                                                                                            \n \
    vec4 CalcDirectionalLight(vec3 worldPos, vec3 normal)                                                                  \n \
    {                                                                                                                       \n \
        return UnifShadingPass.mLightColor;  // TODO                                                                                \n \
    }                                                                                                                       \n \
                                                                                                                            \n \
    vec4 CalcAmbientLight()                                                                                                 \n \
    {                                                                                                                       \n \
        return UnifShadingPass.mLightColor;                                                                                 \n \
    }                                                                                                                       \n \
                                                                                                                            \n \
    void main()                                                                                                             \n \
    {                                                                                                                       \n \
        vec2 texcoord = gl_FragCoord.xy / UnifShadingPass.mScreenSize;                                                      \n \
                                                                                                                            \n \
        vec3 worldPos = texture(unifPositionTexture, texcoord).xyz;                                                         \n \
        vec3 normal   = texture(unifNormalTexture, texcoord).xyz;                                                           \n \
        vec3 diffuse  = texture(unifDiffuseTexture, texcoord).xyz;                                                          \n \
        normal        = normalize(normal);                                                                                  \n \
                                                                                                                            \n \
        if (UnifShadingPass.mLightType == 1)                                                                                \n \
            fragColor = vec4(diffuse, 1.0) * CalcPointLight(worldPos, normal);                                              \n \
        else if (UnifShadingPass.mLightType == 2)                                                                           \n \
            fragColor = vec4(diffuse, 1.0) * CalcDirectionalLight(worldPos, normal);                                        \n \
        else if (UnifShadingPass.mLightType == 3)                                                                           \n \
            fragColor = vec4(diffuse, 1.0) * CalcAmbientLight();                                                            \n \
        else                                                                                                                \n \
            fragColor = vec4(diffuse, 0.0);                                                                                 \n \
    }                                                                                                                       \n";
Edited by KaiserJohan

Share this post


Link to post
Share on other sites
RnaodmBiT    1096

It is because you are calculating your light strength at each pixel as 1/r^2 which is physically correct, but when using point light volumes as you are results in the shown issue, There are two options:

1) Change the light strength to being 1 - dis / maxDis which will give you a linear light strength to the edge of the lights 'radius' but isn't physically correct

2) You can change the light volume from being a sphere at the lights position to being a fullscreen quad. This essentially will calculate the light strenght for ALL pixels which is physically accurate since light strength is an inverse squared relationship (1/r^2). Since 1/r^2 will never actually be 0 then your point light will have even a tiny effect on pixels extremely far away and a large effect on very close pixels. 

 

I hope that explains your issue.

Share this post


Link to post
Share on other sites
Hodgman    51336

You can also modify the distance-squared attenuation and force it to reach zero at some point:

atten = 1/(d^2)
threshold = 0.1
newAtten = saturate( (atten-threshold)/(1-threshold) )

Maximum shading radius is where newAtten == 0, or where atten == threshold

e.g.

0.1 == 1/(d^2), solve for d

d = 3.16228

 

[edit] After actually looking at your code, you're already doing something like this unsure.png

Can you explain the theory behind your attenuation formula and the use of the maxDistance parameter?

Edited by Hodgman

Share this post


Link to post
Share on other sites
KaiserJohan    2317

I'd rather go for 1);

 

Here's what I got then
 

http://postimg.org/image/xtld8cevz/  -  you can see the bounding sphere not touching the chair

http://postimg.org/image/q087316yb/   - it actually lits the chair

 

With the small change to calculate attenuation:

    vec4 CalcPointLight(vec3 worldPos, vec3 normal)                                                                        \n \
    {                                                                                                                       \n \
       vec3 positionDiff = (UnifShadingPass.mLightPosOrDir.xyz - worldPos);                                                   \n \
                                                                                                                              \n \
       float dist = max(length(positionDiff) - UnifShadingPass.mMaxDistance, 0);                                            \n \
                                                                                                                            \n \
       //float attenuation = 1 / ((dist / UnifShadingPass.mMaxDistance + 1) * (dist / UnifShadingPass.mMaxDistance + 1));  \n \
       //attenuation = max((attenuation - UnifShadingPass.mMaxDistance) / (1 - UnifShadingPass.mMaxDistance), 0);             \n \
        float attenuation = 1.0 - (dist / UnifShadingPass.mMaxDistance);                                                                                                                   \n \
       vec3 lightDir = normalize(positionDiff);                                                                             \n \
       float angleNormal = clamp(dot(normalize(normal), lightDir), 0, 1);                                                   \n \
                                                                                                                            \n \
       return angleNormal * attenuation * UnifShadingPass.mLightColor;                                                      \n \
    }                                                                                                                       \n \

Share this post


Link to post
Share on other sites
KaiserJohan    2317

My idea with max distance is to have it be 0 at maxDistance and 1 at the centre, so it clamps between the two. Then to have an additional parameter, what I call "FalloffFactor" to be how steep the falloff is between 1 and maxdistance

 

At the moment I'm ready to accept the simplest just to get the actual light volume working properly before trying a better formula, as shown it dosnt work properly in the pcitures in the previous post - something is bollocks and I dont know what

 

The light spheres radius is the maxdistance btw

Edited by KaiserJohan

Share this post


Link to post
Share on other sites
RnaodmBiT    1096
 vec4 CalcPointLight(vec3 worldPos, vec3 normal)                                                                        \n \
    {                                                                                                                       \n \
       vec3 positionDiff = (UnifShadingPass.mLightPosOrDir.xyz - worldPos);                                                   \n \
                                                                                                                              \n \
       float dist = length(positionDiff);                                            \n \
                                                                                                                            \n \
        float attenuation = clamp(1.0 - (dist / UnifShadingPass.mMaxDistance), 0.0, 1.0);                                                                                                                   \n \
       vec3 lightDir = normalize(positionDiff);                                                                             \n \
       float angleNormal = clamp(dot(normalize(normal), lightDir), 0, 1);                                                   \n \
                                                                                                                            \n \
       return angleNormal * attenuation * UnifShadingPass.mLightColor;                                                      \n \
    } 

That *should* do it, note how the formula is a little different, also the clamp will tidy things up a little bit. As for your falloff you will need to form some kind off function to get you a desired curve.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By pseudomarvin
      I assumed that if a shader is computationally expensive then the execution is just slower. But running the following GLSL FS instead just crashes
      void main() { float x = 0; float y = 0; int sum = 0; for (float x = 0; x < 10; x += 0.00005) { for (float y = 0; y < 10; y += 0.00005) { sum++; } } fragColor = vec4(1, 1, 1 , 1.0); } with unhandled exception in nvoglv32.dll. Are there any hard limits on the number of steps/time that a shader can take before it is shut down? I was thinking about implementing some time intensive computation in shaders where it would take on the order of seconds to compute a frame, is that possible? Thanks.
    • By Arulbabu Donbosco
      There are studios selling applications which is just copying any 3Dgraphic content and regenerating into another new window. especially for CAVE Virtual reality experience. so that the user opens REvite or CAD or any other 3D applications and opens a model. then when the user selects the rendered window the VR application copies the 3D model information from the OpenGL window. 
      I got the clue that the VR application replaces the windows opengl32.dll file. how this is possible ... how can we copy the 3d content from the current OpenGL window.
      anyone, please help me .. how to go further... to create an application like VR CAVE. 
       
      Thanks
    • By cebugdev
      hi all,

      i am trying to build an OpenGL 2D GUI system, (yeah yeah, i know i should not be re inventing the wheel, but this is for educational and some other purpose only),
      i have built GUI system before using 2D systems such as that of HTML/JS canvas, but in 2D system, i can directly match a mouse coordinates to the actual graphic coordinates with additional computation for screen size/ratio/scale ofcourse.
      now i want to port it to OpenGL, i know that to render a 2D object in OpenGL we specify coordiantes in Clip space or use the orthographic projection, now heres what i need help about.
      1. what is the right way of rendering the GUI? is it thru drawing in clip space or switching to ortho projection?
      2. from screen coordinates (top left is 0,0 nd bottom right is width height), how can i map the mouse coordinates to OpenGL 2D so that mouse events such as button click works? In consideration ofcourse to the current screen/size dimension.
      3. when let say if the screen size/dimension is different, how to handle this? in my previous javascript 2D engine using canvas, i just have my working coordinates and then just perform the bitblk or copying my working canvas to screen canvas and scale the mouse coordinates from there, in OpenGL how to work on a multiple screen sizes (more like an OpenGL ES question).
      lastly, if you guys know any books, resources, links or tutorials that handle or discuss this, i found one with marekknows opengl game engine website but its not free,
      Just let me know. Did not have any luck finding resource in google for writing our own OpenGL GUI framework.
      IF there are no any available online, just let me know, what things do i need to look into for OpenGL and i will study them one by one to make it work.
      thank you, and looking forward to positive replies.
    • By fllwr0491
      I have a few beginner questions about tesselation that I really have no clue.
      The opengl wiki doesn't seem to talk anything about the details.
       
      What is the relationship between TCS layout out and TES layout in?
      How does the tesselator know how control points are organized?
          e.g. If TES input requests triangles, but TCS can output N vertices.
             What happens in this case?
      In this article,
      http://www.informit.com/articles/article.aspx?p=2120983
      the isoline example TCS out=4, but TES in=isoline.
      And gl_TessCoord is only a single one.
      So which ones are the control points?
      How are tesselator building primitives?
    • By Orella
      I've been developing a 2D Engine using SFML + ImGui.
      Here you can see an image
      The editor is rendered using ImGui and the scene window is a sf::RenderTexture where I draw the GameObjects and then is converted to ImGui::Image to render it in the editor.
      Now I need to create a 3D Engine during this year in my Bachelor Degree but using SDL2 + ImGui and I want to recreate what I did with the 2D Engine. 
      I've managed to render the editor like I did in the 2D Engine using this example that comes with ImGui. 
      3D Editor preview
      But I don't know how to create an equivalent of sf::RenderTexture in SDL2, so I can draw the 3D scene there and convert it to ImGui::Image to show it in the editor.
      If you can provide code will be better. And if you want me to provide any specific code tell me.
      Thanks!
  • Popular Now