Sign in to follow this  
axel1994

OpenGL Drawing texture problem

Recommended Posts

Hello,

 

I got a problem when I'm trying to draw a texture on a object (a rectangle in this case)

I don't think there is any problem in the shaders, but I'll give them either way.

Vertex shader:

#version 330

layout (location=0) in vec3 position;
layout (location=1) in vec2 uvcoor0;

out vec2 uvcoor;

void main() {
	gl_Position = vec4(position, 1.0);
	uvcoor = uvcoor0;
}

Fragment shader:

#version 330

uniform sampler2D tex;
in vec2 uvcoor;                                                                 
                                                                                   
void main() {                                                                                  
	gl_FragColor = texture2D(tex, uvcoor.st);                                                 
}

The code I'm using:

For the uv buffer

here I have an struct where I store the length and the actual uv coordinates

texturecoor.len = 4;
Vector2f vec;
texturecoor.texcor = new Vector2f[4];
vec.x = 1;
vec.y = 1;
texturecoor.texcor[0] = vec;
vec.x = 0;
vec.y = 1;
texturecoor.texcor[1] = vec;
vec.x = 1;
vec.y = 0;
texturecoor.texcor[3] = vec;
vec.x = 0;
vec.y = 0;
texturecoor.texcor[2] = vec;

The vertex and index coordinates are located in an .obj file that I load.

That works correctly (since I can draw the rect with a color instead of a texture.

Here is the obj file,

The index int are read in the exact same order.

Each vertex line is in xyz

# Blender v2.69 (sub 0) OBJ File: ''
# www.blender.org

o Plane
v 1.000000 1.000000 0.000000
v -1.000000 1.000000 0.000000
v 1.000000 -1.000000 0.000000
v -1.000000 -1.000000 0.000000

f 2 3 0
f 1 0 3

Loading the texture I use:

str is the relative path, load_image returns an image object that stores the width, height and data

GLuint texture;
image img = load_image(str);

glGenTextures(1, &texture);
glBindTexture(GL_TEXTURE_2D, texture);

glTexImage2D(GL_TEXTURE_2D,0, GL_RGB, img.width, img.height, 0, GL_BGRA, GL_UNSIGNED_BYTE, img.data);

destroyImg(img);

return texture;

loading everything into opengl I use the code:

(this is after I loaded all data in the buffers)

but for reference, here is my loading of my uvbuffer

(ttx is the data of the uv coordinates)

glGenBuffers(1, &uvbuffer);

glBindBuffer(GL_ARRAY_BUFFER, uvbuffer);
glBufferData(GL_ARRAY_BUFFER,sizeof(ttx), ttx, GL_DYNAMIC_DRAW);
glGenVertexArrays(1,&vao);
glBindVertexArray(vao);

glBindBuffer(GL_ARRAY_BUFFER, vertexbuffer);
glEnableVertexAttribArray(0);
glVertexAttribPointer(0, 3, GL_FLOAT, GL_FALSE, 0, 0);

if (uv) {
	glBindBuffer(GL_ARRAY_BUFFER, uvbuffer);
	glEnableVertexAttribArray(1);
        glVertexAttribPointer(1, 3, GL_FLOAT, GL_FALSE, 0, 0);
}

glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, indexbuffer);
glBindVertexArray(0);

When rendering I bind the texture, bind the vao and draw all triangles: (nbElem is the number of index elements)

glActiveTexture(GL_TEXTURE_2D);
glBindTexture(GL_TEXTURE_2D, texture);

glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_BORDER);
glTexParameteri (GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_BORDER);
glTexParameteri (GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);

glTexParameteri (GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
//bind the vao (didnt copy that line of code)
glDrawElements(GL_TRIANGLES, nbElem, GL_UNSIGNED_INT, 0);

The included pictures are:

the image I load in

the image resulting on the screen

(I got the image from some examples pictures that came with the image loading lib I'm using)

 

It's not correct, but it also draws the image twice.

Once normally and once turned 90 degrees

 

what I've tried doing is, changing the texture coordinates order.

But the order I have now (0,1,3,2) gives the best result.

 

I also have a world matrix to represent a camera.
I multiple this camera with only the vertices (not with the uv coordinates)

 

Even without using the camera, I get exactly the same result.

Another issue, which I believe is part of this problem.

 

If I zoom out with my camera, the texture changes.

The more zoomed out, the more correct the image is displaying.

 

I did check the camera. But without a texture the camera works perfectly.

 

My apologies if I didn't include enough information.

 

[attachment=19229:img_cheryl.jpg]

[attachment=19230:tex.png]

Edited by axel1994

Share this post


Link to post
Share on other sites

I took a glance at your code, it all looks pretty good except one thing. This bit of code to set up the texture coordinate attribute looks wrong:

if (uv) {
	glBindBuffer(GL_ARRAY_BUFFER, uvbuffer);
	glEnableVertexAttribArray(1);
        glVertexAttribPointer(1, 3, GL_FLOAT, GL_FALSE, 0, 0); // 3 components? Should be 2, since you only declare uvcoor0 as a vec2
}

Looks like that should read glVertexAttribPointer(1, 2, GL_FLOAT, GL_FALSE, 0, 0); since your texture coordinates are only two components wide.

Share this post


Link to post
Share on other sites

I took a glance at your code, it all looks pretty good except one thing. This bit of code to set up the texture coordinate attribute looks wrong:

if (uv) {
	glBindBuffer(GL_ARRAY_BUFFER, uvbuffer);
	glEnableVertexAttribArray(1);
        glVertexAttribPointer(1, 3, GL_FLOAT, GL_FALSE, 0, 0); // 3 components? Should be 2, since you only declare uvcoor0 as a vec2
}

Looks like that should read glVertexAttribPointer(1, 2, GL_FLOAT, GL_FALSE, 0, 0); since your texture coordinates are only two components wide.

Ow, damn

Thank you so much. biggrin.png

 

Can't believe I spend 2 days looking for that.

Now It works perfectly.

 

I now found that the order of texture coordinates should be 0,1,2,3.

Now the image shows amazing.

 

It works great along with the camera

Edited by axel1994

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628401
    • Total Posts
      2982457
  • Similar Content

    • By test opty
      Hi all,
       
      I'm starting OpenGL using a tut on the Web. But at this point I would like to know the primitives needed for creating a window using OpenGL. So on Windows and using MS VS 2017, what is the simplest code required to render a window with the title of "First Rectangle", please?
       
       
    • By DejayHextrix
      Hi, New here. 
      I need some help. My fiance and I like to play this mobile game online that goes by real time. Her and I are always working but when we have free time we like to play this game. We don't always got time throughout the day to Queue Buildings, troops, Upgrades....etc.... 
      I was told to look into DLL Injection and OpenGL/DirectX Hooking. Is this true? Is this what I need to learn? 
      How do I read the Android files, or modify the files, or get the in-game tags/variables for the game I want? 
      Any assistance on this would be most appreciated. I been everywhere and seems no one knows or is to lazy to help me out. It would be nice to have assistance for once. I don't know what I need to learn. 
      So links of topics I need to learn within the comment section would be SOOOOO.....Helpful. Anything to just get me started. 
      Thanks, 
      Dejay Hextrix 
    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
       
       
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
      Thanks!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
      Thanks.
  • Popular Now