• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
BrentMorris

DX11
Gamma Correction Issues

6 posts in this topic

I'm trying to get gamma correction to work in my DX11 tile deferred renderer, but something in my pipeline must be doing something that I don't realize.

 

When I manually do gamma correction with pow(color, 2.2) and pow(finalColor, 1.0/2.2) it looks great! When I use the sRGB formats it appears way too bright.

 

My pipeline is as follows.

 

1. Create diffuse G-Buffer by reading from sRGB textures and writing to a sRGB render target. This is a pass-through.

2. Perform lighting in compute shader. Read from the sRGB diffuse G-buffer and compute lighting. Write the result to a DXGI_FORMAT_R16G16B16A16_FLOAT. I can't use an sRGB write format here because I have to write the result into a UAV.

3. Run post-processing. Read from the DXGI_FORMAT_R16G16B16A16_FLOAT and write down to the sRGB render target back buffer to be presented to the screen. I've disabled post-processing steps for the moment so this is just a pass-through.

4. Present.

 

What am I missing? >_>

 

Also, thanks!

Edited by DementedCarrot
0

Share this post


Link to post
Share on other sites
How do you read from the G-Buffer in step #2?

I can't use an sRGB write format here because I have to write the result into a UAV.

You also can't use sRGB here because your values are HDR/outside of the 0.0 - 1.0 range. Lighting values should be in linear RGB.

When I manually do gamma correction with pow(color, 2.2) and pow(finalColor, 1.0/2.2) it looks great!

 Does this mean that your pipeline looks like one of these?
1.a Create diffuse G-Buffer by reading from textures and writing to a render target. This is a pass-through.
1.b Create diffuse G-Buffer by reading from sRGB textures and writing to a gamma render target with return rgb1/2.2.
1.c Create diffuse G-Buffer by reading from textures, converting to linear with rgb2.2 and writing to a gamma render target with return rgb1/2.2. These two operations cancel out, so I may as well be using 1.a if optimization was a concern.
2. Perform lighting in compute shader. Read from the gamma diffuse G-buffer, convert to linear with rgb2.2 and compute lighting. Write the result to a DXGI_FORMAT_R16G16B16A16_FLOAT.
3. Run post-processing. Read from the DXGI_FORMAT_R16G16B16A16_FLOAT and write down to the gamma render target back buffer (using return rgb1/2.2) to be presented to the screen. I've disabled post-processing steps for the moment so this is just a gamma correction pass.
4. Present. Edited by Hodgman
1

Share this post


Link to post
Share on other sites

I read from a sRGB texture and write to the sRGB diffuse G-Buffer render target. I assume DirectX uses the same gamma on the reads/writes. That is 1.b I believe.

 

I guess I'll rephrase!

 

- While creating G-buffers.

1. Read from sRGB texture.

2. Write to the sRGB diffuse G-buffer, which is the back buffer at this point.

 

- In lighting compute shader.

3. Read from sRGB diffuse G-buffer

5. Do lighting.

4. Write unmodified value to the DXGI_FORMAT_R16G16B16A16_FLOAT

 

- In gamma correction pass

5. Read from DXGI_FORMAT_R16G16B16A16_FLOAT

6. Write the value to the sRGB back buffer.

 

7. Present

 

Edit:

I'm reading from the textures in the compute shader with direct brackets, like diffuseTexture[texCoord]. I changed it to use a point texture sampler with SampleLevel() but it didn't change anything.

Edited by DementedCarrot
0

Share this post


Link to post
Share on other sites

I'm starting to think that I've gotten gamma correction working, and that it is really just brighter than I expected it to be without modifying the light values.

 

If a lit render that isn't gamma corrected is compared to the same scene when it is gamma corrected, will it be brighter?

Edited by DementedCarrot
0

Share this post


Link to post
Share on other sites

If in your last pass before presenting you are writing linear values to the sRGB framebuffer, then everything should be correct. When done correctly, gamma correction usually throw people off because even though correct, the scene is usually brighter than a corresponding no gamma corrected scene.

0

Share this post


Link to post
Share on other sites

You haven't been too clear on this, so I'd like to ask: are you converting your sRGB results to linear before lighting?

 

It should be like this:

 

  1. Read textures from sRGB. Output to non-sRGB G-Buffer (or, decode from sRGB, and output to sRGB G-Buffer, but that's wasting cycles).
  2. Read G-Buffer during light stage. Convert G-Buffer values to non-sRGB values. Perform lighting in linear space. Output unmodified to ARGB16.
  3. Read lighting values, write to sRGB back-buffer.

 

 

I'm actually curious what that last stage is supposed to be doing. Is it tone-mapping or something?

Edited by Styves
0

Share this post


Link to post
Share on other sites

Yeah, the last stage is supposed to be for tone-mapping and other post processing stuff.

 

I'm hopeful that tone mapping alone will fix my brightness problem.

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • By lonewolff
      Hi Guys,
      I am just wondering if it is possible to acquire the address of the backbuffer if an API (based on DX11) only exposes the 'device' and 'context' pointers?
      Any advice would be greatly appreciated
    • By MarcusAseth
      bool InitDirect3D::Init() { if (!D3DApp::Init()) { return false; } //Additional Initialization //Disable Alt+Enter Fullscreen Toggle shortkey IDXGIFactory* factory; CreateDXGIFactory(__uuidof(IDXGIFactory), reinterpret_cast<void**>(&factory)); factory->MakeWindowAssociation(mhWindow, DXGI_MWA_NO_WINDOW_CHANGES); factory->Release(); return true; }  
      As stated on the title and displayed on the code above, regardless of it Alt+Enter still takes effect...
      I recall something from the book during the swapChain creation, where in order to create it one has to use the same factory used to create the ID3D11Device, therefore I tested and indeed using that same factory indeed it work.
      How is that one particular factory related to my window and how come the MakeWindowAssociation won't take effect with a newly created factory?
      Also what's even the point of being able to create this Factories if they won't work,?(except from that one associated with the ID3D11Device) 
    • By ProfL
      Can anyone recommend a wrapper for Direct3D 11 that is similarly simple to use as SFML? I don't need all the image formats etc. BUT I want a simple way to open a window, allocate a texture, buffer, shader.
    • By lucky6969b
      Q1:
      Since there is no more fixed pipeline rendering in DX11, for every part of rendering in DX11, do I need to create a brand-new vertex shader and pixel shader... or at least I have to find one relevant online. If you work on skinned meshes and other effects originally worked in DX9 fixed pipeline, do I have to rework everything by now?
       
      Q2:
      For assimp, if it originally was designed for DX9, like it is coupled to a DX9 device for creating meshes and materials etc. Do I have to add in the DX11 device in the assimp, or can I just leave the assimp to remain in DX9 and after the meshes are loaded, I just convert the vertex buffers and index buffers into DX11 buffers?
      Thanks
      Jack
    • By MarcusAseth
      This header is mentioned in the book I'm reading but there is no documentation on msdn... Is it like an... outdated and abandoned header?
      If so, what's the current default/recomended library for handling errors with directX?
  • Popular Now