Advertisement Jump to content
Sign in to follow this  
iraxef

[PATCH] curly braces around some asserts

This topic is 1828 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

The attached/proposed patch addresses a handful of if's/else's which are immediately followed by an asASSERT(), without any curly braces. In case the underlying assert is compiled out entirely, this can lead to unintended consequences.

 

For example:

Index: as_symboltable.h
===================================================================
--- as_symboltable.h	(revision 1811)
+++ as_symboltable.h	(working copy)
@@ -380,7 +380,9 @@
 			m_map.Erase(cursor);
 	}
 	else
+    {
 		asASSERT(false);
+    }

Share this post


Link to post
Share on other sites
Advertisement

This shouldn't be a problem. if asASSERT() is defined to blank, the resulting code after preprocessing is:

 

 
@@ -380,7 +380,9 @@
            m_map.Erase(cursor);
    }
    else
        ;

 

The ; ends the else, so there is no unintended consequence.

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

GameDev.net is your game development community. Create an account for your GameDev Portfolio and participate in the largest developer community in the games industry.

Sign me up!