• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
NUCLEAR RABBIT

C If Statement Question

14 posts in this topic


Run that program with any invalid input (any non-numerical value will do) and your program is instantly in "undefined behaviour" territory.
I can even see it happening: all output happening virtually instantly and it returns 0, as if nothing had gone wrong.
0

Share this post


Link to post
Share on other sites

This is just a nitpick, but I believe that `int main(int argc, const char * argv[])` is, in fact, not a valid signature for `main` function. Standard sayeth `int main(void)`, `int main(int argc, char* argv[])` or equivalent.

0

Share this post


Link to post
Share on other sites

I personally don't 'like' the 'large' set of if statements (personal probably..).

But honestly I don't know how you can handle it differently, since a switch statement won't take operators < or >

0

Share this post


Link to post
Share on other sites

It is generally a good idea to keep input, output and computation separate. In that spirit, it would be good to have something like this function:

 

enum Grade {
  Grade_F,
  Grade_D,
  Grade_C,
  Grade_B,
  Grade_A,
};

enum Grade compute_grade(int score) {
  static int const grade_cuts[4] = {60, 70, 80, 90};
  int grade;

  for (grade = 0; grade < 4; ++grade)
    if (score < grade_cuts[grade])
      break;

  return grade;
}
0

Share this post


Link to post
Share on other sites

Thanks for the replies! Just one more question, not too sure I understand correctly, but how come you created the Grade enum but don't use it in the code and also how come you had it returns an int instead of enum in the compute_grade function? Much appreciated! biggrin.png

 

 

It is generally a good idea to keep input, output and computation separate. In that spirit, it would be good to have something like this function:

enum Grade {
  Grade_F,
  Grade_D,
  Grade_C,
  Grade_B,
  Grade_A,
};

enum Grade compute_grade(int score) {
  static int const grade_cuts[4] = {60, 70, 80, 90};
  int grade;

  for (grade = 0; grade < 4; ++grade)
    if (score < grade_cuts[grade])
      break;

  return grade;
}
0

Share this post


Link to post
Share on other sites

Never mind my last questions, I played around with the code you gave me and got whats going on, thanks! cool.png

 

 

Thanks for the replies! Just one more question, not too sure I understand correctly, but how come you created the Grade enum but don't use it in the code and also how come you had it returns an int instead of enum in the compute_grade function? Much appreciated! biggrin.png

 

 

It is generally a good idea to keep input, output and computation separate. In that spirit, it would be good to have something like this function:

enum Grade {
  Grade_F,
  Grade_D,
  Grade_C,
  Grade_B,
  Grade_A,
};

enum Grade compute_grade(int score) {
  static int const grade_cuts[4] = {60, 70, 80, 90};
  int grade;

  for (grade = 0; grade < 4; ++grade)
    if (score < grade_cuts[grade])
      break;

  return grade;
}

 

Edited by NUCLEAR RABBIT
0

Share this post


Link to post
Share on other sites

4 looks like a bit of a magic number though, Al, I am disappoint.


Well, I could have left the size of the array implicit in the initialization, and then used sizeof(grade_cuts)/sizeof(*grade_cuts) to recover the 4 in the loop, but I think that would have detracted from the code's clarity, which would be especially bad "For Beginners". In C++ (especially C++11) there are better solutions, but this is a C thread.

EDIT: Here's a version with no magic numbers, and with the grade cuts defined in one place and one place only. If you want to understand how it works, ask Shiftie. smile.png
 

#include <stddef.h>

#define ARRAY_LENGTH(X) (sizeof(X) / sizeof(*X))

#define GRADES_AND_CUTS \
  G_A_C(F, 0)		\
  G_A_C(D, 60)		\
  G_A_C(C, 70)		\
  G_A_C(B, 80)		\
  G_A_C(A, 90)

#define G_A_C(X,Y) Grade_##X ,
enum Grade { GRADES_AND_CUTS };
#undef G_A_C

enum Grade compute_grade(int score) {
#define G_A_C(X,Y) Y ,
  static int const grade_cuts[] = {GRADES_AND_CUTS};
#undef G_A_C
  unsigned grade;

  for (grade = 1; grade < ARRAY_LENGTH(grade_cuts); ++grade)
    if (score < grade_cuts[grade])
      break;

  return grade - 1;
}

char const *grade_name(enum Grade grade) {
#define G_A_C(X,Y) #X ,
  static char const *grade_name_table[] = {GRADES_AND_CUTS};
#undef G_A_C
  return grade_name_table[grade];
}

Edited by Álvaro
1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0