• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Flandria4

Basic console project

4 posts in this topic

Hey

 

I'm trying to make a simple calculator, at this point I can't even get the input right.

I know my code is kinda ugly but afaik it should work.

int _tmain(int argc, _TCHAR* argv[])
{
	int get1=0, get2=0;
	cout << "Binary operation" << endl;
	
	//cin.get();
	do 
	{
		if(get1==0)cout << "Enter first operand (integer): >";
		if (!(cin >> get1) && get1==0) {
			cout << "Did you even try?" << endl;
			cin.clear();
			cin.ignore(1000, '\n');
		}
		else {
			if(get2==0)cout << "Enter second operand (integer): >";
			if (!(cin >> get2)){
				cout << "Cmon! You can do it!" << endl;
				cin.clear();
				cin.ignore(1000, '\n');
			}
			else cout << "Good boy! Press ENTER to continue" << endl;		
		}
		
	} while (get1==0 || get2==0);

	return 0;
}

This is how the console responds: 

37a97000f7.png

 

Why do I get an blanc line on the end instead of the line "Enter second operand (integer): >" ?

What should I change?

 

Thanks in advance!

0

Share this post


Link to post
Share on other sites

EDIT: Careful ... read my other post ... I was too quick ... and wrong ;-)

 

Any reason why the cin >> get1 is part of the condition? I don't know what kind of operator >> is exactly and what the operation should return, but it seems to evaluate as false and that is probably why the else is never executed.

 

With get1 you have the additional "&& get1==0" ... you could add that to the 2nd condition as well ...

 

But would't that work?

		cin >> get1;
		if (get1==0) {
			cout << "Did you even try?" << endl;
			cin.clear();
			cin.ignore(1000, '\n');
		}
		else {
			if(get2==0)cout << "Enter second operand (integer): >";
			cin >> get2;
			if (get2==0){
				cout << "Cmon! You can do it!" << endl;
				cin.clear();
				cin.ignore(1000, '\n');
			}
			else cout << "Good boy! Press ENTER to continue" << endl;		
		}

That still would not be quite pretty, though ... but you know that :-)

 

EDIT: Careful ... read my other post ... I was too quick ... and wrong ;-)

Edited by DareDeveloper
1

Share this post


Link to post
Share on other sites

It happens because get1 isn't 0, so it fails the initial if(get1==0) test when you insert something invalid on the second operand.

 

You could add a get1 = 0 after your cout << "Cmon[...]":

			if (!(cin >> get2)){
				cout << "Cmon! You can do it!" << endl;
				get1 = 0;

But I don't know if this will break other stuff, I don't really understand what your code is supposed to do.

0

Share this post


Link to post
Share on other sites

No wait ... the 2nd time the loop is performed ... if(get1==0)cout << "Enter first operand (integer): >"; is not shown because get1 is not 0 ... but you read get1 again because cin >> get1 is called again ... so you need to find a different approach I guess. Probably turning

 

if(get1==0)cout << "Enter first operand (integer): >";

 

into a grown up If-Block is the first step to doing that ... maybe turning it into a regular while loop instead of do ... while ...

 

 

... or ...

int _tmain(int argc, _TCHAR* argv[])
{
	int get1=0, get2=0;
	cout << "Binary operation" << endl;
	
	do 
	{
		cout << "Enter first operand (integer): >";
		cin >> get1;
		if (get1==0) {
			cout << "Did you even try?" << endl;
			cin.clear();
			cin.ignore(1000, '\n');
		}
	} while (get1==0);

	do 
	{
		cout << "Enter second operand (integer): >";
		cin >> get2;
		if (get2==0){
			cout << "Cmon! You can do it!" << endl;
			cin.clear();
			cin.ignore(1000, '\n');
		}
		
	} while (get2==0);

	cout << "Good boy! Press ENTER to continue" << endl;

	return 0;
}

Is that any good?

Edited by DareDeveloper
0

Share this post


Link to post
Share on other sites

Thanks for your replies,

 

The cin >> get1 operation waits on an input and puts the entered number in get1 and checks if the operation was valid.

 

The problem was indeed that after entering an non integral number this code did not jump back to the "else"  but it waits on  cin >> get1 (again!) before concluding the statement is false anyway, because get1==0 is should be false at this point.

 

The solution is:

do 
	{
		if(get1==0){
			cout << "Enter first operand (integer): >";
		if (!(cin >> get1)) {
			cout << "Did you even try?" << endl;
			cin.clear();
			cin.ignore(1000, '\n');
			}
		}
		else {
			if(get2==0)cout << "Enter second operand (integer): >";
			if (!(cin >> get2)){
				cout << "Cmon! You can do it!" << endl;
				cin.clear();
				cin.ignore(1000, '\n');
			}
			else cout << "Good boy! Press ENTER to continue" << endl;		
		}
		
	} while (get1==0 || get2==0);

a881909943.png

 

Thanks a lot!

Edited by Flandria4
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0