• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
aregee

Beach ball when adding a massive amount of rows to NSTableView using NSArrayController

2 posts in this topic

In my audio player, I am adding a ton of items to a NSTableView through an NSArrayController.

 

Moving the process to an NSOperation with a NSOperationQueue, I hoped to get rid of waiting for a long time for my window to open, and also that my application would be immediately responsive.

 

Here is my NSOperation (.h-file):

#import <Foundation/Foundation.h>
#include "STASearchForMediaProtocol.h"

@interface STASearchForMediaOperation : NSOperation {
    NSString *pathToSearch;
    BOOL searchRecursive;
    NSOperationQueue *ownOperationQueue;
    id <STASearchForMediaProtocol> ourDelegate;
}

- (id)initWithFilePath:(NSString *)path recursiveSearch:(BOOL)recursive usingOperationQueue:(NSOperationQueue *)operationQueue withDelegate:(id)delegate;

@end

Here is my NSOperation (.m-file):

 
#import "STASearchForMediaOperation.h"

@implementation STASearchForMediaOperation

- (id)init {
    self = [super init];
    
    if (self) {
        pathToSearch = nil;
        searchRecursive = NO;
        ownOperationQueue = nil;
        ourDelegate = nil;
    }
    
    return self;
}

- (id)initWithFilePath:(NSString *)path recursiveSearch:(BOOL)recursive usingOperationQueue:(NSOperationQueue *)operationQueue withDelegate:(id)delegate {
    self = [self init];
    
    if (self) {
        pathToSearch = path;
        searchRecursive = recursive;
        ownOperationQueue = operationQueue;
        ourDelegate = delegate;
    }
    
    return self;
}

- (void)searchPathForSong:(NSString *)path {
    NSFileManager *fileManager = [NSFileManager defaultManager];
    NSError *error = nil;
    NSArray *paths = [fileManager contentsOfDirectoryAtPath:path error:&error];
    if (error != nil) {
        printf("Error reading path '%s'.", [path UTF8String]);
        return;
    }
    BOOL isDirectory = NO;
    for (NSString *item in paths) {
        NSString *itemPath = [NSString stringWithFormat:@"%@/%@", path, item];
        BOOL fileExistsAtPath = [[NSFileManager defaultManager] fileExistsAtPath:itemPath isDirectory:&isDirectory];
        if (fileExistsAtPath) {
            if (isDirectory)
            {
                //We need our own operation queue to post further searches
                if (searchRecursive && (ownOperationQueue != nil)) {
                    NSOperation *newOperation = [[STASearchForMediaOperation alloc] initWithFilePath:itemPath recursiveSearch:searchRecursive usingOperationQueue:ownOperationQueue withDelegate:ourDelegate];
                    [newOperation addDependency:self];
                    [ownOperationQueue addOperation:newOperation];
                }
            }
        }
        if ([[item pathExtension] isEqualToString:@"mp3"]) {
            NSMutableArray *array = [[NSMutableArray alloc] initWithCapacity:2];
            [array addObject:item];
            [array addObject:itemPath];
            if (ourDelegate != nil) {
                [(NSObject *)ourDelegate performSelectorOnMainThread:(@selector(signalMp3FileFound:)) withObject:array waitUntilDone:YES];
            }
        }
        else if ([[item pathExtension] isEqualToString:@"flac"]) {
            NSMutableArray *array = [[NSMutableArray alloc] initWithCapacity:2];
            [array addObject:item];
            [array addObject:itemPath];
            if (ourDelegate != nil) {
                [(NSObject *)ourDelegate performSelectorOnMainThread:(@selector(signalFlacFileFound:)) withObject:array waitUntilDone:YES];
            }
        }
        else if ([[item pathExtension] isEqualToString:@"wav"]) {
            NSMutableArray *array = [[NSMutableArray alloc] initWithCapacity:2];
            [array addObject:item];
            [array addObject:itemPath];
            if (ourDelegate != nil) {
                [(NSObject *)ourDelegate performSelectorOnMainThread:(@selector(signalWavFileFound:)) withObject:array waitUntilDone:YES];
            }
        }
        else if ([[item pathExtension] isEqualToString:@"aiff"]) {
            NSMutableArray *array = [[NSMutableArray alloc] initWithCapacity:2];
            [array addObject:item];
            [array addObject:itemPath];
            if (ourDelegate != nil) {
                [(NSObject *)ourDelegate performSelectorOnMainThread:(@selector(signalAiffFileFound:)) withObject:array waitUntilDone:YES];
            }
        }
        
        if ([self isCancelled]) {
            break;
        }
    }
}

- (void)main {
    @autoreleasepool {
        if (ourDelegate != nil)
        {
            [ourDelegate signalBeginUpdate];
        }
        
        [self searchPathForSong:pathToSearch];
        
        if (ourDelegate != nil)
        {
            [ourDelegate signalEndUpdate];
        }
    }
}

@end

My protocol for the delegate:

@protocol STASearchForMediaProtocol <NSObject>

@required
- (void)signalBeginUpdate;
- (void)signalEndUpdate;
- (void)signalMp3FileFound:(id)object;
- (void)signalFlacFileFound:(id)object;
- (void)signalWavFileFound:(id)object;
- (void)signalAiffFileFound:(id)object;

@end

My app delegate methods that are being used for this purpose:

- (void)signalBeginUpdate {
    if (updateCount == 0) {
        [tableViewRef beginUpdates];
    }
    
    updateCount++;
}

- (void)signalEndUpdate {
    updateCount--;
    
    if (updateCount == 0) {
        [tableViewRef endUpdates];
    }
}

- (void)signalMp3FileFound:(id)object {
    @autoreleasepool {
        NSArray *items = (NSArray *)object;
        [self addSongWithArtist:@"Music" album:@"MP3" song:(NSString *)[items objectAtIndex:0] fileName:(NSString *)[items objectAtIndex:1]];
    }
}

- (void)signalFlacFileFound:(id)object {
    @autoreleasepool {
        NSArray *items = (NSArray *)object;
        [self addSongWithArtist:@"Music" album:@"FLAC" song:(NSString *)[items objectAtIndex:0] fileName:(NSString *)[items objectAtIndex:1]];
    }
}

- (void)signalWavFileFound:(id)object {
    @autoreleasepool {
        NSArray *items = (NSArray *)object;
        [self addSongWithArtist:@"Music" album:@"WAV" song:(NSString *)[items objectAtIndex:0] fileName:(NSString *)[items objectAtIndex:1]];
    }
}

- (void)signalAiffFileFound:(id)object {
    @autoreleasepool {
        NSArray *items = (NSArray *)object;
        [self addSongWithArtist:@"Music" album:@"AIFF" song:(NSString *)[items objectAtIndex:0] fileName:(NSString *)[items objectAtIndex:1]];
    }
}

The 'addSongWithArtist:album:song:fileName:' method:

- (void)addSongWithArtist:(NSString *)artist album:(NSString *)album song:(NSString *)song fileName:(NSString *)fileName {
    internalIDCounter++;

    [ArrayControllerRef addObject:[NSMutableDictionary dictionaryWithObjectsAndKeys:artist, @"Artist", album, @"Album", song, @"Song", fileName, @"fileName", [NSNumber numberWithUnsignedLong:internalIDCounter], @"iID", nil]];
}

How I initiate the NSOperation:

    updateCount = 0;
    fileSearchQueue = [[NSOperationQueue alloc] init];
    [fileSearchQueue setName:@"File search operation queue"];
    
    STASearchForMediaOperation *searchForMedia = [[STASearchForMediaOperation alloc] initWithFilePath:@"/Volumes/Music/UNSORT" recursiveSearch:YES usingOperationQueue:fileSearchQueue withDelegate:self];
    [fileSearchQueue addOperation:searchForMedia];

My problem is...

 

As the code is right now: I still have to wait for the process to complete before the window opens. With beach ball...  It takes an awful long time...  I never waited long enough to see the app really start.

 

If I change 'waitUntilDone' to 'NO', I get the window straight away as I want, but with a little period of 'hiccups' with beach ball and waiting.  I also get a 'NSLog'-message:

 

"CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces."

 

It is also random how many songs will actually be in my NSTableView.  Often it has a lot of empty rows.

 

I guess this is because the threads gets deleted before my table view manages to retrieve the data since I don't 'waitUntilDone'.

 

Does anyone have a suggestion:

1. How to fix my solution?

2. A better solution to solve my problem?

 

0

Share this post


Link to post
Share on other sites

I did a little change.  Instead of spawning a new operation for each directory recursion, I just did the same recursion on the same thread.  It might not have been a good way to do this anyway.  This made the whole process much much faster, and I didn't get the suspected deadlock-situation I got sometimes any more either.  I still get the message about: 

 

"CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces."

 

I am not sure yet why exactly the mechanism why that happens yet, but I will continue to investigate.

 

No-one has any ideas?

0

Share this post


Link to post
Share on other sites

Never mind...  I forgot to call the beginUpdate and endUpdate on the main thread...

1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0