• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
NewVoxel

Using member functions of referenced vector C++

7 posts in this topic

I'm having trouble understanding why I can't access the member functions of a vector that I've referenced into a function. I'm trying to overide the << operator for a class I've made that is meant to hold some card objects.

 

Deck.h

#ifndef _deck_h
#define _deck_h
#include "card.h"
#include <vector>

/// This class provides several functions for creating and handling a deck of cards.

using namespace std;

class Deck
{
public:

    /// \brief
    ///
    /// No Argument constructor – Creates a dynamic array of Card objects and initialises them. Initialises cardsDealt to 0.
    ///
    Deck();

    /// \brief
    ///
    /// Destructor – deletes the dynamic array
    ///
    ~Deck();

    /// \brief
    ///
    /// Gets the next card from the deck
    ///
    /// \return Card - AD, 9S, ... etc
    ///
    Card dealNextCard();

    /// \brief
    ///
    /// Shuffles the cards in the deck
    ///
    void shuffle();

    /// \brief
    ///
    /// Sends a string representation of the cards in the deck to the output stream.
    ///
    friend ostream& operator<<(ostream& out, Deck& deck);

private:
    vector<Card> deck;
    int cardsDealt;
};


#endif // _deck_h

Deck.cpp

#include "deck.h"
#include "card.h"
#include <iostream>
#include <algorithm>

//Creates a dynamic array of Card objects and initialises them. Initialises cardsDealt to 0.
Deck::Deck()
{
    cardsDealt = 0;
    for(int suits = CLUBS; suits <= SPADES; suits++)
    {
        for(int ranks = TWO; ranks <= ACE; ranks++)
        {
            deck.push_back(Card(static_cast<Rank>(ranks), static_cast<Suit>(suits)));
        }
    }
}

//Destructor
Deck::~Deck()
{
    //~No objects to be deleted
}

//Gets the next card from the deck
Card Deck::dealNextCard()
{
    Card cardDealt = deck.back();
    deck.pop_back();
    return cardDealt;
}

//Shuffles the cards in the deck
void Deck::shuffle()
{
    random_shuffle(deck.begin(), deck.end());
}

//Sends a string representation of the cards in the deck to the output stream.
ostream& operator<<(ostream& out, Deck& deck)
{
    deck.begin();
}

main.cpp

/*
 * File: shuffle.cpp
 * Creates a deck of cards, shuffles them and displays them.
 */

#include <iostream>
#include <iomanip>

#include "deck.h"

using namespace std;

int main() {

	Deck deck;
	cout << deck << endl << endl;

	deck.shuffle();
    cout << deck << endl << endl;

	return 0;
}


The problem occurs at the bottom of my Deck.cpp file. When the program is run it gives me "error 'class Deck' has no member named 'begin'" Which is true that it doesn't, but I thought I was passing in a reference to the vector<Card> deck variable that I make in the Decks constructor which does have access to all of the vectors functions as you can imagine.

 

So is the only way I can get the functionality of a vector in my reference to copy the functions over into my Deck class like so:

Card Deck::getLastCard()
{
    return deck.back();
}

for every method or is there a simpler way. All I want to do is iterate over the cards in the Deck and present them on screen but this minor reference has stopped me dead in my tracks.

1

Share this post


Link to post
Share on other sites

Well I'm an idiot. Turns out all I had to do was reference the deck inside my reference to gain access to the functions.

ostream& operator<<(ostream& out, Deck& deck)
{
    deck.deck.begin();
}

I'll remind myself not to use stupid names again.

2

Share this post


Link to post
Share on other sites

 

I think you're confused because you named a member variable with the same name as your class (and input parameter).

 

Look, you have:

//Sends a string representation of the cards in the deck to the output stream.
ostream& operator<<(ostream& out, Deck& deck)
{
    deck.begin();
}

You probably want:

//Sends a string representation of the cards in the deck to the output stream.
ostream& operator<<(ostream& out, Deck& deck)
{
    deck.deck.begin();
}

Ha yeah thanks just figured it out. Helps a lot to step back and try to explain what's going on. Got rid of the tunnel vision I've had for the past hour or so.

2

Share this post


Link to post
Share on other sites


NewVoxel, you actually don't need a destructor for your deck class. The vector will clean up after itself.

 

Probably should remove that. Bad habbit I've gotten into putting them in everything.

 


Also for your stream operator, you probably want a const reference

 

Guessing it's common practice to declare everything that won't be changed. Don't suppose I should put the deck argument in all capitals aswell heh heh.

 


Finally, when you initialise your class, you may as well initialise your vector since you know the size.

 

Thought about doing that but, I'll probably do that by passing in an argument to a seperate constructor as my deck needs to change size for testing.

 


But if you want to do things like evaluating a poker hand, bitboard is the way to go.

What game is it you are implementing?

 

Not sure how this bitboard would be implemented, but I'll look into it. I'm sure what I have at the moment will suffice though. I'm just working on a card game called bridge; I guess it's kind of like uno. Basically up to the logic part now having mostly set up the player hands. I just have to automate the game so all the computers make the right move according to their hands.

2

Share this post


Link to post
Share on other sites

 

 

I think you're confused because you named a member variable with the same name as your class (and input parameter).

 

Look, you have:

//Sends a string representation of the cards in the deck to the output stream.
ostream& operator<<(ostream& out, Deck& deck)
{
    deck.begin();
}

You probably want:

//Sends a string representation of the cards in the deck to the output stream.
ostream& operator<<(ostream& out, Deck& deck)
{
    deck.deck.begin();
}

Ha yeah thanks just figured it out. Helps a lot to step back and try to explain what's going on. Got rid of the tunnel vision I've had for the past hour or so.

 

 

I find it quite interesting how much clarity you gain from merely explaining the problem to someone else, often the solution pops into your head right there. :)

 

I suppose that is why they say if you really want to master a topic you should try teach it to other people.

1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0