Im trying to get Zelda style textbox going where it draws letter by letter, but Im having trouble doing this as nothing appears on my screen. Here is my function:

void drawtext2 (char text[], int x, int y)
{
	//Help delay writing the text
	int timecounter = 0;
	int delay = 100;

	//Counter
	int i;

	//Store letters in here
	char s[2] = {0,0};

	//Helps in the placing of each letter
	int px = x;

	//Now lets start drawing each letter
	for(i = 0; i < strlen(text); i++)
	{
		//First Grab a letter from the text array 
		s[0] = text[i];

		//Now lets draw it
		//Check to see if the timecounter has surpassed the delay counter
		if(++timecounter > delay)
		{
			//Now draw the letter
			al_draw_text(font, al_map_rgb(255, 255, 255), px, y, NULL, s);
			//Play the beep for the letter draw
			al_play_sample_instance(beepInstance);
			cout << s[0] << endl;

			//Increment some space for the next letter
			px += al_get_text_width(font, s);

			//After all that, reset the counter
			timecounter = 0;
		}
	}

	
}

The timecounter variable is created and set to 0 every time the function is called.

I'm thinking unless you pass in a text string which is at least 100 characters long, nothing will ever display.

Setting it to static might work, but you don't want to increment it within the for loop. You want to increment it before the for loop occurs.

Imagine delay was = 3. Updating timecounter inside the for loop would make every 4th character be written.

(char0, timecounter = 1, char1, timecounter = 2, char2, timecounter = 3, char3, timecounter = 4 --> greater than delay, print char3)

An alternative to setting timecounter to static would be to calculate the amount of characters to print outside of the drawtext2 function and pass it through as a new parameter to drawtext2, e.g. as int numCharsToPrint.

In either case (static or gotten from from parameter), the for loop would then just loop through (for int i = 0; i < numCharsToPrint; i++) //print;

Do you really intend to print the character + a newline using cout? I'm guessing this is for debugging purposes.

I don't see a reason for declaring int i outside of the for loop.

A lot of games have it so the text prints more quickly if a specific button is held down. You could do this by not resetting timecounter everytime you print.

You'd then do something like...

timecounter += buttonPressed ? 50 : 1;

if (timecounter > (delay * i + 1))

Sorry if the post is somewhat jumbled, quite tired.

But I don't get it, what does timecounter and delay have to do with the printing of the characters. They are only there to slow the printing down.

Well I think Im heading in the right place, its still funky but I came up with this:

What happens now is that the text does slowly print according to each second passed, but each letter moves off the screen way too fast

void DrawScrollText(char text[], int &x, int &y)
{
	timeElapsed = al_get_time() - tickCounter;
	storage[0] = text[timeElapsed];

	if(timeElapsed < strlen(text))
	{
		al_draw_text(font, al_map_rgb(255, 255, 255), 
		         x += al_get_text_width(font, storage), y, NULL, storage);
		al_play_sample_instance(beepInstance);
	}
	else
		return;
}

I would appreciate more feedback, I want to get this working

Well this is what Im doing now: Here is the function to write the scrolling text box:

//Scrolling text box function
void DrawScrollText(char text[], int &x, int y)
{
        //Record the previous elapsed time
	oldTime = timeElapsed;

        //Get the current time minus the tickcounter from the game
	timeElapsed = al_get_time() - tickCounter;

        //Store a letter from the text array
	storage[0] = text[timeElapsed];
	
        //Bounds checking, don't write more than whats in the text array
	if(timeElapsed < strlen(text))
	{
                //Draw the text
		al_draw_text(font, al_map_rgb(255, 255, 255), 
		         x += 1 /*al_get_text_width(font, storage)*/, y, NULL, storage);
                
                //If the time elapsed has changed than make a beep
		if(timeElapsed != oldTime)
			al_play_sample_instance(beepInstance);
	}

        //Else don't do anything
	else
	{
		return;
	}
}

Than I have this function where I pass my current position in the text array and print it permanently onto the screen:

void CharsToPrint(int elapsedTime, char text[], int x, int y)
{
	for(int i = 0; i < elapsedTime; i++)
	{
		s[0] = text[elapsedTime];
		al_draw_text(font, al_map_rgb(255, 255, 255), x, y, NULL, s);
		x+=1;
	}
}

The problem Im facing is that the cursor flies right off the screen and the letters don't permantly stay after being printed.

Man this is harder than I thought lol.

I don't want to be rude but when I'm reading your code I get feeling that you don't understand some basic concepts and that you don't understand what you are doing.

Your problem with printing text letter by letter i would solve like:
For index=0 <= number of letters in array
{
Print array[index]
Increment index
pause for like 200 or 300 ms
}

How to implement this concept is up to you, no one here will give you solution on plate.
You ask for feedback from us but you don't give any back. Guys told you some advices but you didn't take them seriously and you repeat same mistakes.
For your second question i won't even reply because it is obviously copy paste of someone else.