• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
kingpinzs

python collision recursion issue

3 posts in this topic

    def touching(self, bubble, bubbles):
        for bubble1 in bubbles:
            bubble_old = bubble1
            if self.color == bubble_old.color and dist(bubble.pos, bubble_old.pos) <= 2 * BUBBLE_RADIUS:
                bubbles.remove(bubble_old)
                self.touching(bubble1, bubbles)
 
 
The error occurs when there are two rows right next to each that need to be removed.

for example like this
x x  x  x  x
x O O O x
x x  O O x
x x  O  x x
       O <-current ball

Traceback (most recent call last):
  File "main.py", line 140, in draw
    if a_bubble.remove_matching(stuck_bubbles):
  File "main.py", line 72, in remove_matching
    self.touching(bubble_old, bubbles)
  File "main.py", line 81, in touching
    self.touching(bubble1, bubbles)
  File "main.py", line 80, in touching
    bubbles.remove(bubble_old)
KeyError: <__main__.Bubble instance at 0x192c878>

 

0

Share this post


Link to post
Share on other sites

I'm struggling to see how you got a KeyError for this, unless you're doing something exotic ( in which case I'll need more code ).

 

Anyway, instead looping through a list and remove elements in the for loop, you should instead try one of the below:

  • Loop through a copy of the list of bubbles, removing from them from the original list ( for bubble1 in bubbles[:]: )
  • Loop through the list using an iterator ( for bubble1 in iter(bubbles): )

 

Also, you don't need to set bubble_old = bubble1. When you remove old_bubble from the list, you still hold the reference to it ( old_bubble is referenced to bubble1 ).

def touching(self, bubble, bubbles):
    for bubble1 in bubbles[:]:
        if self.color == bubble_old.color and dist(bubble.pos, bubble1.pos) <= 2 * BUBBLE_RADIUS:
            bubbles.remove(bubble1)
            self.touching(bubble1, bubbles)
Edited by ScoreX
0

Share this post


Link to post
Share on other sites

    def remove_matching(self, bubbles):
        bubble_old = []
        for bubble in list(bubbles):
            if self.color == bubble.color and self.collide(bubble):
                bubble_old = bubble
                bubbles.remove(bubble)
                self.touching(bubble_old, bubbles)
                return True
        return False

this is the method that calls it. 

The code works when the bubbles are lined up like this

 

x O x

x O x

x O x

  O <-current ball   

 

x  O  x

x  O  x

O O O

   O <-current ball

 

the issue happens with anything like this

 

O O

O O

   O <-current ball

 

I have also tried this

  def touching(self, bubble, bubbles):
        for bubble1 in list(bubbles):
            if self.color == bubble1.color and dist(bubble.pos, bubble1.pos) <= 2 * BUBBLE_RADIUS:
                bubbles.remove(bubble_old)
                self.touching(bubble1, bubbles)

I got the same error

 

and this gets this error RuntimeError: Set changed size during iteration 

    def touching(self, bubble, bubbles):
        for bubble1 in iter(bubbles):
            if self.color == bubble1.color and dist(bubble.pos, bubble1.pos) <= 2 * BUBBLE_RADIUS:
                bubbles.remove(bubble1)
                self.touching(bubble1, bubbles)
Edited by kingpinzs
0

Share this post


Link to post
Share on other sites

I changed bubbles.remove(bubble1)  to bubbles.discard(bubble1) and I no longer get the error. Thanks every one for taking the time to read my post.

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0