• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Sarkurd

Tic Tac Toe need some help

4 posts in this topic

Hi
after some months learing basics of C++, today i started by creating a simple game
but i have a problem

checkwin() doesn't work properly

sorry for my english

#include <iostream>

using namespace std;

char square[10] = { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9' };

void GameBoard();
int checkwin();

int main(){

    GameBoard();
    int choice, i;
    int player = 1;
    char mark;
    do{
        if (player == 1)
            mark = 'X';
        else
            mark = 'O';
        cout << "Player " << player << " Enter a number: ";
        cin >> choice;
        if (choice == 1 && square[1] == '1')
            square[1] = mark;
        else if (choice == 2 && square[2] == '2')
            square[2] = mark;
        else if (choice == 3 && square[3] == '3')
            square[3] = mark;
        else if (choice == 4 && square[4] == '4')
            square[4] = mark;
        else if (choice == 5 && square[5] == '5')
            square[5] = mark;
        else if (choice == 6 && square[6] == '6')
            square[6] = mark;
        else if (choice == 7 && square[7] == '7')
            square[7] = mark;
        else if (choice == 8 && square[8] == '8')
            square[8] = mark;
        else if (choice == 9 && square[9] == '9')
            square[9] = mark;
        else
        {
            cout << "This Block already taken!" << endl;
            player--;
        }
        if (player == 1)
            player++;
        else
            player--;
        system("cls");
        GameBoard();
        i = checkwin();
    } while (i=-1);

    if (i == 1){
        cout << "Player " << player << "is win!" << endl;
    }
    else{
        cout << "Draw!" << endl;
    }
    cin.ignore();
    cin.get();
    return 0;
}

int checkwin()
{
    if (square[1] == square[2] && square[2] == square[3])

        return 1;
    else if (square[4] == square[5] && square[5] == square[6])

        return 1;
    else if (square[7] == square[8] && square[8] == square[9])

        return 1;
    else if (square[1] == square[4] && square[4] == square[7])

        return 1;
    else if (square[2] == square[5] && square[5] == square[8])

        return 1;
    else if (square[3] == square[6] && square[6] == square[9])

        return 1;
    else if (square[1] == square[5] && square[5] == square[9])

        return 1;
    else if (square[3] == square[5] && square[5] == square[7])

        return 1;
    else if (square[1] != '1' && square[2] != '2' && square[3] != '3'
        && square[4] != '4' && square[5] != '5' && square[6] != '6'
        && square[7] != '7' && square[8] != '8' && square[9] != '9')

        return 0;
    else
        return -1;
}

void GameBoard(){
    cout << "         Tic Tac Toe         " << endl << endl;
    cout << "Player 1: X , Player 2: O" << endl;
    cout << "   | " << "  |   " << endl;
    cout << " " << square[1] << " | " << square[2] << " | " << square[3] << " " << endl;
    cout << "___ ___ ___" << endl;
    cout << "   | " << "  |   " << endl;
    cout << " " << square[4] << " | " << square[5] << " | " << square[6] << " " << endl;
    cout << "___ ___ ___" << endl;
    cout << "   | " << "  |   " << endl;
    cout << " " << square[7] << " | " << square[8] << " | " << square[9] << " " << endl;

}

0

Share this post


Link to post
Share on other sites

Hello, while I am not sure I fully understand the way you have done this, I have spotted something that looks suspect.

GameBoard();
i = checkwin();
} while (i=-1);

 

the condition in the do while loop, you are assigning i to -1, not checking for equality, are you sure this is not what you want
}while (i==-1);

 

 

EDIT:

 

I just compiled this, I was correct, change your while condition to what I have and it will work, though now you have another bug, the incorrect player is credited with the win, happy debugging and don't worry, everyone on this site has made the double equals error, probably more than once, you are doing great!

 

OMG i can't believe i made this mistake i was trying to solve this problem the whole night >_< but i couldn't figure out what the problem is

 

Thank you

0

Share this post


Link to post
Share on other sites

One other thing you can do, though disliked by many coders is yoda conditions.

 

This is where instead of i==-1 you write -1==i

If you forget an equals, the compiler will show an error because you cannot assign a value to a constant

2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0