• Advertisement
Sign in to follow this  

OpenGL Interleaved Arrays w/ VBOs?

This topic is 1324 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I've been trying to get interleaved arrays working with core OpenGL for almost a day now, and nothing I try seems to work.  I dunno if it has to do with the offsets for my vertex attributes, the way I'm representing my data, or what.

 

I hate to dump code on you all, but I have to show it to you before I can explain what's going wrong:

/*
 * Vertex declaration
 */
ke_vertexattribute_t va[] =
{
    { 0, 3, GL_FLOAT, No, 6*sizeof(float), 0 },
    { 1, 3, GL_FLOAT, No, 6*sizeof(float), 3*sizeof(float) },
    { -1, 0, 0, 0, 0, 0 },
};

/*
 * Default vertex/fragment programs
 */
char default_vp[] =
"#version 150\n"
"in  vec3 in_pos;\n"
"in  vec3 in_colour;\n"
"out vec3 out_colour;\n"
"void main(void)\n"
"{\n"
"    gl_Position = vec4(in_pos, 1.0);\n"
"    out_colour = in_colour;\n"
"}\n";

char default_fp[] =
"#version 150\n"
"in vec3 out_colour;\n"
"out vec4 colour;\n"
"void main(void)\n"
"{\n"
"	colour = vec4(out_colour, 1.0);\n"
"}\n";

/*
 * Working example
 */
GLfloat vertices[] =
    {	-1.0f, -1.0f, 0.0f, 1.0f, 0.0f, 0.0f,
        1.0f, -1.0f, 0.0f, 1.0f, 1.0f, 0.0f,
        0.0f,  1.0f, 0.0f, 0.0f, 1.0f, 0.0f };
    
    device = ke_create_renderdevice(&desc);
    vb = new ke_ogl_vertexbuffer_t();
    gp = new ke_ogl_gpu_program_t( default_vp, default_fp, NULL, NULL );
    
    vb->set_buffer_data( sizeof( float ) * 18, vertices, No );
    
    device->set_clear_colour_fv( colour );
    
    while( index++ < 60000 )
    {
        device->clear_colour_buffer();
        device->clear_depth_buffer();
        device->set_program( gp );
        device->set_vertex_buffer( vb );
        device->set_vertex_attributes( va );
        device->draw_vertices( GL_TRIANGLES, 0, 3 );
        device->swap();
    }

/*
 * Name: ke_ogl_gpu_program_t::ke_ogl_gpu_program_t
 * Desc: Initializes a GPU program with the shader sources of a vertex and fragment
 *       program. Tesselation and geometry programs are optional.
 *       TODO: Geometry and tesselation programs, allow user defined attribute locations.
 */
ke_ogl_gpu_program_t::ke_ogl_gpu_program_t( char* vertex_program, char* fragment_program, char* tesselation_program, char* geometry_program )
{
    /* Set to uninitialized */
    initialized = No;
    
    GLuint p, f, v, t, g;
    
	v = glCreateShader(GL_VERTEX_SHADER);
	f = glCreateShader(GL_FRAGMENT_SHADER);
    g = glCreateShader(GL_GEOMETRY_SHADER);
    
	const char * vv = vertex_program;
	const char * ff = fragment_program;
    
	glShaderSource(v, 1, &vv, NULL);
	glShaderSource(f, 1, &ff, NULL);
    
	GLint compiled;
    
	glCompileShader(v);
	glGetShaderiv(v, GL_COMPILE_STATUS, &compiled);
	if (!compiled)
	{
		printf("Vertex shader not compiled.\n");
	}
    
	glCompileShader(f);
	glGetShaderiv(f, GL_COMPILE_STATUS, &compiled);
	if (!compiled)
	{
		printf("Fragment shader not compiled.\n");
	}
    
	p = glCreateProgram();
    
	glBindAttribLocation(p, 0, "in_pos");
    glBindAttribLocation(p, 2, "in_normal");
    glBindAttribLocation(p, 1, "in_colour");
    glBindAttribLocation(p, 3, "in_tex1");
    glBindAttribLocation(p, 4, "in_tex2");
    glBindAttribLocation(p, 5, "in_tex3");
    glBindAttribLocation(p, 6, "in_tex4");
    
	glAttachShader(p,v);
	glAttachShader(p,f);
    
	glLinkProgram(p);
	glUseProgram(p);
    
    glDeleteShader(v);
    glDeleteShader(f);
    glDeleteShader(g);
    
    program[0] = p;
    
    initialized = Yes;
}


/*
 * Name: ke_ogl_vertexbuffer::
 * Desc:
 */
ke_ogl_vertexbuffer_t::ke_ogl_vertexbuffer_t()
{
    /* Mark as uninitialized until the end */
    initialized = No;
    
    buffers[0] = 0;
    buffers[1] = 0;
    
    GLenum error = glGetError();
    
    /* Generate vertex buffer object and array */
    glGenVertexArrays( 1, &buffers[0] );
    error = glGetError();

    glGenBuffers( 1, &buffers[1] );
    error = glGetError();
    
    initialized = Yes;
}


void ke_ogl_vertexbuffer_t::set_buffer_data( uint32_t buffer_size, void* vertex_data, bool dynamic )
{
    GLenum error = glGetError();
    
    glBindVertexArray( buffers[0] );
    error = glGetError();
    
    glBindBuffer( GL_ARRAY_BUFFER, buffers[1] );
    error = glGetError();
    
    glBufferData( GL_ARRAY_BUFFER, buffer_size, vertex_data, dynamic ? GL_DYNAMIC_DRAW : GL_STATIC_DRAW );
    error = glGetError();
    
    glBindVertexArray(0);
}

/*
 * Name: ke_ogl_renderdevice::set_vertex_buffer
 * Desc: Sets the current vertex buffer to be used when rendering geometry.
 */
void ke_ogl_renderdevice_t::set_vertex_buffer( ke_vertexbuffer_t* vertexbuffer )
{
    current_vertexbuffer = vertexbuffer;
}

void ke_ogl_renderdevice_t::set_program( ke_gpu_program_t* gpu_program )
{
    /* Save a copy of this program */
    current_gpu_program = gpu_program;
    
    glUseProgram( ((uint32_t*)current_gpu_program->get_private_data())[0] );
}


void ke_ogl_renderdevice_t::set_vertex_attributes( ke_vertexattribute_t* vertex_attributes )
{
    int i = 0;
    
    /* Copy the vertex attributes */
    while( vertex_attributes[i].index != -1 )
    {
        memmove( &current_vertexattribute[i], &vertex_attributes[i], sizeof( ke_vertexattribute_t ) );
        i++;
    }
}

/*
 * Name: ke_ogl_renderdevice::draw_vertices
 * Desc: Draws vertices from the current vertex buffer
 */
void ke_ogl_renderdevice_t::draw_vertices( uint32_t primtype, int first, int count )
{
    GLenum error = glGetError();
    
    /* Get a handle to the vertex array object */
    uint32_t* buffers = (uint32_t*) current_vertexbuffer->get_private_data();
    
    /* Bind the vertex array object and draw the vertices */
    glBindVertexArray( buffers[0] );
    error = glGetError();
    
    glBindBuffer( GL_ARRAY_BUFFER, buffers[1] );
    error = glGetError();
    
    /* Set the vertex attributes before rendering */
    for( int i = 0; current_vertexattribute[i].index != -1; i++ )
    {
        glVertexAttribPointer( current_vertexattribute[i].index,
                              current_vertexattribute[i].size,
                              current_vertexattribute[i].type,
                              current_vertexattribute[i].normalize,
                              current_vertexattribute[i].stride,
                              BUFFER_OFFSET( current_vertexattribute[i].offset ) );
        glEnableVertexAttribArray(i);
    }
    
    glDrawArrays( primtype, first, count );
    error = glGetError();
    glBindVertexArray(0);
}

Okay, this is what goes on when I run this.  If I run this code the way it is, nothing shows up at all.  But if I comment out the 2nd line in my vertex declaration, like so:

/*
 * Vertex declaration
 */
ke_vertexattribute_t va[] =
{
    { 0, 3, GL_FLOAT, No, 6*sizeof(float), 0 },
//    { 1, 3, GL_FLOAT, No, 6*sizeof(float), 3*sizeof(float) },
    { -1, 0, 0, 0, 0, 0 },
};

Then the triangle will render, but solid black.  I've checked the vertex attribute thing many times, and I can't see what's wrong with it.  

 

And lastly, I don't want to limit my engine's rendering capabilities by only allowing multiple vertex buffers per attribute (especially since this is meant to be cross platform compatible with Direct3D), so I'm getting interleaved vertex attributes out of the way early.  Some say that there's likely to be a performance hit, but after doing a little reasearch, it's clear to me that interleaved vertex data works best when data is aligned properly (or is that only for OpenGL ES?).  Any ideas?  Thanks.

 

Shogun

Share this post


Link to post
Share on other sites
Advertisement

Here's your problem:

 

BUFFER_OFFSET( current_vertexattribute[i].offset )

 

What this is actually doing is taking the offset of your offset member and using that as the offset into your vertex format.  Just remove the BUFFER_OFFSET from it and it should work.

Share this post


Link to post
Share on other sites

If your vertex data is interleaved, then the offset between each vertex element will be sizeof of the all the vertex attributes for 1 vertex, thus a constant.

Share this post


Link to post
Share on other sites

If your vertex data is interleaved, then the offset between each vertex element will be sizeof of the all the vertex attributes for 1 vertex, thus a constant.

 

That's the stride, however, rather than the offset of each element, which is where the OP's problem is.

Share this post


Link to post
Share on other sites

 

If your vertex data is interleaved, then the offset between each vertex element will be sizeof of the all the vertex attributes for 1 vertex, thus a constant.

 

That's the stride, however, rather than the offset of each element, which is where the OP's problem is.

..correct and if the data is tightly packed then the stride is what is needed to make that function call do the same thing. Typical interleaved attributes are not sourced from different base pointer. rather each attribute is usually an offset from a common base. With that, the stride will be the offset between each attribute.

Share this post


Link to post
Share on other sites

 

 

If your vertex data is interleaved, then the offset between each vertex element will be sizeof of the all the vertex attributes for 1 vertex, thus a constant.

 

That's the stride, however, rather than the offset of each element, which is where the OP's problem is.

..correct and if the data is tightly packed then the stride is what is needed to make that function call do the same thing. Typical interleaved attributes are not sourced from different base pointer. rather each attribute is usually an offset from a common base. With that, the stride will be the offset between each attribute.

 

 

True, but it's still not the OP's problem.  If you check the posted code you'll see that the stride parameter is quite correct (6 * sizeof (float) for a vertex format of 6 floats) but the offsets are being specified wrong.

Share this post


Link to post
Share on other sites


Here's your problem:

 

BUFFER_OFFSET( current_vertexattribute[i].offset )

 

What this is actually doing is taking the offset of your offset member and using that as the offset into your vertex format.  Just remove the BUFFER_OFFSET from it and it should work.

 

First I wanted to say thanks for your response.  Second, I already tried removing that and replacing with 

&current_vertexattribute[i].offset

instead, but that still doesn't work.  Is there another way to do this?

 



Why are you using a vertex array object, and then rebinding your VBO and setting up the vertex attrib pointer every frame?

 

Aren't VAOs required?  If they weren't, I'd gladly not use them as I find them to be a bit annoying sometimes.  Right now, I just want the stupid thing to work, even if it's wrong, so I can fix it afterwards.

 

Shogun.

 

EDIT: Fixed it.  The answer came to my mind the instant I woke up this morning.  I didn't copy the full contents in my vertex declaration/attribute structure.  The last element is important so that I know when to stop setting attributes.

 /* Copy the vertex attributes */
    while( vertex_attributes[i].index != -1 )
    {
        memmove( &current_vertexattribute[i], &vertex_attributes[i], sizeof( ke_vertexattribute_t ) );
        i++;
    }
    
    memmove( &current_vertexattribute[i], &vertex_attributes[i], sizeof( ke_vertexattribute_t ) );

So now it works, and the triangle is rendering just fine.  I left BUFFER_OFFSET in and it only appears to work with it.

 

Shogun.

Edited by blueshogun96

Share this post


Link to post
Share on other sites

Aren't VAOs required?  If they weren't, I'd gladly not use them as I find them to be a bit annoying sometimes.  Right now, I just want the stupid thing to work, even if it's wrong, so I can fix it afterwards.

VAOs are indeed required in modern OpenGL (well, at least in core profiles).

However, the whole point of VAO is to prevent you from having to rebind all your VBOs and attribute pointers every frame. You can set all that stuff up against the VBO once, and then just rebind the VAO by itself each time you need to draw.

Share this post


Link to post
Share on other sites

Interesting that it worked with BUFFER_OFFSET....

 

You asked if there is another way to do it; here's one that's not quite compatible with your setup, but works fine with MSVC in both C and C++, which I guess is relevant since you mentioned D3D compatibility; it may not be so robust or compatible elsewhere so use with appropriate caution.

 

struct vertextype
{
    float position[3];
    float normal[3];
};

vertextype *v = NULL;

glVertexAttribPointer (0, ..., v->position);
glVertexAttribPointer (1, ..., v->normal);

 

Share this post


Link to post
Share on other sites

First I wanted to say thanks for your response.  Second, I already tried removing that and replacing with 

&current_vertexattribute[i]
instead, but that still doesn't work.  Is there another way to do this?

Should have been:
current_vertexattribute[i].offset

vertextype *v = NULL;

glVertexAttribPointer (0, ..., v->position);
glVertexAttribPointer (1, ..., v->normal);


Should be:
glVertexAttribPointer (0, ..., &v->position);
glVertexAttribPointer (1, ..., &v->normal);
Otherwise you get illegal access.


L. Spiro Edited by L. Spiro

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Now

  • Advertisement
  • Similar Content

    • By khawk
      We've just released all of the source code for the NeHe OpenGL lessons on our Github page at https://github.com/gamedev-net/nehe-opengl. code - 43 total platforms, configurations, and languages are included.
      Now operated by GameDev.net, NeHe is located at http://nehe.gamedev.net where it has been a valuable resource for developers wanting to learn OpenGL and graphics programming.

      View full story
    • By TheChubu
      The Khronos™ Group, an open consortium of leading hardware and software companies, announces from the SIGGRAPH 2017 Conference the immediate public availability of the OpenGL® 4.6 specification. OpenGL 4.6 integrates the functionality of numerous ARB and EXT extensions created by Khronos members AMD, Intel, and NVIDIA into core, including the capability to ingest SPIR-V™ shaders.
      SPIR-V is a Khronos-defined standard intermediate language for parallel compute and graphics, which enables content creators to simplify their shader authoring and management pipelines while providing significant source shading language flexibility. OpenGL 4.6 adds support for ingesting SPIR-V shaders to the core specification, guaranteeing that SPIR-V shaders will be widely supported by OpenGL implementations.
      OpenGL 4.6 adds the functionality of these ARB extensions to OpenGL’s core specification:
      GL_ARB_gl_spirv and GL_ARB_spirv_extensions to standardize SPIR-V support for OpenGL GL_ARB_indirect_parameters and GL_ARB_shader_draw_parameters for reducing the CPU overhead associated with rendering batches of geometry GL_ARB_pipeline_statistics_query and GL_ARB_transform_feedback_overflow_querystandardize OpenGL support for features available in Direct3D GL_ARB_texture_filter_anisotropic (based on GL_EXT_texture_filter_anisotropic) brings previously IP encumbered functionality into OpenGL to improve the visual quality of textured scenes GL_ARB_polygon_offset_clamp (based on GL_EXT_polygon_offset_clamp) suppresses a common visual artifact known as a “light leak” associated with rendering shadows GL_ARB_shader_atomic_counter_ops and GL_ARB_shader_group_vote add shader intrinsics supported by all desktop vendors to improve functionality and performance GL_KHR_no_error reduces driver overhead by allowing the application to indicate that it expects error-free operation so errors need not be generated In addition to the above features being added to OpenGL 4.6, the following are being released as extensions:
      GL_KHR_parallel_shader_compile allows applications to launch multiple shader compile threads to improve shader compile throughput WGL_ARB_create_context_no_error and GXL_ARB_create_context_no_error allow no error contexts to be created with WGL or GLX that support the GL_KHR_no_error extension “I’m proud to announce OpenGL 4.6 as the most feature-rich version of OpenGL yet. We've brought together the most popular, widely-supported extensions into a new core specification to give OpenGL developers and end users an improved baseline feature set. This includes resolving previous intellectual property roadblocks to bringing anisotropic texture filtering and polygon offset clamping into the core specification to enable widespread implementation and usage,” said Piers Daniell, chair of the OpenGL Working Group at Khronos. “The OpenGL working group will continue to respond to market needs and work with GPU vendors to ensure OpenGL remains a viable and evolving graphics API for all its customers and users across many vital industries.“
      The OpenGL 4.6 specification can be found at https://khronos.org/registry/OpenGL/index_gl.php. The GLSL to SPIR-V compiler glslang has been updated with GLSL 4.60 support, and can be found at https://github.com/KhronosGroup/glslang.
      Sophisticated graphics applications will also benefit from a set of newly released extensions for both OpenGL and OpenGL ES to enable interoperability with Vulkan and Direct3D. These extensions are named:
      GL_EXT_memory_object GL_EXT_memory_object_fd GL_EXT_memory_object_win32 GL_EXT_semaphore GL_EXT_semaphore_fd GL_EXT_semaphore_win32 GL_EXT_win32_keyed_mutex They can be found at: https://khronos.org/registry/OpenGL/index_gl.php
      Industry Support for OpenGL 4.6
      “With OpenGL 4.6 our customers have an improved set of core features available on our full range of OpenGL 4.x capable GPUs. These features provide improved rendering quality, performance and functionality. As the graphics industry’s most popular API, we fully support OpenGL and will continue to work closely with the Khronos Group on the development of new OpenGL specifications and extensions for our customers. NVIDIA has released beta OpenGL 4.6 drivers today at https://developer.nvidia.com/opengl-driver so developers can use these new features right away,” said Bob Pette, vice president, Professional Graphics at NVIDIA.
      "OpenGL 4.6 will be the first OpenGL release where conformant open source implementations based on the Mesa project will be deliverable in a reasonable timeframe after release. The open sourcing of the OpenGL conformance test suite and ongoing work between Khronos and X.org will also allow for non-vendor led open source implementations to achieve conformance in the near future," said David Airlie, senior principal engineer at Red Hat, and developer on Mesa/X.org projects.

      View full story
    • By _OskaR
      Hi,
      I have an OpenGL application but without possibility to wite own shaders.
      I need to perform small VS modification - is possible to do it in an alternative way? Do we have apps or driver modifictions which will catch the shader sent to GPU and override it?
    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
    • By Jonathan2006
      My question: is it possible to transform multiple angular velocities so that they can be reinserted as one? My research is below:
      // This works quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); quat quaternion2 = GEMultiplyQuaternions(quaternion1, GEQuaternionFromAngleRadians(angleRadiansVector2)); quat quaternion3 = GEMultiplyQuaternions(quaternion2, GEQuaternionFromAngleRadians(angleRadiansVector3)); glMultMatrixf(GEMat4FromQuaternion(quaternion3).array); // The first two work fine but not the third. Why? quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); vec3 vector1 = GETransformQuaternionAndVector(quaternion1, angularVelocity1); quat quaternion2 = GEQuaternionFromAngleRadians(angleRadiansVector2); vec3 vector2 = GETransformQuaternionAndVector(quaternion2, angularVelocity2); // This doesn't work //quat quaternion3 = GEQuaternionFromAngleRadians(angleRadiansVector3); //vec3 vector3 = GETransformQuaternionAndVector(quaternion3, angularVelocity3); vec3 angleVelocity = GEAddVectors(vector1, vector2); // Does not work: vec3 angleVelocity = GEAddVectors(vector1, GEAddVectors(vector2, vector3)); static vec3 angleRadiansVector; vec3 angularAcceleration = GESetVector(0.0, 0.0, 0.0); // Sending it through one angular velocity later in my motion engine angleVelocity = GEAddVectors(angleVelocity, GEMultiplyVectorAndScalar(angularAcceleration, timeStep)); angleRadiansVector = GEAddVectors(angleRadiansVector, GEMultiplyVectorAndScalar(angleVelocity, timeStep)); glMultMatrixf(GEMat4FromEulerAngle(angleRadiansVector).array); Also how do I combine multiple angularAcceleration variables? Is there an easier way to transform the angular values?
  • Advertisement